May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: avoid NPE whrn imageDomainsList is empty (#746469)
by ofrenkel＠redhat.com 21 May '12

21 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: avoid NPE whrn imageDomainsList is empty (#746469) ...................................................................... core: avoid NPE whrn imageDomainsList is empty (#746469) try to extract the domains list only if the structure contains the domain list. Otherwise return an empty array, fetch the error and propogate a CanDo Message. Change-Id: I96f589c02e8511c60f4543d8296ce1222a9ba4c5 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageDomainsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StorageDomainGuidListReturnForXmlRpc.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 49 insertions(+), 15 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96f589c02e8511c60f4543d8296ce1222a9ba4c5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Allowing to pass directLun disks
by mkublin＠redhat.com 21 May '12

21 May '12

Michael Kublin has submitted this change and it was merged. Change subject: restapi : Allowing to pass directLun disks ...................................................................... restapi : Allowing to pass directLun disks The following code will allow to pass a disk which has luns details via rest api Change-Id: I5ac7300ee625c8a2185bedb092702e6503e380b3 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmDiskParameters.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendReadOnlyDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/LunDiskMapperTest.java 16 files changed, 223 insertions(+), 98 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ac7300ee625c8a2185bedb092702e6503e380b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add support for removing a Template from specified ...
by mpastern＠redhat.com 21 May '12

21 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Add support for removing a Template from specified storage domain(s) ...................................................................... restapi: Add support for removing a Template from specified storage domain(s) added two new signatures: 1. DELETE /api/templates/{template:id}/disks/{disk:id} - used to delete disk based on direct-lun 2. DELETE /api/templates/{template:id}/disks/{disk:id} <action> <storage_domain id="xxx"/> </action> and/or <action> <force>true|false<force/> </action> - used to delete disk from storagedomain or /force/ disk removal Change-Id: I1a4d57d183671f89aea632ef5bb15db5a8fb921f Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDisksResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResourceTest.java 7 files changed, 342 insertions(+), 8 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a4d57d183671f89aea632ef5bb15db5a8fb921f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix NPE in disk validation
by gchaplik＠redhat.com 20 May '12

20 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix NPE in disk validation ...................................................................... webadmin: fix NPE in disk validation Change-Id: Ic23a0a2df37823a188fe18b76532369be3ed01ed Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic23a0a2df37823a188fe18b76532369be3ed01ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: custom properties sheet
by gchaplik＠redhat.com 20 May '12

20 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: custom properties sheet ...................................................................... webadmin: custom properties sheet feature page: http://www.ovirt.org/wiki/Features/CustomPropertiesSheet missing: -image for buttons (plus, minus) -dropdown for limited values (v1|v2|...|vn) Change-Id: Ibf2020252e5af0339d0699b83117cc1b536fb93b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/IModifyLines.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueLineModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 20 files changed, 796 insertions(+), 124 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf2020252e5af0339d0699b83117cc1b536fb93b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Process empty string in regex validation
by gchaplik＠redhat.com 20 May '12

20 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Process empty string in regex validation ...................................................................... webadmin: Process empty string in regex validation Change-Id: Iad1e61049efe29ac9f82fe42b44748ba72c5f3c9 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/RegexValidation.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad1e61049efe29ac9f82fe42b44748ba72c5f3c9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disks Copy allow source selection
by derez＠redhat.com 20 May '12

20 May '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disks Copy allow source selection ...................................................................... webadmin: Disks Copy allow source selection Allow source selection on Copy dialog of Disks Main-Tab. Change-Id: I37f6f35d3282faadc83949ce64c790bb92efc7d0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/CopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java 3 files changed, 3 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37f6f35d3282faadc83949ce64c790bb92efc7d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Filter domains on new VM from template
by derez＠redhat.com 20 May '12

20 May '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Filter domains on new VM from template ...................................................................... webadmin: Filter domains on new VM from template Resource allocation tab - in case a template-disk reside only on non-active storage domain(s), then the "Target" drop-down should be empty (for both "Thin" and "Clone" provisioning). Change-Id: I775ea0868f4ab89ab27c252c7c244f34d4be221c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 4 files changed, 38 insertions(+), 26 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4558 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I775ea0868f4ab89ab27c252c7c244f34d4be221c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: ovirt-engine: fixing installCA_dev to work without ovirt-eng...
by oschreib＠redhat.com 20 May '12

20 May '12

Ofer Schreiber has submitted this change and it was merged. Change subject: ovirt-engine: fixing installCA_dev to work without ovirt-engine rpms ...................................................................... ovirt-engine: fixing installCA_dev to work without ovirt-engine rpms Change-Id: I103352dbd6bab68d783c61a87fafeabce8776a77 Signed-off-by: eedri(a)redhat.com --- M backend/manager/conf/ca/installCA_dev.sh 1 file changed, 37 insertions(+), 5 deletions(-) Approvals: Eyal Edri: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I103352dbd6bab68d783c61a87fafeabce8776a77 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Fixing bug with remove of lun disk
by mkublin＠redhat.com 20 May '12

20 May '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing bug with remove of lun disk ...................................................................... core : Fixing bug with remove of lun disk The following fix will solve a problem with removing of lun disk Change-Id: I698fb815f3760851ee6164430102b77691741980 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I698fb815f3760851ee6164430102b77691741980 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0