May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: isHostAvailable was not updated
by vszocs＠redhat.com 10 May '12

10 May '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: isHostAvailable was not updated ...................................................................... userportal: isHostAvailable was not updated The UserPortalExistingVmModelBehavior.DataCenter_SelectedItemChanged was Overrides the parent but does not set the setIsHostAvailable on the model. Added. Change-Id: I01facc45809aae7022f41900be54d4a4c306063e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmClonePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDesktopNewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmServerNewPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java 5 files changed, 45 insertions(+), 84 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01facc45809aae7022f41900be54d4a4c306063e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: GetAnyVm->GetVmDataByPoolId
by vszocs＠redhat.com 10 May '12

10 May '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal, webadmin: GetAnyVm->GetVmDataByPoolId ...................................................................... userportal, webadmin: GetAnyVm->GetVmDataByPoolId Replaced all the calling to AsyncDataProvider.GetAnyVm by calling the GetVmDataByPoolIdQuery. Change-Id: Ifcd4fe5c1acdc9f3e2dccbcbb13009883483b425 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmBasicDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmAppListModel.java 8 files changed, 82 insertions(+), 53 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcd4fe5c1acdc9f3e2dccbcbb13009883483b425 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Filter public queries
by vszocs＠redhat.com 10 May '12

10 May '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal,webadmin: Filter public queries ...................................................................... userportal,webadmin: Filter public queries This patch should be applied after public queries have their auth type changed to User (making them user queries). Change-Id: I802cff9341b41e8535c95fc815a1a55721e8836c Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I802cff9341b41e8535c95fc815a1a55721e8836c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Support Sysprep for 3.1 and up (#811587)
by masayag＠redhat.com 10 May '12

10 May '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Support Sysprep for 3.1 and up (#811587) ...................................................................... core: Support Sysprep for 3.1 and up (#811587) https://bugzilla.redhat.com/811587 The patch uses the VM Payload to provide the Sysprep file content to the VDSM when running a VM for cluster level 3.1 and up. Floppy device isn't created implicitly in 3.1 therefore engine should ask the agent to create one and treats it as unmanaged device so it won't be persistent to the engine-db, and treated as stateless. Change-Id: I9c1f7f3edcc3aea7e38b3c6a7efdfebdd24269f1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVmFromSysPrepVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 8 files changed, 69 insertions(+), 16 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1f7f3edcc3aea7e38b3c6a7efdfebdd24269f1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clear NPEs from unit-tests
by masayag＠redhat.com 10 May '12

10 May '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Clear NPEs from unit-tests ...................................................................... core: Clear NPEs from unit-tests The patch replaces a direct call in AuditLogableBase to DbFacade.getInstance() called on members initialization so mocking DbFacage will not be required for each command class creation. Change-Id: I42b9391c350ebfb943052038d90d997373dd141d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 2 files changed, 22 insertions(+), 17 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42b9391c350ebfb943052038d90d997373dd141d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Adding canDoactionMessage for direct lun flow
by mkublin＠redhat.com 10 May '12

10 May '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Adding canDoactionMessage for direct lun flow ...................................................................... core : Adding canDoactionMessage for direct lun flow The following patch will all a canDoAction check for case whne a provided lun is alreday used by other disk. It is not allowed to create more than one disk based on the same lun Change-Id: I7572ce0dda91d1e7c89eb7520daae102c834fe11 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 20 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7572ce0dda91d1e7c89eb7520daae102c834fe11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: db - fixing configuration settings This patch modifies...
by emesika＠redhat.com 10 May '12

10 May '12

Eli Mesika has submitted this change and it was merged. Change subject: core: db - fixing configuration settings This patch modifies the following configuration values settings: ...................................................................... core: db - fixing configuration settings This patch modifies the following configuration values settings: DisableFenceAtStartupInSec LogPhysicalMemoryThresholdInMB oVirtISOsRepositoryPath VdsLocalDisksCriticallyLowFreeSpace VdsLocalDisksLowFreeSpace Note : these values may be customized by the engine-config tool and if value was updated, we should honor new value. The following configuration values have the same value in "add" and "update" section and were removed from the upgrade section: DisableFenceAtStartupInSec LogPhysicalMemoryThresholdInMB The following configuration values had been changed from the default but we should verify when updating these values that it were not already changed using the engine-config tool. These is done by updating the value only if the current value matches the default value given as an argument to the update function: oVirtISOsRepositoryPath VdsLocalDisksCriticallyLowFreeSpace VdsLocalDisksLowFreeSpace Change-Id: Ifdaf26d9c1934635e9b2942be9139e9aa6731c30 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdaf26d9c1934635e9b2942be9139e9aa6731c30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DataProvider now returns also POSIX for DC types
by yzaslavs＠redhat.com 10 May '12

10 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: DataProvider now returns also POSIX for DC types ...................................................................... webadmin: DataProvider now returns also POSIX for DC types Acked-By: Change-Id: Ie89499fe9ca602b7938c6dde991698dcd03db194 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie89499fe9ca602b7938c6dde991698dcd03db194 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: disable user query filter for quota
by ecohen＠redhat.com 10 May '12

10 May '12

Einav Cohen has submitted this change and it was merged. Change subject: engine: disable user query filter for quota ...................................................................... engine: disable user query filter for quota Change-Id: I633c1b6209e89dc463a56c27a76200c03faa78c5 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I633c1b6209e89dc463a56c27a76200c03faa78c5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disable user queries filtering
by ecohen＠redhat.com 10 May '12

10 May '12

Einav Cohen has submitted this change and it was merged. Change subject: core: Disable user queries filtering ...................................................................... core: Disable user queries filtering Due to stability issues, this feature is temporarily disabled. Once these issues are solved, we will reenable it. Change-Id: I62d348262f742a4ad7c189416915b9f524aaccc4 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java 2 files changed, 16 insertions(+), 15 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62d348262f742a4ad7c189416915b9f524aaccc4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0