May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: release 2.1.6-1
by mpastern＠redhat.com 10 May '12

10 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 2.1.6-1 ...................................................................... cli: release 2.1.6-1 Change-Id: I4365fda876f00ab84fe730332c141b6e9ac56b64 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4365fda876f00ab84fe730332c141b6e9ac56b64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix query result exceptionString NPE
by vszocs＠redhat.com 10 May '12

10 May '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix query result exceptionString NPE ...................................................................... webadmin,userportal: Fix query result exceptionString NPE This fixes a NPE in case query result exceptionString is null while attempting to detect "USER_IS_NOT_LOGGED_IN" message that should result in NotLoggedInEvent being triggered by Frontend. Duplicate code moved into Frontend handleNotLoggedInEvent method. Change-Id: I238751e26d716c1653af85ebf837981a952f6779 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I238751e26d716c1653af85ebf837981a952f6779 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Remove pregenerated parsing tables
by mpastern＠redhat.com 10 May '12

10 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Remove pregenerated parsing tables ...................................................................... cli: Remove pregenerated parsing tables Parsing tables should be generated when the package is built and not included in the repository. Change-Id: I09d623c00ba52c9ce6f811afe4d18dfbe3025116 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-cli.spec.in D parser_lex.py D parser_tab.py D src/ovirtcli/parser_lex.py D src/ovirtcli/parser_tab.py 5 files changed, 10 insertions(+), 150 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d623c00ba52c9ce6f811afe4d18dfbe3025116 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Remove legacy UserPortal from build process
by ecohen＠redhat.com 10 May '12

10 May '12

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Remove legacy UserPortal from build process ...................................................................... userportal: Remove legacy UserPortal from build process Summary of changes: 1. Legacy (SmartGWT-based) UserPortal is no longer built during full oVirt Maven build 2. Updated Maven artifact IDs: - old UserPortal: userportal -> userportal-legacy - new UserPortal: userportal-gwtp -> userportal Note: project directory names are left unchanged for now, this will be changed later on. 3. EAR module now includes only new UserPortal, with legacy UserPortal configuration being commented out 4. Updated UserPortal deploy path and servlet code: http(s)://<server-address>[:<port>]/UserPortal/ >org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html 5. Updated Maven profile names: - old UserPortal: gwt-user -> gwt-user-legacy - new UserPortal: gwt-user-gwtp -> gwt-user 6. Removed "userportal-gwtp.war" from RPM spec file (ovirt-engine.spec.in) 7. Updated UserPortal URL in WebAdminConfigurator and UserPortalConfigurator, to correspond with location Spice RPM uses to extract necessary client files (e.g. Windows CAB files for Spice on IE) Change-Id: I99d9e5b5b89a0c9633c89d211e5a569276a37a40 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M ear/pom.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/UserportalDynamicHostingServlet.java M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/public/consoles/spice/usbfilter.txt M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/index.html M frontend/webadmin/modules/userportal/pom.xml M frontend/webadmin/modules/userportal/src/main/java/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java M packaging/fedora/spec/ovirt-engine.spec.in 13 files changed, 34 insertions(+), 35 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99d9e5b5b89a0c9633c89d211e5a569276a37a40 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: gitignore: ignore PLY-generated files
by mpastern＠redhat.com 10 May '12

10 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: gitignore: ignore PLY-generated files ...................................................................... gitignore: ignore PLY-generated files The files: parser_lex.py and parser_tab.py are generated by PLY. Add them to .gitignore to avoid including them in patches. Change-Id: Ifb0f4a65f512c972bd3d0a27690aa16ddeba826e Signed-off-by: Adam Litke <agl(a)us.ibm.com> --- M .gitignore 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Adam Litke: Verified Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb0f4a65f512c972bd3d0a27690aa16ddeba826e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: add missing snapshot collections
by mpastern＠redhat.com 10 May '12

10 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: add missing snapshot collections ...................................................................... restapi: add missing snapshot collections Change-Id: I28e7fa93f0ea0dc3c10a0ae1d7601370099093f8 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 42 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28e7fa93f0ea0dc3c10a0ae1d7601370099093f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix EmulatedMachine config value for 3.0
by emesika＠redhat.com 10 May '12

10 May '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fix EmulatedMachine config value for 3.0 ...................................................................... core: fix EmulatedMachine config value for 3.0 This value should be updated only if not changed (i.e. default value is used) Change-Id: If82c854744a33af67a2d1fe5145dc4a1ff5b3c0d Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If82c854744a33af67a2d1fe5145dc4a1ff5b3c0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing config setting in wrong block
by emesika＠redhat.com 10 May '12

10 May '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing config setting in wrong block ...................................................................... core: fixing config setting in wrong block The config.sql is ordered according to sections (please see header file for details) In addition , config keywords should be kept sorted. Change-Id: I40c2c5ab3dd26998fdfbd143c2207e0f184c4885 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40c2c5ab3dd26998fdfbd143c2207e0f184c4885 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Scheduling Jobs with Configurable Delay
by msalem＠redhat.com 10 May '12

10 May '12

Muli Salem has submitted this change and it was merged. Change subject: core: Scheduling Jobs with Configurable Delay ...................................................................... core: Scheduling Jobs with Configurable Delay This patch changes the relevant jobs to be scheduled with a configurable delay. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: I7b0d35de9d1a29712e058892df50c49f72027686 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsLoadBalancer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryCleanupManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 7 files changed, 27 insertions(+), 29 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b0d35de9d1a29712e058892df50c49f72027686 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: after running vm as stateless we can no longer run the...
by emesika＠redhat.com 10 May '12

10 May '12

Eli Mesika has submitted this change and it was merged. Change subject: core: after running vm as stateless we can no longer run the vm ...................................................................... core: after running vm as stateless we can no longer run the vm Was unable to reproduce the bug. Reported scenario worked in both run and run-once no matter if VM was stateless and stateless set to false in run-once or vice-versa. Fixied a bug in stateless VM unmanaged devices cleanup that were cleaned up to now only when VM was suspended and then stop rather than on stop from any state as it should be. Change-Id: Ia139e98596715bb3b09a589da6dfae98a38b7249 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java 1 file changed, 17 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia139e98596715bb3b09a589da6dfae98a38b7249 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0