May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix DISK CREATOR role
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Fix DISK CREATOR role ...................................................................... core: Fix DISK CREATOR role DISK CREATOR role was mistakenly given extra action groups. This patch fixes that problems, and reduces the role back to its intended purpose - creating disks. Change-Id: I1a22426f165d8326f85fecbe84417668c7eac55c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1150_remove_unneeded_groups_from_disk_creator.sql 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a22426f165d8326f85fecbe84417668c7eac55c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VM and Template creator roles
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: VM and Template creator roles ...................................................................... core: VM and Template creator roles Added two new predefined roles - VM creator and Template creator to allow admins to give their users a way of creating VM/templates without having permissions to see other user's objects. Change-Id: Id9e5e9e69779ed291e86c888968ce0419e064a19 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1140_add_creator_roles.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java 2 files changed, 53 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9e5e9e69779ed291e86c888968ce0419e064a19 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup PredifnedRoles
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Cleanup PredifnedRoles ...................................................................... core: Cleanup PredifnedRoles Fixed all the Guids to use upper case notation. Change-Id: I5a16596b30e60916e80cee7cf97bbeb05817732b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a16596b30e60916e80cee7cf97bbeb05817732b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Enable allowing view children permissions
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Enable allowing view children permissions ...................................................................... core: Enable allowing view children permissions This patch changes the user permissions views so they take the allows_viewing_children property of the role they are based on into account. Change-Id: I97f2fc3aa5cbd2a845e0a4a4843221079ab63b37 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 20 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97f2fc3aa5cbd2a845e0a4a4843221079ab63b37 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Update roles.allow_viewing_children properly
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Update roles.allow_viewing_children properly ...................................................................... core: Update roles.allow_viewing_children properly This patch contains the logic for updating roles.allow_viewing_children: If a role contains at least one action group that allows viewing children then it too is allows viewing children. This patch contains all the (relevant) places roles are modified: 1. An upgarade script to initialize the property properly 2. When a new action group is attached to a role 3. When an action group is detached from a role 4. When a role is created without action groups 5. When a role is created with action groups Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1130_update_role_allows_viewing_children_column.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AbstractRolesCommandTestBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommandTest.java 9 files changed, 262 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Common method to update brick server name
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Common method to update brick server name ...................................................................... engine: Common method to update brick server name Moved the logic of updating server names in bricks from CreateGlusterVolumeCommand to the base class GlusterCommandBase, and modified CreateGlusterVolumeCommand and ReplaceGlusterVolumeBrickCommand to make use of the same. Change-Id: Id532706d65af4a20f8651202b1b50a1d7572ab46 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommandTest.java 4 files changed, 67 insertions(+), 12 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id532706d65af4a20f8651202b1b50a1d7572ab46 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Gluster Volume Replace brick vdsm verb change
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Gluster Volume Replace brick vdsm verb change ...................................................................... engine: Gluster Volume Replace brick vdsm verb change - Vdsm verb changed - Database updates removed - Audit log Severities added - vdc Action type modified Change-Id: I2d0fd710003e52dee9b5b48fcf80c35405f6c410 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/ReplaceGlusterVolumeBrickVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 9 files changed, 12 insertions(+), 13 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d0fd710003e52dee9b5b48fcf80c35405f6c410 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix for Bricks status is always Down
by ofrenkel＠redhat.com 28 May '12

28 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Fix for Bricks status is always Down ...................................................................... engine: Fix for Bricks status is always Down Updating the Brick status while changing the volume status. https://bugzilla.redhat.com/823550 Change-Id: I51267c9a34dbd584bb577fcf33abcbd6ab97f86e Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java 3 files changed, 14 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51267c9a34dbd584bb577fcf33abcbd6ab97f86e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix vm_device alias upgrade
by oourfali＠redhat.com 28 May '12

28 May '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix vm_device alias upgrade ...................................................................... core: fix vm_device alias upgrade Previous commit added a new column named alias to the vm_device table, with a default of ''. The syntax used for the default was \'\' but looks like new psql versions don't deal with it properly. Using '''' works both in postgresql 8 and 9, so pushing this fix. Change-Id: Ia96c5ad7bfd49ac470c9592e0d3fb82c20a03228 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_01_1120_vm_device_add_alias_column.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia96c5ad7bfd49ac470c9592e0d3fb82c20a03228 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Validate shareable disk version
by mlipchuk＠redhat.com 28 May '12

28 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate shareable disk version ...................................................................... core: Validate shareable disk version Changing the validation of shareable disk to check the prior returnValue indication also. Also change the validation version method to get the storage pool version as a parameter when validating if version supported, Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ie491f5000f1fdcb2ded820c81dee34e6b191ad62 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 4 files changed, 16 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie491f5000f1fdcb2ded820c81dee34e6b191ad62 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0