June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fixing unit test
by yzaslavs＠redhat.com 20 Jun '12

20 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing unit test ...................................................................... core: Fixing unit test The following patch will fix mistakenly broken unit test Change-Id: I034fd60378d11b869619de5de6fe2bb16d558752 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 2 files changed, 14 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I034fd60378d11b869619de5de6fe2bb16d558752 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Console popup dialog fixes
by gchaplik＠redhat.com 20 Jun '12

20 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Console popup dialog fixes ...................................................................... userportal: Console popup dialog fixes Previously, the ConsolePopup was implemented independently of the standard popup architecture, because the popup did not have a model class. This caused several problems, such as the enter/escape binding, title of the popup and most recently after the console popup has been closed, no other popups could be opened. This patch solved this by refactoring the console popup to fit into the standard popup architecture with it's own model (UserPortalConsolePopupModel) and commands for save and close. This patch also includes the adding the method beforeCommandExecuted to AbstractModelBoundPopupPresenterWidget which is executed before every command on that popup is executed. Change-Id: I7b5a91a67c703bee7536b3ac5158e1eb35275ebf Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalConsolePopupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/UserPortalBasicListProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java 12 files changed, 184 insertions(+), 116 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b5a91a67c703bee7536b3ac5158e1eb35275ebf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Extended view/Basic view visibility fixes
by gchaplik＠redhat.com 20 Jun '12

20 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Extended view/Basic view visibility fixes ...................................................................... userportal: Extended view/Basic view visibility fixes There where two problems with determining, if the Extended view should be shown or not: 1: The Everyone has a QuotaConsumer role which enabled everyone to see the Extended view. Fixed by ignoring the Everyone QuotaConsumer when deciding if show or not show the extended view 2: After logout/login as user with different role, the visibility of the header buttons (Basic, Extended) was not updated. Fixed by moving the code which refreshes this from HeaderPresenterWidget.onBind to HeaderPresenterWidget.onReset because the HeaderPresenterWidget is a singleton. This patch also contains the creating of the enum named ApplicationGuids which contains some well known values from ad_groups and roles tables and also the refactoring of places which used this values directly to use them from the enum. Change-Id: I16ec262e7e5b46ccfdba28d091726d8368cae054 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/auth/ApplicationGuids.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaPermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/HeaderPresenterWidget.java 10 files changed, 77 insertions(+), 43 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ec262e7e5b46ccfdba28d091726d8368cae054 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Exception when no items in basic view
by gchaplik＠redhat.com 20 Jun '12

20 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Exception when no items in basic view ...................................................................... userportal: Exception when no items in basic view If there are no VMs or Pools, the UP's basic view throws an exception during the load. It is because the MainTabBasicListPresenterWidget.selectDefault expects, that at least one VM or Pool is visible for the user. Solved by avoiding this expectation. Change-Id: I31b5acd4402aed775d57f4e6ba3ccb5914a93c75 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListPresenterWidget.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31b5acd4402aed775d57f4e6ba3ccb5914a93c75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: change default gateway title
by gchaplik＠redhat.com 20 Jun '12

20 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: change default gateway title ...................................................................... webadmin: change default gateway title In edit management network form- from host->interface-> edit management network or from setup networks there two colons after Default Gateway title Change-Id: I15702959760c69b62c65ba4137c5e9d7c0fa51c3 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15702959760c69b62c65ba4137c5e9d7c0fa51c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup VdsSelector
by lhornyak＠redhat.com 20 Jun '12

20 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: cleanup VdsSelector ...................................................................... core: cleanup VdsSelector - java.util FQN replaced with imports - ArrayList replaced with List where applicable - does no longer use the ctr to init privateRunVdssList, gets an instance by initializer - setRunVdssList was never called, removed privateRunVdssList can be final Change-Id: I14f1c39dc85117266b75f09bf44fa063469c38d2 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 2 files changed, 11 insertions(+), 14 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14f1c39dc85117266b75f09bf44fa063469c38d2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: changed maven version and group to static values
by ydary＠redhat.com 20 Jun '12

20 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed maven version and group to static values ...................................................................... packaging: changed maven version and group to static values This is because it is not standard to use expressions and maven displays warnings due to this. Change-Id: I2e77cefbf4d0080b76cfdc6baa91f4cdd87f0bbe Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/pom.xml M data-warehouse/history_etl/etl_sources/historyETLProcedure/pom.xml M data-warehouse/history_etl/etl_sources/packaging/pom.xml M data-warehouse/history_etl/etl_sources/pom.xml M data-warehouse/history_etl/etl_sources/talendRoutines/pom.xml M data-warehouse/history_etl/pom.xml M data-warehouse/pom.xml M pom.xml 8 files changed, 23 insertions(+), 27 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e77cefbf4d0080b76cfdc6baa91f4cdd87f0bbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing the use of deprecated RefObject class.
by lhornyak＠redhat.com 20 Jun '12

20 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Removing the use of deprecated RefObject class. ...................................................................... engine: Removing the use of deprecated RefObject class. This is the first patch in the series. Change-Id: Ia9458cbe834b5778eed656ac2107bc342246b002 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/IConfigUtilsInterface.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ConfigUtilsBase.java 2 files changed, 0 insertions(+), 96 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9458cbe834b5778eed656ac2107bc342246b002 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: we are able to add a disk during create snapshot (#833...
by mkublin＠redhat.com 20 Jun '12

20 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: we are able to add a disk during create snapshot (#833787) ...................................................................... core: we are able to add a disk during create snapshot (#833787) https://bugzilla.redhat.com/833787 Adding missing check for vm during snapshot at add disk and attach disk operation Change-Id: Ifffbdc4b20e4a5cdfbff1cb7c8a0a8dcb9a79c6a Signed-off-by: MIchael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifffbdc4b20e4a5cdfbff1cb7c8a0a8dcb9a79c6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Deprecate StringHelper
by rgolan＠redhat.com 20 Jun '12

20 Jun '12

Roy Golan has submitted this change and it was merged. Change subject: core: Deprecate StringHelper ...................................................................... core: Deprecate StringHelper The usage of StringHelper methods is discurage since its not optimal (uses StringBuffer insead of Builder) and has already a proven, widely used twin made by apache, org.apache.commons.lang.StringUtils Change-Id: Ibe8512c55ad0a7f1a9622533625db5d75c5f982b Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe8512c55ad0a7f1a9622533625db5d75c5f982b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0