June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Fix Rest-Easy ambiguity for Roles
by oliel＠redhat.com 18 Jun '12

18 Jun '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Fix Rest-Easy ambiguity for Roles ...................................................................... restapi: Fix Rest-Easy ambiguity for Roles Change-Id: I13fd34cd013a22cd9c163be4709fc53817117ed5 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java D backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedRoleResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/AssignedRolesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/RoleResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/RolesResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/UpdatableRoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRoleResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRolesResource.java 9 files changed, 40 insertions(+), 28 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13fd34cd013a22cd9c163be4709fc53817117ed5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-dwh[master]: etl: fixed regression in spec file
by ydary＠redhat.com 18 Jun '12

18 Jun '12

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed regression in spec file ...................................................................... etl: fixed regression in spec file Change-Id: I1f4726b67aa6f15ce131722ac133fe7aac986e83 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f4726b67aa6f15ce131722ac133fe7aac986e83 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change SetupNetworks diff recognition
by mkolesni＠redhat.com 18 Jun '12

18 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Change SetupNetworks diff recognition ...................................................................... engine: Change SetupNetworks diff recognition SetupNetworks would recognize that NIC definitions changed by comparing the new NIC from parameters, to the old NIC from the DB. If the NIC is different then the network/bond is a candidate to be sent to the Host as changed. This approach is problematic if a parameter that is not being sent to the Host is changed, and in turn causes a "false positive" recognition. Changed the difference recognition to take into account only parameters that are later on passed to the host: Network name, Boot protocol, Specific parameters for Static: IP, Gateway, Netmask. The bond recognition was changed to take into account only when the bond itself had been modified (either added or changed). This will allow changing networks & bonds individually, without needing to change the underlying devices if they didn't change. Change-Id: I1908508aee8b1e1dac8e69b86f6cee5380664be6 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 2 files changed, 178 insertions(+), 14 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1908508aee8b1e1dac8e69b86f6cee5380664be6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Extract createNetwork for tests
by mkolesni＠redhat.com 18 Jun '12

18 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Extract createNetwork for tests ...................................................................... engine: Extract createNetwork for tests Extracted this method to make tests easier to read and manage. Also reordered the tests that involved network to be easier to read. Change-Id: I6462238c34f7476730d0f3fb87d0ae1bbfe00d9a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 1 file changed, 39 insertions(+), 26 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6462238c34f7476730d0f3fb87d0ae1bbfe00d9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hot plug nic
by derez＠redhat.com 18 Jun '12

18 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: hot plug nic ...................................................................... webadmin: hot plug nic no bz - Enable new in Vm-.Interface subtab when vm is up - In the new form- if the dc if 3.0 or beneath version the activate checkbox should be always checked (and disabled). Change-Id: I0a71feea6f0f5eec14d9477f9201ea1d8f5d82e6 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Verified Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a71feea6f0f5eec14d9477f9201ea1d8f5d82e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Allow DialogTab to disable its content
by vszocs＠redhat.com 18 Jun '12

18 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Allow DialogTab to disable its content ...................................................................... webadmin: Allow DialogTab to disable its content In popup DialogTab allow disabling all the widgets within it. Change-Id: Iba73e9592ecbde33102f807dffaeaa44d3d9a746 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba73e9592ecbde33102f807dffaeaa44d3d9a746 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Can not run VM that was created...(#827883)
by emesika＠redhat.com 18 Jun '12

18 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Can not run VM that was created...(#827883) ...................................................................... core: Can not run VM that was created...(#827883) https://bugzilla.redhat.com/827883 This occurs when importing a VM/Template when it already exists (Import more than once) In this case the collections in VmBase that stores the managed and un-managed devices should be updated with a new Id (combination of a new Guid for the device Id and the new generated entity id as the VM id) Change-Id: Ice34c79e6e1fc9ea08d26887c72b53455a55d1a4 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 4 files changed, 44 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice34c79e6e1fc9ea08d26887c72b53455a55d1a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup branding leftovers
by emesika＠redhat.com 18 Jun '12

18 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Cleanup branding leftovers ...................................................................... core: Cleanup branding leftovers Use oVirt where branding is required. Change-Id: Id8d38fa2577ec544b45d7c0f015d31c595b44c58 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/conf/ca/installCA.sh M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java M ear/pom.xml 5 files changed, 9 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8d38fa2577ec544b45d7c0f015d31c595b44c58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove temporary files used during database creation
by emesika＠redhat.com 18 Jun '12

18 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Remove temporary files used during database creation ...................................................................... core: Remove temporary files used during database creation The temporary files used by the execute_command function are not removed. Change-Id: Iaf29f082623d8fc8bf76eb1cefa77ecc2d5b0845 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf29f082623d8fc8bf76eb1cefa77ecc2d5b0845 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Don't use the setCharacterEncoding method
by vszocs＠redhat.com 18 Jun '12

18 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Don't use the setCharacterEncoding method ...................................................................... webadmin: Don't use the setCharacterEncoding method This is not really important, just a little anoyance that keeps eclipse complaining. Change-Id: I6da34ba800b59355d970c938aef1f4e455ab1b08 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6da34ba800b59355d970c938aef1f4e455ab1b08 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0