June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Invalid Thread in engine.log (#828783)
by mkublin＠redhat.com 10 Jun '12

10 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Invalid Thread in engine.log (#828783) ...................................................................... core: Invalid Thread in engine.log (#828783) https://bugzilla.redhat.com/828783 The following bug was caused because of changing a thread name, because of a thread is returned back to pool a changed name will be used again and again, which is missleading. The best solution is a log message Change-Id: Iee87a7aa9c2f09b2d0f78be2b2d33320769c4b94 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee87a7aa9c2f09b2d0f78be2b2d33320769c4b94 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: disable DirectLUN Disk for non supported DCs
by derez＠redhat.com 10 Jun '12

10 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disable DirectLUN Disk for non supported DCs ...................................................................... webadmin: disable DirectLUN Disk for non supported DCs Add Disk dialog - disable DirectLUN Disk creation for non supported DC compatibility versions. Change-Id: I874d8ec49251e68ab6d04a738c60cf733141895e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 9 files changed, 74 insertions(+), 16 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I874d8ec49251e68ab6d04a738c60cf733141895e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add test for SetupNetworksVDSCommandTest
by mkolesni＠redhat.com 10 Jun '12

10 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add test for SetupNetworksVDSCommandTest ...................................................................... core: Add test for SetupNetworksVDSCommandTest Added test for bonds passed to VDSM. VdsBrokerCommand needed to be refactored for this. Change-Id: Ia4943ca39ca679b74147187f002c6a5b3ab97019 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 2 files changed, 132 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4943ca39ca679b74147187f002c6a5b3ab97019 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: quota - infinite hourglass
by gchaplik＠redhat.com 09 Jun '12

09 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: quota - infinite hourglass ...................................................................... webadmin: quota - infinite hourglass incase there is no SD/Cluster in DC, the hourglass spins forever Change-Id: I57ff9829a339d96f8d7e8624287dd2d8490cfcef Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57ff9829a339d96f8d7e8624287dd2d8490cfcef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix quota tests
by gchaplik＠redhat.com 09 Jun '12

09 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix quota tests ...................................................................... core: fix quota tests Change-Id: I1c85235e223c1424e741fec70d8fd48712d61972 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QuotaHelperTest.java 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c85235e223c1424e741fec70d8fd48712d61972 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: oVirt Modes - hiding PM, SPM in host
by gchaplik＠redhat.com 08 Jun '12

08 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: oVirt Modes - hiding PM, SPM in host ...................................................................... webadmin: oVirt Modes - hiding PM, SPM in host Power Management confirmation when adding a host through cluster hide me is removed in Gluster Only. SPM,VM colums in the Host table is hidden in Gluster Only. Messages for volume actions are modified. Change-Id: Ia38b24e85c01bff57da0c7edfe7931a981c448b6 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 3 files changed, 52 insertions(+), 44 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia38b24e85c01bff57da0c7edfe7931a981c448b6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: add disk dialog modifications
by derez＠redhat.com 07 Jun '12

07 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: add disk dialog modifications ...................................................................... webadmin,userportal: add disk dialog modifications * Added ID column to 'attachable' disks table * Hide DirectLUN creation panel in the user portal Change-Id: Icfaf1985182516adbcab8e436be6636d4ed2b3e1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java 5 files changed, 67 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfaf1985182516adbcab8e436be6636d4ed2b3e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: using RunMultipleAction when adding disk
by derez＠redhat.com 07 Jun '12

07 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: using RunMultipleAction when adding disk ...................................................................... webadmin: using RunMultipleAction when adding disk Using RunMultipleAction instead of RunAction when adding a new disk, so each add action would start on a different thread. Change-Id: I1b9b6b6be04e81ae3d5a4b93dfa6adff06bcba87 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 2 files changed, 23 insertions(+), 44 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b9b6b6be04e81ae3d5a4b93dfa6adff06bcba87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Grayed-Out LUNs Support
by derez＠redhat.com 07 Jun '12

07 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Grayed-Out LUNs Support ...................................................................... webadmin: Grayed-Out LUNs Support Adding the needed modifications for supporting Grayed-Out/Disabled LUNs (LUNS that are not applicable for adding into storage domains): * Storage domain dialog: ** LUN devices that include partitions - should be grayed-out. ** LUN devices that are a part of a VG - should be grayed-out. ** LUN devices that already exists in the system - should be grayed-out. * Add DirectLUN dialog: ** LUN devices that include partitions - a warning should be displayed. ** LUN devices that are a part of a VG - a warning should be displayed. ** LUN devices that already exists in the system - should be grayed-out. Change-Id: I59539aa6b5f0b12a5ac88cf6ea6509133b85ee92 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/LunTextColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LunModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 14 files changed, 236 insertions(+), 23 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59539aa6b5f0b12a5ac88cf6ea6509133b85ee92 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Grayed-Out LUNs Support
by derez＠redhat.com 07 Jun '12

07 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: restapi: Grayed-Out LUNs Support ...................................................................... restapi: Grayed-Out LUNs Support Adding the needed modifications for supporting Grayed-Out (disabled) LUNs: * Added 'partitioned' flag and 'volume_group_id' to LogicalUnit type. ** 'partitioned' flag - indicating whether the LUN device contains partitions - cannot be added to a storage domain. ** 'volume_group_id' - indicating whether the LUN device is a part of a VG - cannot be added to a storage domain. ** 'storage_domain_id' - indicating whether the LUN device is already a part of a storage domain - cannot be added to another storage domain. * Modified 'StorageLogicalUnitMapper' accordingly. * The new representation is needed when getting host's storage sub-collection (a list of LUN devices). Change-Id: I9accec6b37180e2da77c752875e8e181c0cd3601 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java 3 files changed, 23 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9accec6b37180e2da77c752875e8e181c0cd3601 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0