June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Permissions views filter objects based on User Roles o...
by asaf＠redhat.com 26 Jun '12

26 Jun '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: Permissions views filter objects based on User Roles only. (#783087) ...................................................................... core: Permissions views filter objects based on User Roles only. (#783087) https://bugzilla.redhat.com/783087 Invoking queries in user level only works now with User Roles (no admin role) attached to them. This condition is also relevant when assigning roles to other entities in the hierarchy. Change-Id: I7bc504dbbebbf202e456669686cb905b2b7a9a3b Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 35 insertions(+), 35 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bc504dbbebbf202e456669686cb905b2b7a9a3b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: ESC key doesn't close configure and about dialogs ...
by asaf＠redhat.com 26 Jun '12

26 Jun '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: ESC key doesn't close configure and about dialogs (#834424) ...................................................................... webadmin: ESC key doesn't close configure and about dialogs (#834424) https://bugzilla.redhat.com/834424 ESC key doesn't close configure and about dialogs Change-Id: If8bb07adf59effd14ed2cec3b3b2831ed4e245de Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/configure/ConfigurePopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.java 4 files changed, 46 insertions(+), 6 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8bb07adf59effd14ed2cec3b3b2831ed4e245de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: add change custom properties to configure dialog
by ofrenkel＠redhat.com 26 Jun '12

26 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: webadmin: add change custom properties to configure dialog ...................................................................... webadmin: add change custom properties to configure dialog added new ActionGroup CHANGE_VM_CUSTOM_PROPERTIES to the configure dialog in the web admin Change-Id: I983e97b93388a310470fd4a05e7128c8ebc0b05f Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 12 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I983e97b93388a310470fd4a05e7128c8ebc0b05f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix double check in updateVmCommand
by ofrenkel＠redhat.com 26 Jun '12

26 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix double check in updateVmCommand ...................................................................... core: fix double check in updateVmCommand this fix was missed in previous updateVmCommand refactor. a case of "if (a || a)" Change-Id: Ifffaea3c6f5220dedb403bf2aa24a4133202379a Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifffaea3c6f5220dedb403bf2aa24a4133202379a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-setup - Don't use httpd proxy when ipa ins...
by oschreib＠redhat.com 26 Jun '12

26 Jun '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-setup - Don't use httpd proxy when ipa installed ...................................................................... packaging: engine-setup - Don't use httpd proxy when ipa installed IPA assumes he owns httpd (same as we are). This behaviour casues multiple conflicts when ovirt-engine tries to use httpd proxy, so in order to solve this conflict, we disable the proxy support when ipa is installed. Change-Id: I0fb1f9cd7ad298fd785383f7ba4e447b4296d230 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 5 files changed, 72 insertions(+), 31 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fb1f9cd7ad298fd785383f7ba4e447b4296d230 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: filter-out already attached disks (#833076)
by gchaplik＠redhat.com 26 Jun '12

26 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: filter-out already attached disks (#833076) ...................................................................... engine: filter-out already attached disks (#833076) https://bugzilla.redhat.com/833076 currently, when attaching disk the gui also shows the already attached disks. to solve that I've added a new parameter to the SP, vm guid, that filter out all the disks that are already attached to the vm. in case the new parameter is null, the same flow is kept (get all shared disks in DC). Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: Ifa416fd6cd8e171295458b79322bb654636413f8 --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAttachableDisks.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 10 files changed, 70 insertions(+), 37 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa416fd6cd8e171295458b79322bb654636413f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: wipe after delete is not applicable for DirectLUN
by derez＠redhat.com 25 Jun '12

25 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: wipe after delete is not applicable for DirectLUN ...................................................................... webadmin: wipe after delete is not applicable for DirectLUN https://bugzilla.redhat.com/833842 Hide 'wipe after delete' checkbox for DirectLUN disks. Change-Id: Ibd8d6a4368793f84ed866e4e31f13641eb26f6e6 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd8d6a4368793f84ed866e4e31f13641eb26f6e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: block snapshot creation for Direct LUN
by derez＠redhat.com 25 Jun '12

25 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: block snapshot creation for Direct LUN ...................................................................... webadmin: block snapshot creation for Direct LUN https://bugzilla.redhat.com/834844 Snapshot creation should be blocked when no Virtual Disks is attached to the VM (i.e. only DirectLUN disks are attached). Change-Id: I06b9085a08862ad3e68483c89be3d61771c562db Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 13 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06b9085a08862ad3e68483c89be3d61771c562db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix getFriendlyVersion
by yzaslavs＠redhat.com 25 Jun '12

25 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Fix getFriendlyVersion ...................................................................... webadmin: Fix getFriendlyVersion getFriendlyVersion should return 3.1 for vdsm version 4.10. Most of the usages of getFriendlyVersion compare the result with the minimum compatibility version (check that it is equal or greater than the mimimum compatbility version for a feature) Prior to this patch, 4.10 would have resulted as version 4.10 so the comparsion would have returned a value greater than 0, now the Version returned from getFriendlyVersion will be 3.1 (as for 4.9 it returned 3.0). So the comparsion would also return a value greater than 0 (So no regression here). The only change is that at UI for host you will see vdsm version 3.1.x.y instead of 4.10.x.y This is an interim patch until we start working with RpmVersion and then we should revisit this. Change-Id: I88e55c73d4b7747d8af8dcda5e112694aeea3030 Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Extensions.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e55c73d4b7747d8af8dcda5e112694aeea3030 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: block vm migration if cpu pinning enabled
by dfediuck＠redhat.com 25 Jun '12

25 Jun '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: block vm migration if cpu pinning enabled ...................................................................... core: block vm migration if cpu pinning enabled Blocks VM migration of cpu pinning is enabled. Change-Id: I38e7585d96ff0c5d5ea29222495b8d987f6aeb7b Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 42 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38e7585d96ff0c5d5ea29222495b8d987f6aeb7b Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0