June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Visual fix of Posix FS storage dialog
by ecohen＠redhat.com 03 Jun '12

03 Jun '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Visual fix of Posix FS storage dialog ...................................................................... webadmin: Visual fix of Posix FS storage dialog - Label font - Text box width Change-Id: Ieae1a56d3fe96e7cf660c23c6ef7d55adf103423 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieae1a56d3fe96e7cf660c23c6ef7d55adf103423 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Fixing NPE at ImagesHandle.setDiskAlias
by mkublin＠redhat.com 03 Jun '12

03 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing NPE at ImagesHandle.setDiskAlias ...................................................................... core : Fixing NPE at ImagesHandle.setDiskAlias The following patch will fix a NPE at ImagesHandle.setDiskAlias, for case when vm was passed null, it obvious that we also should passe a default value for disk count Change-Id: I42467e39a5f5c97036db533d6acdb7b97d37158d Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42467e39a5f5c97036db533d6acdb7b97d37158d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DirectLUNDiskEnabled configuration value
by derez＠redhat.com 03 Jun '12

03 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: core: DirectLUNDiskEnabled configuration value ...................................................................... core: DirectLUNDiskEnabled configuration value Added 'DirectLUNDiskEnabled' configuration value to 'config.sql' (currently supported only for 3.1). Change-Id: I97de8425b8b99f2f9f766e9e354a1f5cf3729426 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97de8425b8b99f2f9f766e9e354a1f5cf3729426 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: fix error handling regression
by mpastern＠redhat.com 03 Jun '12

03 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: fix error handling regression ...................................................................... sdk: fix error handling regression when response.read() called - it removes body from server response, so later when RequestError raised it no longer have view on actual error cause. Change-Id: I6d6122a870b00ca1b6078e950641c4747b6951d5 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/proxy.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d6122a870b00ca1b6078e950641c4747b6951d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: changing jboss-as to jbossas in service restart in utl...
by oourfali＠redhat.com 03 Jun '12

03 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: changing jboss-as to jbossas in service restart in utlities ...................................................................... core: changing jboss-as to jbossas in service restart in utlities In the new jboss version, the service is called jbossas instead of jboss-as. Changed the documentation in the utilities accordingly. Change-Id: I8a50e5de2c46743d9416c4fe51d2f73159111277 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java M backend/manager/tools/engine-config/src/main/resources/engine-config 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/5001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a50e5de2c46743d9416c4fe51d2f73159111277 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Advanced NFS options
by ecohen＠redhat.com 03 Jun '12

03 Jun '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Advanced NFS options ...................................................................... webadmin: Advanced NFS options New options in NfsStorageView: * NFS Version * Retransmissions * Timeout * Mount Options Change-Id: Ieb211c07dcb8183f73317d3223e2e425b0af37bf Signed-off-by: Alexey Chub <achub(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBoxOnlyEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Convertible.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml 8 files changed, 448 insertions(+), 82 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb211c07dcb8183f73317d3223e2e425b0af37bf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-upgrade - Don't list duplicate packages
by oschreib＠redhat.com 03 Jun '12

03 Jun '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-upgrade - Don't list duplicate packages ...................................................................... packaging: engine-upgrade - Don't list duplicate packages The updateAvailable method used to list all available packages instead of just updates, which might have caused duplicate entries in the candidates-for-update list. Change-Id: I4af8abb6337d269f707559c8139ee62b9af1f1cb Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4af8abb6337d269f707559c8139ee62b9af1f1cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Rephrase message when default quota removed(#818501)
by mlipchuk＠redhat.com 03 Jun '12

03 Jun '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Rephrase message when default quota removed(#818501) ...................................................................... core:Rephrase message when default quota removed(#818501) https://bugzilla.redhat.com/818501 1. Change the message to be more understandable when removing a default quota while the Data Center is at quota disabled mode. 2. Add a test for removeQuotaCommand. Change-Id: Ic45391eb6d36b27fe14d407f2e5f5a5a9ef33666 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 202 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic45391eb6d36b27fe14d407f2e5f5a5a9ef33666 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add latency fields to disk image (#804995)
by mlipchuk＠redhat.com 03 Jun '12

03 Jun '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add latency fields to disk image (#804995) ...................................................................... core: Add latency fields to disk image (#804995) https://bugzilla.redhat.com/804995 Expose latency fields from disk image for rest purpose. Change-Id: I32ea8b7ab04004bc0e8aa3d1b3e31253e0a61b77 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java 3 files changed, 81 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32ea8b7ab04004bc0e8aa3d1b3e31253e0a61b77 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix broken test caused by cpu pinning
by oliel＠redhat.com 03 Jun '12

03 Jun '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: fix broken test caused by cpu pinning ...................................................................... restapi: fix broken test caused by cpu pinning Change-Id: Ief26fda25bec644899d5436ac27575612708ee02 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief26fda25bec644899d5436ac27575612708ee02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0