July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: Enable context-sensitive help in dialogs
by ecohen＠redhat.com 24 Jul '12

24 Jul '12

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Enable context-sensitive help in dialogs ...................................................................... userportal: Enable context-sensitive help in dialogs This patch enables context-sensitive help feature for UserPortal dialogs. UserPortalConfigurator will fetch "UserPortalDocumentationPath.csv" file from following location: http(s)://<host>:<port>/<DocsURL>/<locale>/UserPortalDocumentationPath.csv This is similar to WebAdmin's "DocumentationPath.csv" file location, but with different file name for UserPortal. After receiving CSV file content, UserPortalConfigurator.eventRaised() method method will call DocumentationPathTranslator.init() to initialize modelHashName -> contextSensitiveHelp mappings. When the CSV file cannot be retrieved, application will simply hide the context-sensitive help button within the given dialog. See AbstractModelBoundPopupPresenterWidget.updateHashName() method for details on logic that updates help button availability. This patch also adds "HTTP response OK" check in Configurator.fetchFile() method. Change-Id: I8c84a6fb4875049669b18753f9246cfe3aaefd8d Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 3 files changed, 36 insertions(+), 32 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c84a6fb4875049669b18753f9246cfe3aaefd8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: UNKNOWN types in CustomFieldSerializer
by derez＠redhat.com 24 Jul '12

24 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: UNKNOWN types in CustomFieldSerializer ...................................................................... webadmin: UNKNOWN types in CustomFieldSerializer VdcQueryReturnValue_CustomFieldSerializer, deserialize and serialize for "UNKNOWN" types. Change-Id: I2b7286ef06040b106e78d3a5b25904a20eeffe5e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b7286ef06040b106e78d3a5b25904a20eeffe5e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: grid selected item isn't refreshing (#840753)
by gchaplik＠redhat.com 24 Jul '12

24 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: grid selected item isn't refreshing (#840753) ...................................................................... userportal: grid selected item isn't refreshing (#840753) https://bugzilla.redhat.com/840753 updating the selected item manually in every refresh Change-Id: I9f59263d0592f632c3d3599a3e1e882e24e7acf7 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f59263d0592f632c3d3599a3e1e882e24e7acf7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: custom properies (#840753)
by gchaplik＠redhat.com 24 Jul '12

24 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: custom properies (#840753) ...................................................................... userportal: custom properies (#840753) https://bugzilla.redhat.com/840753 the custom propeties is not saved on edit and creation of a vm Change-Id: I30f578d08c7239e5df2f602130b295aaea4714a6 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30f578d08c7239e5df2f602130b295aaea4714a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix iso domain creation during setup
by oschreib＠redhat.com 24 Jul '12

24 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: core: Fix iso domain creation during setup ...................................................................... core: Fix iso domain creation during setup When setup configures iso domain it calls inst_add_iso_storage_domain db function. This function interface was changed in 26d1b788a8ced3cfa098bbeda989aa77fcaa0163, and this commit adds the missing parameter. Change-Id: I3a6e28bbf9745b63686c0593ff033afdc1646eaa Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M backend/manager/dbscripts/inst_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a6e28bbf9745b63686c0593ff033afdc1646eaa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: call vm down event on host reboot
by ofrenkel＠redhat.com 24 Jul '12

24 Jul '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: call vm down event on host reboot ...................................................................... core: call vm down event on host reboot when host is fenced, the vm down event (VmPoolHandler.ProcessVmPoolOnStopVm) is not called, causing stateless vms and pool vms not to have the treatment it should have when getting to down. (restoring snapshot, and for pool resetting the user) Change-Id: I5af6759c594b497ed476b366e6a0c0b4646a5732 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 3 files changed, 13 insertions(+), 11 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5af6759c594b497ed476b366e6a0c0b4646a5732 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: MonitoringStrategyFactoryTest: Partial UnPowerMock
by yzaslavs＠redhat.com 24 Jul '12

24 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: MonitoringStrategyFactoryTest: Partial UnPowerMock ...................................................................... core: MonitoringStrategyFactoryTest: Partial UnPowerMock Removed unnecessary PowerMocking of VdsGroupDAO from MonitoringStrategyFactoryTest. Change-Id: I7ca85ea490bfd99eaecae0cedf78ed59ce1a45cf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/MonitoringStrategyFactoryTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ca85ea490bfd99eaecae0cedf78ed59ce1a45cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VdsManagerTest: Partial UnPowerMock
by yzaslavs＠redhat.com 24 Jul '12

24 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: VdsManagerTest: Partial UnPowerMock ...................................................................... core: VdsManagerTest: Partial UnPowerMock Stopped unnecessary PowerMocking of VdsDAOGroup in VdsManagerTest. Change-Id: Ief096c434311a5ce539ac490c8f2e5dde4676d4e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsManagerTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief096c434311a5ce539ac490c8f2e5dde4676d4e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VdsBrokerObjectBuilderTest: static helpers
by yzaslavs＠redhat.com 24 Jul '12

24 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: VdsBrokerObjectBuilderTest: static helpers ...................................................................... core: VdsBrokerObjectBuilderTest: static helpers Made private helper methods static where possible for improved performance. Change-Id: I2e253e237d149651b4d92fcb578bc69e911a017f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e253e237d149651b4d92fcb578bc69e911a017f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VdsBrokerObjectBuilderTest: Partial UnPowerMock
by yzaslavs＠redhat.com 24 Jul '12

24 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: VdsBrokerObjectBuilderTest: Partial UnPowerMock ...................................................................... core: VdsBrokerObjectBuilderTest: Partial UnPowerMock Stopped PowerMocking VdsBrokerObjectBuilder in VdsBrokerObjectBuilderTest, and opted for regular Mockito mocking where possible. This solution is incomplete, but is a step in the right direction of completely removing PowerMock from the project. Change-Id: I41efb2210a646d4fe829fe75e0864d07890734bc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41efb2210a646d4fe829fe75e0864d07890734bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0