July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Added sorting to disk list when attaching to a VM ...
by tnisan＠redhat.com 02 Jul '12

02 Jul '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added sorting to disk list when attaching to a VM (#834346) ...................................................................... webadmin: Added sorting to disk list when attaching to a VM (#834346) https://bugzilla.redhat.com/834346 When attaching a disk to an existing VM, the list of external disk was not sorted, added sorting by disk alias Change-Id: I98264686232a9da645155899ba1005344691679f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98264686232a9da645155899ba1005344691679f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Move application name const to correct location
by oschreib＠redhat.com 02 Jul '12

02 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Move application name const to correct location ...................................................................... packaging: Move application name const to correct location * Moved MY_NAME constant to basedefs.py * Renamed MY_NAME to APP_NAME * Changed usage of MY_NAME in output_messages to basedefs.APP_NAME Change-Id: I1113ad02b989aa559fe526d1ed94e511278fe724 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/output_messages.py 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1113ad02b989aa559fe526d1ed94e511278fe724 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: List Data Centers according to user permissions
by asaf＠redhat.com 02 Jul '12

02 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: restapi: List Data Centers according to user permissions ...................................................................... restapi: List Data Centers according to user permissions List Data Centers according to the standard user permissions. Change-Id: I801f1bf3dc2c23429cd10d5630b40bec5c02fddd Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCentersResource.java 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I801f1bf3dc2c23429cd10d5630b40bec5c02fddd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Remove spring framework
by oourfali＠redhat.com 02 Jul '12

02 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Remove spring framework ...................................................................... restapi: Remove spring framework Remove the dependency on the spring framework. Change-Id: I3f27d340261e4b5c4b6b7f27a98c3d13c38569f0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml D backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/applicationContext.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml M deployment/modules/com/sun/xml/bind/main/module.xml A deployment/modules/org/apache/james/mime4j/main/module.xml A deployment/modules/org/codehaus/jettison/main/module.xml A deployment/modules/org/yaml/snakeyaml/main/module.xml M ear/pom.xml M packaging/fedora/engine-service.xml M packaging/fedora/spec/ovirt-engine.spec.in 16 files changed, 326 insertions(+), 294 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f27d340261e4b5c4b6b7f27a98c3d13c38569f0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Update to Spring 3
by oourfali＠redhat.com 02 Jul '12

02 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Update to Spring 3 ...................................................................... core: Update to Spring 3 These are the changes required to update the Spring version to 3.1.1.RELEASE and the RESTEasy version to 2.3.2.Final. Change-Id: Ia2537332a0e2f46bf608fb2e13e6d08c5d7910a9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/CustomizedContextLoader.java M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/applicationContext.xml M backend/manager/modules/utils/pom.xml M ear/pom.xml M pom.xml 9 files changed, 63 insertions(+), 22 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2537332a0e2f46bf608fb2e13e6d08c5d7910a9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: fix LoginValidatorTest
by asaf＠redhat.com 02 Jul '12

02 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: rest: fix LoginValidatorTest ...................................................................... rest: fix LoginValidatorTest Previous patch changed the command called in the login validator. Need to change the expectations accordingly. Change-Id: Ief2a5423fda1f662347b15a3b2faab862d1a4da2 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief2a5423fda1f662347b15a3b2faab862d1a4da2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: calling GetLunsByVgId query by Host ID
by derez＠redhat.com 02 Jul '12

02 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: calling GetLunsByVgId query by Host ID ...................................................................... webadmin: calling GetLunsByVgId query by Host ID Edit Block Storage dialog: * Fetching LUNs stored in DB using 'GetLunsByVgId'. * Passing host's ID in query's parameters for calling GetDeviceList: (needed for updating path count for each LUN). Change-Id: I03a48d064689d577962614b4efd066e93aaf2cf5 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 25 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03a48d064689d577962614b4efd066e93aaf2cf5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: Allow user level login (#816240)
by oourfali＠redhat.com 02 Jul '12

02 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: rest: Allow user level login (#816240) ...................................................................... rest: Allow user level login (#816240) https://bugzilla.redhat.com/816240 - Support for user level login by supporting user login in Backend Login method. - Login validation is based on LoginUser action now. - Eliminated the object level cache for the 'filtered' property as Spring caches the beans which causes the same resource instances to be used across HTTP requests. Change-Id: Ica8e21d3030f9281200c21902c254cce3afea6c3 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java 3 files changed, 7 insertions(+), 11 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica8e21d3030f9281200c21902c254cce3afea6c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: GetLunsByVgId - update LUNs path count
by derez＠redhat.com 01 Jul '12

01 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: GetLunsByVgId - update LUNs path count ...................................................................... core: GetLunsByVgId - update LUNs path count GetLunsByVgId query should return a list of LUNs by a VG ID: * The query fetches from DB all LUNs associated with the VG. * In order to update 'PathsDictionary' for each LUN, ** calling 'GetDeviceList' (gets all LUNs available from the specified host) ** LUN's 'PathsDictionary' is initialized by parsing 'pathstatus' ** update LUNs from DB objects Change-Id: I339a09c789cc3a2802f7cdf4111da7db5186f444 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetLunsByVgIdParameters.java 4 files changed, 118 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I339a09c789cc3a2802f7cdf4111da7db5186f444 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix small format error in engine-manage-domains output
by yzaslavs＠redhat.com 01 Jul '12

01 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix small format error in engine-manage-domains output ...................................................................... core: Fix small format error in engine-manage-domains output * Insert space in error message: "Could not query for user ... in domainexample.com" vs. "Could not query for user ... in domain example.com" Change-Id: I66d5e2494c187acfa92af9c8eca004d29628957d Signed-off-by: Matthias Schmitz <matthias(a)sigxcpu.org> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d5e2494c187acfa92af9c8eca004d29628957d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Matthias Schmitz <matthias(a)sigxcpu.org> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0