July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: NPE due to mismatch between command and params (#80589...
by yzaslavs＠redhat.com 01 Jul '12

01 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: NPE due to mismatch between command and params (#805897) ...................................................................... core: NPE due to mismatch between command and params (#805897) https://bugzilla.redhat.com/805897 This occurs as parent command is always set to RunVm when passed to hibernation handling, even in case of sub classes of RunVmCommandBase such as MigrateVmCommand Change-Id: Ia2446c02a95ce35fa739cf6b86a30434632d8775 Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2446c02a95ce35fa739cf6b86a30434632d8775 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing 2 keys at engine-config conf file
by oourfali＠redhat.com 01 Jul '12

01 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fixing 2 keys at engine-config conf file ...................................................................... core: Fixing 2 keys at engine-config conf file 1. MaxDiskSize does not exist in vdc_options 2. JobCleanupRateInMinutes description was improperly set. Change-Id: If35a73fdb637e47c7f475b2f81ea1ad592970ae2 Acked-by: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If35a73fdb637e47c7f475b2f81ea1ad592970ae2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: utilities: adding an error log print in engine-manage-domain...
by oourfali＠redhat.com 01 Jul '12

01 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: utilities: adding an error log print in engine-manage-domains ...................................................................... utilities: adding an error log print in engine-manage-domains This patch adds an error log print in case engine-manage-domains has completed with errors. This error is normally printed to the screen. Here we also print it to the log. Change-Id: I43e089a0851f573c950f58fc8600b4c60f726f5b Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Roy Golan: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43e089a0851f573c950f58fc8600b4c60f726f5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: Engine: Handle missing/invalid mac address on import Vm/Temp...
by shavivi＠redhat.com 01 Jul '12

01 Jul '12

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: Handle missing/invalid mac address on import Vm/Template ...................................................................... Engine: Handle missing/invalid mac address on import Vm/Template On importing VM/Template if the imported entity have NIC with no MAC address we generate one from the pool. If we are getting an invalid MAC address we still import the NIC but we log message to the event log. Change-Id: I09dd86a352ecc17e80dceb8c331ec38f4fa96627 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 55 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09dd86a352ecc17e80dceb8c331ec38f4fa96627 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: UI: Fix NPE when Disk have no storage-domain id
by shavivi＠redhat.com 01 Jul '12

01 Jul '12

Shahar Havivi has submitted this change and it was merged. Change subject: UI: Fix NPE when Disk have no storage-domain id ...................................................................... UI: Fix NPE when Disk have no storage-domain id Change-Id: I6b5fbce50de3e05c9e16576cd0714cd2c4dfa732 Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b5fbce50de3e05c9e16576cd0714cd2c4dfa732 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: Engine: Set correct storage id for snapshots
by shavivi＠redhat.com 01 Jul '12

01 Jul '12

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: Set correct storage id for snapshots ...................................................................... Engine: Set correct storage id for snapshots Snapshots are stored with storage id, but the storage id can be change if the disk-image move to other storage domain. This patch remove the storages id before persisting the snapshot to db and set the correct storages id when reading the snapshot from db. Change-Id: I579838d688e11fbef3beb96ddb876447fe36ab65 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 14 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I579838d688e11fbef3beb96ddb876447fe36ab65 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Fix Index out of bound exception in import VM
by shavivi＠redhat.com 01 Jul '12

01 Jul '12

Shahar Havivi has submitted this change and it was merged. Change subject: Fix Index out of bound exception in import VM ...................................................................... Fix Index out of bound exception in import VM Change-Id: I1b6cf1d1773fd510c599909af509cb60e1f61432 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5805 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b6cf1d1773fd510c599909af509cb60e1f61432 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing Error handling at engine-manage-domains
by oourfali＠redhat.com 01 Jul '12

01 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fixing Error handling at engine-manage-domains ...................................................................... core: Fixing Error handling at engine-manage-domains In case there is an exception during initializion of the InitialDirContext object, currentLdapServer will be null, which will lead to an error of Cannot connect to LDAP URL: null This patch provides better error handling for this case Change-Id: I247b28481fdc037e309f38b0124e0d083e18d06a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 34 insertions(+), 11 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I247b28481fdc037e309f38b0124e0d083e18d06a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Added externalized override tags to VmDiskPopupWid...
by derez＠redhat.com 01 Jul '12

01 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Added externalized override tags to VmDiskPopupWidget ...................................................................... webadmin: Added externalized override tags to VmDiskPopupWidget Change-Id: I1ed0b418389d2c2628fa8edd6c5a3ec8b583a471 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed0b418389d2c2628fa8edd6c5a3ec8b583a471 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disable changing of DC when adding a new external ...
by tnisan＠redhat.com 01 Jul '12

01 Jul '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disable changing of DC when adding a new external disk (#833120) ...................................................................... webadmin: Disable changing of DC when adding a new external disk (#833120) https://bugzilla.redhat.com/833120 Disable changing of the Data Center when adding a new external disk to a VM Change-Id: I7da92ffbfaa265c40b9df1d55bde871d409f32a8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7da92ffbfaa265c40b9df1d55bde871d409f32a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0