August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Improved version support (#760546)
by yzaslavs＠redhat.com 19 Aug '12

19 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improved version support (#760546) ...................................................................... core: Improved version support (#760546) https://bugzilla.redhat.com/760546 The following patch provides the following: a. Elimination of VdsVersion and usage of RpmVersion instead b. Introducing new rpm_version column to vds_dynamic to store VDSM rpm version c. Presentation at UI of Vdsm Version Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e5 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Signed-off-by: Alexey Chub <achub(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1360_add_vdsm_rpm_version_column.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsVersion.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/RpmVersion.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/common/AboutModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/VersionRenderer.java 20 files changed, 169 insertions(+), 262 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: use config value to decide if allow non vmnet [#84...
by alkaplan＠redhat.com 19 Aug '12

19 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: use config value to decide if allow non vmnet [#849408] ...................................................................... webadmin: use config value to decide if allow non vmnet [#849408] https://bugzilla.redhat.com/849408 - Use SupportBridgesReportByVDSM config value to decide if to allow non-vm networks on the cluster/dc. - When enabling/disabling the network dialog (according to the attached clusters), check the SupportBridgesReportByVDSM before enabling the vm network field. Change-Id: Id330b4c55f1ee7642371a94e0b607ae5505afa81 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 5 files changed, 290 insertions(+), 231 deletions(-) Approvals: Alona Kaplan: Verified Livnat Peer: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id330b4c55f1ee7642371a94e0b607ae5505afa81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [SetupNetwork] edit netork dialog- sync network cr...
by alkaplan＠redhat.com 19 Aug '12

19 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetwork] edit netork dialog- sync network cropped (#849409) ...................................................................... webadmin: [SetupNetwork] edit netork dialog- sync network cropped (#849409) https://bugzilla.redhat.com/849409 The are resolutions on which the sync network line in the dialog is cropped. Use "%" instead of "px" in order to avoid resolution/screen size differences. Change-Id: I1787366c91d4fcb9c624465ebc3b7f926fe67bd2 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1787366c91d4fcb9c624465ebc3b7f926fe67bd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: add kitchen as deploy dep.
by mpastern＠redhat.com 19 Aug '12

19 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: add kitchen as deploy dep. ...................................................................... cli: add kitchen as deploy dep. Change-Id: I64159fbb00b530c75a8e26e6c8e902f06a429b6c Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64159fbb00b530c75a8e26e6c8e902f06a429b6c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: add ply as deploy dep.
by mpastern＠redhat.com 19 Aug '12

19 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: add ply as deploy dep. ...................................................................... cli: add ply as deploy dep. Change-Id: Ide48b44a9fb713debec4a539f43a2a27e6e78ee1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide48b44a9fb713debec4a539f43a2a27e6e78ee1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add Disk - hide data-center select-box (#848163)
by derez＠redhat.com 19 Aug '12

19 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Add Disk - hide data-center select-box (#848163) ...................................................................... webadmin: Add Disk - hide data-center select-box (#848163) https://bugzilla.redhat.com/848163 https://bugzilla.redhat.com/843380 Add Disk dialog: * Hide data-center select-box in VM context (removed redundant data-centers fetching logic from VmDiskListModel and VmGuideModel which triggered a wrong event chain). * Filter out non-active data-centers. * When a specific data-center is selected in System tree, filter out the others from the select-box. Change-Id: I18a91a2061aa164b011bd92eab2832887b81dd23 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 8 files changed, 296 insertions(+), 517 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18a91a2061aa164b011bd92eab2832887b81dd23 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disks main-tab and sub-tab redesign (#833101)
by derez＠redhat.com 19 Aug '12

19 Aug '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disks main-tab and sub-tab redesign (#833101) ...................................................................... webadmin: Disks main-tab and sub-tab redesign (#833101) https://bugzilla.redhat.com/833101 Added 'All/Images/DirectLun' radio buttons for toggling between the corresponding views. Affected tabs: * Disks main-tab * VMs -> Disks sub-tab Change-Id: I1e7a24b6ac2a02820b1ebd965d3528df93385efe Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageDomainsCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageDomainsColumn.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewRadioGroup.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/disk_bootable.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/templates.png R frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/vms.png M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModelBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DiskModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskGeneralView.java 26 files changed, 763 insertions(+), 274 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e7a24b6ac2a02820b1ebd965d3528df93385efe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unuse audit log (Related to BZ822051)
by mlipchuk＠redhat.com 19 Aug '12

19 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unuse audit log (Related to BZ822051) ...................................................................... core: Remove unuse audit log (Related to BZ822051) Remove unused audit log type Change-Id: Ie1b6727b6fa405460bf91ac4fc6f1879734326dd Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1b6727b6fa405460bf91ac4fc6f1879734326dd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove deprecated StringHelper in AttachNetworkToVdsGr...
by masayag＠redhat.com 19 Aug '12

19 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove deprecated StringHelper in AttachNetworkToVdsGroupCommand. ...................................................................... core: Remove deprecated StringHelper in AttachNetworkToVdsGroupCommand. Replaced StringHelper with StringUtils Change-Id: I451426e52690544075326bde033573283febecbb Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I451426e52690544075326bde033573283febecbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removing use of StingHelper.
by masayag＠redhat.com 19 Aug '12

19 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Removing use of StingHelper. ...................................................................... core: Removing use of StingHelper. cleanup code and import. Change-Id: I29de43c643be8cd0bc367c487f2e1d5c50b41e74 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/PoolConditionFieldAutoCompleter.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29de43c643be8cd0bc367c487f2e1d5c50b41e74 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0