August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix AutoRecoveryTest
by masayag＠redhat.com 06 Aug '12

06 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix AutoRecoveryTest ...................................................................... core: Fix AutoRecoveryTest Removed redundant unit test that test the default behaviour, which is not a stable behaviour configuration worth testing. Change-Id: Ie5196a92dace692289399cf40be18bf58b78315a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AutoRecoveryManagerTest.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5196a92dace692289399cf40be18bf58b78315a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Update URL of DocumentationPath CSV fil...
by ecohen＠redhat.com 06 Aug '12

06 Aug '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin,userportal: Update URL of DocumentationPath CSV files ...................................................................... webadmin,userportal: Update URL of DocumentationPath CSV files This patch updates the URL of DocumentationPath CSV files, containing dialog-to-documentation mappings used with context-sensitive help feature. Before this patch, CSV files were fetched from following locations: (assuming that vdc_options table declares 'DocsURL' with value 'docs') * WebAdmin http://<server-name>/docs/en-US/DocumentationPath.csv * UserPortal http://<server-name>/docs/en-US/UserPortalDocumentationPath.csv After this patch, CSV files are fetched from following locations: * WebAdmin http://<server-name>/docs/DocumentationPath.csv * UserPortal http://<server-name>/docs/UserPortalDocumentationPath.csv This has no impact on actual locale-specific HTML documentation URLs, e.g. http://<server-name>/docs/en-US/html/path/to/dialog/guide.html This patch also adds some Javadoc for better clarity. Change-Id: Ia649d860ebed35e2784bdeb183d49c5368c6f718 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java 1 file changed, 17 insertions(+), 4 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia649d860ebed35e2784bdeb183d49c5368c6f718 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: api: user can set port mirroring without network id
by shavivi＠redhat.com 06 Aug '12

06 Aug '12

Shahar Havivi has submitted this change and it was merged. Change subject: api: user can set port mirroring without network id ...................................................................... api: user can set port mirroring without network id Change-Id: I49bdb50901c3a2281124e36d4a7cc0423b1a6be6 Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java 2 files changed, 72 insertions(+), 35 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49bdb50901c3a2281124e36d4a7cc0423b1a6be6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Prevent Repetetive Static Ip (#839199)
by msalem＠redhat.com 06 Aug '12

06 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: Prevent Repetetive Static Ip (#839199) ...................................................................... core: Prevent Repetetive Static Ip (#839199) https://bugzilla.redhat.com/839199 Use reference Collection instead of HashSet, move inner class to end of file, add comment to empty method. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: I2839816e890989c6512162640e356189781c1e63 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraint.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraintTest.java 2 files changed, 13 insertions(+), 11 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2839816e890989c6512162640e356189781c1e63 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disable Autorecvery Feature
by yzaslavs＠redhat.com 06 Aug '12

06 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Disable Autorecvery Feature ...................................................................... core: Disable Autorecvery Feature Disable Autorecovery feature temporarily. This feature currently compromises the system's stability, so it was decided to disable it until it is stabilized. Change-Id: I2a93bdfcf62682bfeea123adb09960ef3dac4fa2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Ayal Baron: Looks good to me, but someone else must approve Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a93bdfcf62682bfeea123adb09960ef3dac4fa2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: guide me- vnic- port mirroring doesn't saved
by gchaplik＠redhat.com 06 Aug '12

06 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: guide me- vnic- port mirroring doesn't saved ...................................................................... webadmin: guide me- vnic- port mirroring doesn't saved https://bugzilla.redhat.com/844727 When setting port mirroring property through guide me- add vnic the property wasn't saved. Change-Id: I0db02420c5a4d3c04b11adeedf354225458ffa18 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0db02420c5a4d3c04b11adeedf354225458ffa18 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: non vm networks in template-vnic dialog (add and e...
by gchaplik＠redhat.com 06 Aug '12

06 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: non vm networks in template-vnic dialog (add and edit) ...................................................................... webadmin: non vm networks in template-vnic dialog (add and edit) https://bugzilla.redhat.com/842249 https://bugzilla.redhat.com/845932 remove no-vm networks from - template->vnic add and edit dialogs. - vm guide me-> add vnic Change-Id: Ibabe5abd6de5b0a1dda1c11bd50b899161a675b0 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibabe5abd6de5b0a1dda1c11bd50b899161a675b0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: activate- on guide me, and remove vnic
by gchaplik＠redhat.com 06 Aug '12

06 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: activate- on guide me, and remove vnic ...................................................................... webadmin: activate- on guide me, and remove vnic https://bugzilla.redhat.com/841557 - When adding vnic through guide me dialog on a 3.0 cluster activate should be always true and disabled. - Can't remove vnic from down vm if the activate status is up. Change-Id: I12c6e44bfa32b1e5916d9ae61dadf958916a8100 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c6e44bfa32b1e5916d9ae61dadf958916a8100 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add sync network to setup networks
by gchaplik＠redhat.com 06 Aug '12

06 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Add sync network to setup networks ...................................................................... webadmin: Add sync network to setup networks https://bugzilla.redhat.com/838333 Gui functionality for sync network. - Add sync network symbol to network panel - Add sync netwrok to network tool tip - Add sync network check box to edit network dialog. The edit is enables only if the sync networ checkbox is checked. Change-Id: Ie46bcd1aef988c7f9a7fa33658e6e49879b9be36 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostInterfacePopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksInterfacePopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksManagementPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksManagementPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/editor/EnumRadioEditor.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/network_not_sync.png 23 files changed, 418 insertions(+), 57 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie46bcd1aef988c7f9a7fa33658e6e49879b9be36 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: release 3.1.0.7-1
by mpastern＠redhat.com 06 Aug '12

06 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.1.0.7-1 ...................................................................... cli: release 3.1.0.7-1 Change-Id: I7a6a0c9ebbe02e31de64db97564d2027c82a5f7e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M setup.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a6a0c9ebbe02e31de64db97564d2027c82a5f7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0