August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Add "custom configuration" to NIC (#838300)
by mkolesni＠redhat.com 05 Aug '12

05 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Add "custom configuration" to NIC (#838300) ...................................................................... restapi: Add "custom configuration" to NIC (#838300) https://bugzilla.redhat.com/838300 This field will indicate if a NIC is out-of-sync, i.e. has some custom configuration that is not aligned to the logical network configuration. Change-Id: I6d6a678a0f1b793f4a218ec7eaf1ac2a2f815796 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostNicMapperTest.java 3 files changed, 20 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d6a678a0f1b793f4a218ec7eaf1ac2a2f815796 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Added support for WANDisableEffects and WANColorDepth
by oourfali＠redhat.com 05 Aug '12

05 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: tools: Added support for WANDisableEffects and WANColorDepth ...................................................................... tools: Added support for WANDisableEffects and WANColorDepth It has already been in vdc_options table, this patch enables the editing of this config values using the EngineConfig tool. For detailed description of the meaning of this values please consult this wiki: http://wiki.ovirt.org/wiki/Features/SPICERelatedFeatures Change-Id: Id796ae06e1d5d5a9aa6317741f02aad7b9ebb0b5 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id796ae06e1d5d5a9aa6317741f02aad7b9ebb0b5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[master]: cleanup: remove unused IPWorksInstallWrapper
by dfediuck＠redhat.com 04 Aug '12

04 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: cleanup: remove unused IPWorksInstallWrapper ...................................................................... cleanup: remove unused IPWorksInstallWrapper We use apache-sshd as SSH provider. Change-Id: I0be81d9ac84bc34acb6a79a53c7e5b4770fde845 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/IPWorksInstallWrapper.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/IPWorksInstallWrapperTest.java 2 files changed, 0 insertions(+), 287 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0be81d9ac84bc34acb6a79a53c7e5b4770fde845 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: cleanup: vds_installer: make main return boolean
by dfediuck＠redhat.com 04 Aug '12

04 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: cleanup: vds_installer: make main return boolean ...................................................................... cleanup: vds_installer: make main return boolean As discussed at [1], and due to a bug resulted in returning boolean from main instead of process exit value, main is modified to return boolean to reduce future mistakes. [1] http://gerrit.ovirt.org/6721 Change-Id: If90f3afbab7fe381a10d10861e5cac6fe2c89b92 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/vds_installer.py 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If90f3afbab7fe381a10d10861e5cac6fe2c89b92 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>

1 0

Change in ovirt-engine[master]: vds_installer: set proper exit code when success
by dfediuck＠redhat.com 04 Aug '12

04 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: vds_installer: set proper exit code when success ...................................................................... vds_installer: set proper exit code when success return 'True' actually causes process to exit with non-zero code, hence failure. Change-Id: If0f666ab45fb68cb50e1415d4a47df176496a12f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/vds_installer.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0f666ab45fb68cb50e1415d4a47df176496a12f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixed NPE during removal of floating disk (#845046)
by mlipchuk＠redhat.com 02 Aug '12

02 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: fixed NPE during removal of floating disk (#845046) ...................................................................... core: fixed NPE during removal of floating disk (#845046) https://bugzilla.redhat.com/show_bug.cgi?id=845046 when trying to remove a floating disk NPE was encountered beacuse of the use of NGuid.createGuidFromString (who can return null) instead of Guid.createGuidFromString who on DiskImageMapper. The current change provides null check and equality check to Guid.Empty in order to not affect other flows that count on null on that property. Change-Id: I6ffca77cc5a02558847366dd8ccb886ee515d612 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ffca77cc5a02558847366dd8ccb886ee515d612 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: do not send empty headers
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: do not send empty headers ...................................................................... sdk: do not send empty headers Change-Id: Iae3cb4b352687e52ceaa1c59fa5deae67e4a6209 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/web/connection.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae3cb4b352687e52ceaa1c59fa5deae67e4a6209 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: codegen: implement http header support
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: implement http header support ...................................................................... codegen: implement http header support Change-Id: I95b792f1e874625ffd9f043040a26a918b2676ad Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/collection/collection.py M src/codegen/collection/resource.py M src/codegen/doc/documentation.py M src/codegen/subcollection/subcollection.py M src/codegen/subcollection/subresource.py A src/codegen/utils/headerutils.py M src/ovirtsdk/infrastructure/brokers.py 7 files changed, 862 insertions(+), 424 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95b792f1e874625ffd9f043040a26a918b2676ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: refactor url params documentation
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: refactor url params documentation ...................................................................... sdk: refactor url params documentation Change-Id: I4646639af9aa29c435bbe28f49cc84de14fefa96 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/utils/paramutils.py M src/ovirtsdk/infrastructure/brokers.py 2 files changed, 112 insertions(+), 108 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4646639af9aa29c435bbe28f49cc84de14fefa96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 02 Aug '12

02 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api - removed disk.allow_snapshot param documentation - to network.update() added [@param network.name: string] - fixed vm/template os.boot documentation Change-Id: I86d2b7e23bdce46aa417b54e0c2919b8d1dd22f8 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 59 insertions(+), 54 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86d2b7e23bdce46aa417b54e0c2919b8d1dd22f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0