September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix error message when adding unreachable SD (#853044)
by derez＠redhat.com 19 Sep '12

19 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: fix error message when adding unreachable SD (#853044) ...................................................................... core: fix error message when adding unreachable SD (#853044) https://bugzilla.redhat.com/853044 The error message when adding an SD to a host that couldn't reach it was "Internal oVirt engine error". This improves the message by both propagating the actual error through the backend, and generalizing the message wording so the solution is accurate in this case. Change-Id: Ia1007ce4678576181563f77e39bd8b83b8dd0752 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 12 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1007ce4678576181563f77e39bd8b83b8dd0752 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactored ExecuteVmCommand() to conform to java sta...
by lhornyak＠redhat.com 19 Sep '12

19 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Refactored ExecuteVmCommand() to conform to java standards. ...................................................................... engine: Refactored ExecuteVmCommand() to conform to java standards. Renamed ExecuteVmCommand to executeVmCommand Change-Id: If4965a32cc235a66470b7c868811908a3a6dece6 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PowerClientMigrateOnConnectCheckCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetDedicatedVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmOperationCommandBase.java 26 files changed, 33 insertions(+), 33 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4965a32cc235a66470b7c868811908a3a6dece6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removing unused class AdGroupsHandlingOperationBase
by lhornyak＠redhat.com 19 Sep '12

19 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removing unused class AdGroupsHandlingOperationBase ...................................................................... core: removing unused class AdGroupsHandlingOperationBase Change-Id: I00946d23468940633a0d2a35566b52f65c819f9d Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AdGroupsHandlingOperationBase.java 1 file changed, 0 insertions(+), 44 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00946d23468940633a0d2a35566b52f65c819f9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: fix RemoveCommand.name
by mpastern＠redhat.com 19 Sep '12

19 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: fix RemoveCommand.name ...................................................................... cli: fix RemoveCommand.name Change-Id: Iab8bf493f63d2fa1010ade4174d4ad61436e16ee Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/remove.py 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab8bf493f63d2fa1010ade4174d4ad61436e16ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Avoid 64 bit JVM options (#852037)
by juan.hernandez＠redhat.com 16 Sep '12

16 Sep '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Avoid 64 bit JVM options (#852037) ...................................................................... packaging: Avoid 64 bit JVM options (#852037) https://bugzilla.redhat.com/852037 Currently we add the -XX:+UseCompressedOops to the execution of the JVM regardless of the architecture, but this option only works in 64 bit JVMs, in fact 32 bits JVMs fail if this option is included. This patch removes that option as it is already enabled by default in OpenJDK 7. Change-Id: Ia1e04d1f74b04a50ae2e7952820dd0da58ba6b15 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1e04d1f74b04a50ae2e7952820dd0da58ba6b15 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: allow upgrading cluster level when there are running V...
by rgolan＠redhat.com 16 Sep '12

16 Sep '12

Roy Golan has submitted this change and it was merged. Change subject: core: allow upgrading cluster level when there are running VMs (#856172) ...................................................................... core: allow upgrading cluster level when there are running VMs (#856172) Removing the restriction of upgrading a cluster level when there are running VMs (but CPU level stays the same). Its obvious that running VMs do not gain the new compatibility level functionality until VM is restarted e.g. a memballon device, VM payload and so on. Change-Id: Id6676ddf8c28cec9e611bd0b35b335c4c0102f7d Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 1 insertion(+), 12 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6676ddf8c28cec9e611bd0b35b335c4c0102f7d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: HibernateVmCommand's ConcreteCreateTask
by derez＠redhat.com 16 Sep '12

16 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: HibernateVmCommand's ConcreteCreateTask ...................................................................... core: HibernateVmCommand's ConcreteCreateTask Removed ConcreteCreateTask from HibernateVmCommand., and used the new getTaskType() mechanism introduced to CommandBase. Change-Id: I813d7a7b8933cdcdedb343322359756b345d3765 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 14 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I813d7a7b8933cdcdedb343322359756b345d3765 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmCommand's ConcreteCreateTask
by derez＠redhat.com 16 Sep '12

16 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: VmCommand's ConcreteCreateTask ...................................................................... core: VmCommand's ConcreteCreateTask Removed ConcreteCreateTask from VmCommand, and used the new getTaskType() mechanism introduced to CommandBase. Note that since VmCommand is abstract, the testing was done on RemoveVmCommand which extends it and does NOT override these methods itself. Change-Id: I8fb7c90caa1e327263c0b238ae0aff48ce6b2429 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 4 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb7c90caa1e327263c0b238ae0aff48ce6b2429 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RestoreFromSnapshot's ConcreteCreateTask
by derez＠redhat.com 16 Sep '12

16 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: RestoreFromSnapshot's ConcreteCreateTask ...................................................................... core: RestoreFromSnapshot's ConcreteCreateTask Removed ConcreteCreateTask from RestoreFromSnapshotCommand, and used the new getTaskType() mechanism introduced to CommandBase. Change-Id: I0c4c85ad6172ce3590e7ade7856cc99b6f921975 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 9 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c4c85ad6172ce3590e7ade7856cc99b6f921975 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveTemplateSnapshot's ConcreteCreateTask
by derez＠redhat.com 16 Sep '12

16 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveTemplateSnapshot's ConcreteCreateTask ...................................................................... core: RemoveTemplateSnapshot's ConcreteCreateTask Removed ConcreteCreateTask from RemoveTemplateSnapshotCommand, and used the new getTaskType() mechanism introduced to CommandBase. Change-Id: Ic9987ba27f2cd86ba26fd7e9b6e2af75a7a5149c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 8 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9987ba27f2cd86ba26fd7e9b6e2af75a7a5149c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0