September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: NPE in RestoreAllSnapshotsCommand (#854895)
by gchaplik＠redhat.com 10 Sep '12

10 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: NPE in RestoreAllSnapshotsCommand (#854895) ...................................................................... core: NPE in RestoreAllSnapshotsCommand (#854895) https://bugzilla.redhat.com/854895 storagePoolId was never set in the command, caused QuotaManager to throw a NPE. Change-Id: Ibb15567b647fd9a898bb645264e69cdf896fdbae Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/7896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb15567b647fd9a898bb645264e69cdf896fdbae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: NPE in remove vm from Export D (#854607)
by gchaplik＠redhat.com 10 Sep '12

10 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: NPE in remove vm from Export D (#854607) ...................................................................... core: NPE in remove vm from Export D (#854607) https://bugzilla.redhat.com/854607 when invoking remove VM/Template from export domain, we used to call validateAndSetQuota since removeVm/TemplateFromExportDomainCommand derives from RemoveVm/TemplateCommand. but in export case we don't use quota. so override quota methods to do nothing in this stage. Change-Id: I7a54bd5450a1859d892154d04300cf11d82d966d Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java 3 files changed, 29 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a54bd5450a1859d892154d04300cf11d82d966d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: cannot import collapsed snapshot VM (#845947)
by gchaplik＠redhat.com 10 Sep '12

10 Sep '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: cannot import collapsed snapshot VM (#845947) ...................................................................... webadmin: cannot import collapsed snapshot VM (#845947) https://bugzilla.redhat.com/845947 in case the template was missing in the system, but resided in the export domain, the dialog mistakenly denided importing the vm. now it just adding a comment and allowing import only with collapse snapshot. Change-Id: I80f1a8e999dda31f644cdf767eeb536109049a26 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 3 files changed, 61 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80f1a8e999dda31f644cdf767eeb536109049a26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix table context menu
by vszocs＠redhat.com 10 Sep '12

10 Sep '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix table context menu ...................................................................... webadmin,userportal: Fix table context menu Before this patch, CellTable's CellPreviewHandler was used to capture 'mousedown/right-click' events to select the row where mouse was pointing. After that, CellTable's ContextMenuHandler was used to capture 'contextmenu' events to prevent the default browser-specific context menu, and to show application-specific table context menu. In some cases, CellPreviewHandler prevented ContextMenuHandler to be invoked properly, which caused the default browser-specific context menu to appear (instead of application-specific one). This patch fixes the above mentioned problem by moving CellPreviewHandler logic into ContextMenuHandler, and using deferred command when showing application-specific context menu. This patch also fixes a problem when clicking "outside" the table (within its parent DIV element that fills up remaining space vertically) doesn't cause the application-specific context menu to appear. Change-Id: Ic699cb5880be54cb0402cd3f1d176b635d188bf0 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 2 files changed, 74 insertions(+), 34 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic699cb5880be54cb0402cd3f1d176b635d188bf0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor code to use VdsProperties constants(#855651)
by emesika＠redhat.com 10 Sep '12

10 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Refactor code to use VdsProperties constants(#855651) ...................................................................... core: Refactor code to use VdsProperties constants(#855651) Refactor code handling Hot Plug Nics to use VdsProperties constants rather than fixed strings. Change-Id: Ic1df4183f6ebc0fd50733d4b8f934c30dca43020 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 2 files changed, 13 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1df4183f6ebc0fd50733d4b8f934c30dca43020 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Hot Plug Nic/Disk creates incorre...(#855651)
by emesika＠redhat.com 10 Sep '12

10 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core:Hot Plug Nic/Disk creates incorre...(#855651) ...................................................................... core:Hot Plug Nic/Disk creates incorre...(#855651) core:Hot Plug Nic/Disk creates incorrect duplicate devices https://bugzilla.redhat.com/show_bug.cgi?id=855651 The Hot Plug Nic/Disk commands does not set the deviceId field. When we get run time info from VDSM, we are looking for the deviceId field, it is is not found, the device is assumed to be an unmanaged device reported to us as a new device by VDSM (i.e. does not exists in DB yet) This will result in a duplicate of each Nic/Disk that is marked as managed device with another device (with different GUID) in vm_device that is marked as an unmanaged device while the last (and incorrect device) will get the address and alias field updates. This patch sets the deviceId field in Nic/Disk Hot Plug command, since this field is not touched by VDSM and returned as is, we can match the returned hot-plug device when updates arrived with current hot plug devices and update the information instead adding new devices. Change-Id: Idac67477c800339b0c48f86a3281c90f3fd4ed7b Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idac67477c800339b0c48f86a3281c90f3fd4ed7b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change toString syntax to match convention (#851991)
by masayag＠redhat.com 10 Sep '12

10 Sep '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Change toString syntax to match convention (#851991) ...................................................................... core: Change toString syntax to match convention (#851991) https://bugzilla.redhat.com/851991 Should be curly brackets instead of square. Change-Id: I65ec0dc1bf472ca37ab00ce041c2db3565f23d6b Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65ec0dc1bf472ca37ab00ce041c2db3565f23d6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Failed to activate ISO domain ...(#854492)
by emesika＠redhat.com 10 Sep '12

10 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Failed to activate ISO domain ...(#854492) ...................................................................... core: Failed to activate ISO domain ...(#854492) core: Failed to activate ISO domain that is already attached to 2 DC https://bugzilla.redhat.com/854492 Replacing "UNION" with "UNION ALL" in fn_get_entity_parents when sub query may return more than one result. For the reported scenario in the BZ the following query was part of the UNION : SELECT storage_pool_id as id FROM storage_pool_iso_map WHERE storage_id = v_entity_id Since in this scenario the ISO domain exists in 2 DCs the sub query returned 2 rows and Postgres throwed the reported SQL exception. Change-Id: I887005e3fc0461101b4b8ec9e24654e7dc228142 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I887005e3fc0461101b4b8ec9e24654e7dc228142 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Progress indicator during login
by vszocs＠redhat.com 10 Sep '12

10 Sep '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Progress indicator during login ...................................................................... webadmin,userportal: Progress indicator during login This patch makes sure that a progress indicator, represented as the 'wait' mouse cursor, is shown during the entire login process. >From UiCommon/GWTP point of view, the login process consists of following steps: 0. Default place of login section (#login) gets revealed 1a. If the user is already logged-in on the backend: * UiCommon LoginModel is instructed to sign the user in automatically by calling its AutoLogin method * AutoLogin method takes care of populating appropriate UI fields (UserName, Domain) and fires LoggedInEvent 1b. If the user is NOT already logged-in on the backend: * User fills the login form and hits Enter/Login * UiCommon LoginModel is instructed to initiate the login operation (authentication) by calling its Login method * If successful, Login method fires LoggedInEvent 2. WebAdmin/UserPortal ApplicationInit.onLogin method gets called in response to LoginModel's LoggedInEvent: * Both WebAdmin and UserPortal do some early init logic and then call BaseApplicationInit.performLogin method * BaseApplicationInit.performLogin represents actions taken by UI after successful user authentication 3. Default place of main section (#vms) gets revealed Instead of showing/hiding progress indicator for each of the steps outlined above (e.g. using LoginModel "Progress" for the authentication operation in step 1b), progress indicator is shown once, when the actual login process starts (1a/1b), and is hidden after reaching main section (3). LockInteractionManager is the class responsible for handling progress indicator. For now, it only reacts to "GWTP place transition finished" events, in order to hide the progress indicator after GWTP place transition (e.g. #login -> #vms). In future, it can react to "GWTP place transition started" events as well. For now, there is only one kind of progress indicator: 'wait' mouse cursor (applicable to login section). In future, there might be another kind of progress indicator applicable for main section. Change-Id: Iecc4892e0848bfedf63a974b94acf2564241a0c7 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/LockInteractionManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DeferredModelCommandInvoker.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 10 files changed, 139 insertions(+), 43 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecc4892e0848bfedf63a974b94acf2564241a0c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: change collection based arguments syntax help #854506
by mpastern＠redhat.com 10 Sep '12

10 Sep '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: change collection based arguments syntax help #854506 ...................................................................... cli: change collection based arguments syntax help #854506 https://bugzilla.redhat.com/show_bug.cgi?id=854506 Change-Id: I9b16f0ce9e160b6a9a0fb23077ed30599cf55842 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/action.py M src/ovirtcli/command/create.py M src/ovirtcli/command/delete.py M src/ovirtcli/command/update.py 4 files changed, 52 insertions(+), 16 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b16f0ce9e160b6a9a0fb23077ed30599cf55842 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0