January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Bump version number to 3.3.0-SNAPSHOT
by juan.hernandez＠redhat.com 30 Jan '13

30 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Bump version number to 3.3.0-SNAPSHOT ...................................................................... packaging: Bump version number to 3.3.0-SNAPSHOT Increase the version numbers and use -SNAPSHOT suffix in all artifact versions. Change-Id: I67a2a72019c903c9eed7cc8211b82d532d242a44 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/dbscripts/pom.xml M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/beans/pom.xml M backend/manager/modules/beans/scheduler/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/engineencryptutils/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/pom.xml M backend/manager/tools/engine-config/pom.xml M backend/manager/tools/engine-notifier/engine-notifier-resources/pom.xml M backend/manager/tools/engine-notifier/engine-notifier-service/pom.xml M backend/manager/tools/engine-notifier/pom.xml M backend/manager/tools/engine-tools-common/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/wars/pom.xml M frontend/wars/rmw-war/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M packaging/engine-setup.8 M packaging/engine-upgrade.8 M packaging/fedora/spec/ovirt-engine.spec.in M pom.xml 51 files changed, 61 insertions(+), 57 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67a2a72019c903c9eed7cc8211b82d532d242a44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Moving Duplicate Code to Base Class
by msalem＠redhat.com 30 Jan '13

30 Jan '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Moving Duplicate Code to Base Class ...................................................................... engine: Moving Duplicate Code to Base Class This patch moves the duplicate code from AddVmInterfaceCommand and UpdateVmInterfaceCommand into their base class. Change-Id: I3b07249bc2e554e2a420792fd100781dff748958 Bug-Url: https://bugzilla.redhat.com/905844 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 3 files changed, 101 insertions(+), 122 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b07249bc2e554e2a420792fd100781dff748958 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add default description to multiple action result
by alkaplan＠redhat.com 30 Jan '13

30 Jan '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Add default description to multiple action result ...................................................................... webadmin: Add default description to multiple action result Each result on multiple action result list can have multiple canDo action messages. Today all the canDo action messages are displayed as a bulk and the user can't understand which message belongs to which action. To correlate between the action and the message a description should be set on the result. For example if the user is trying to remove multiple vms. The description of each result should be the vm name. The errors are displayed in the following way- description1: - msg1 - msg2 description2: - msg1 The problem is that not all the commands set description on the returned value. This patch checks if there is description, if not, a default one is set- "Action #num:" Change-Id: I25495eedf3ec61e11eb3c2bb075833fbcc8f9537 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25495eedf3ec61e11eb3c2bb075833fbcc8f9537 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Extended error for pinned host missing non required ...
by alkaplan＠redhat.com 30 Jan '13

30 Jan '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Extended error for pinned host missing non required network ...................................................................... engine: Extended error for pinned host missing non required network There are a lot of reasons for a vm pinned to a host to fail running. The old message specified just a small amount of them. The message was fixed to display the exact reason for which the vm failed to run. Change-Id: Ibf9703ae06b06be96c6508d48306d8bd6b8bcfbb Bug-Url: https://bugzilla.redhat.com/878451 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 21 insertions(+), 18 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9703ae06b06be96c6508d48306d8bd6b8bcfbb Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Showing more than one canDoMessage for action in m...
by alkaplan＠redhat.com 30 Jan '13

30 Jan '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Showing more than one canDoMessage for action in multiple action ...................................................................... webadmin: Showing more than one canDoMessage for action in multiple action If an action that is part of muliple action has more than one canDoMessage, just the first message is displayed. This patch fixes it. Also, if the action has description, it should also be displayed. Change-Id: I89338d119144279d84c08b62543e836c3492f07e Bug-Url: https://bugzilla.redhat.com/878451 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89338d119144279d84c08b62543e836c3492f07e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in otopi[master]: network: iptables: support CentOS
by Alon Bar-Lev 30 Jan '13

30 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: network: iptables: support CentOS ...................................................................... network: iptables: support CentOS Adding in validation centos distro Change-Id: I5f9c7a0b637c206a868c6613cca3cf8c8a9cc1d3 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/plugins/otopi/network/iptables.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, approved Douglas Schilling Landgraf: Verified -- To view, visit http://gerrit.ovirt.org/11559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f9c7a0b637c206a868c6613cca3cf8c8a9cc1d3 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: software: support CentOS
by Alon Bar-Lev 30 Jan '13

30 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: software: support CentOS ...................................................................... vdsm: software: support CentOS Adding in validation centos distro Change-Id: I6adc6406341ff028228f39e57d1b16e34adaa661 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/software.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, approved Douglas Schilling Landgraf: Verified -- To view, visit http://gerrit.ovirt.org/11550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6adc6406341ff028228f39e57d1b16e34adaa661 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: build: fix typo
by kroberts＠redhat.com 30 Jan '13

30 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: build: fix typo ...................................................................... build: fix typo Change-Id: I1d970422616f5fb2d30686ce0242c20731610efe Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d970422616f5fb2d30686ce0242c20731610efe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fixing engine-manage-domains script
by yzaslavs＠redhat.com 30 Jan '13

30 Jan '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing engine-manage-domains script ...................................................................... tools: Fixing engine-manage-domains script Engine-manage-domains must also read the ldap server port configuration as it might be used with the ldapServers switch Change-Id: I1d970422616f5fb2d30686ce0242c20731610eff Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/conf/kerberos/engine-manage-domains 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d970422616f5fb2d30686ce0242c20731610eff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename remove storage connection command
by mlipchuk＠redhat.com 30 Jan '13

30 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: rename remove storage connection command ...................................................................... core: rename remove storage connection command Rename removeStorageServerConnection command and VdcAction type to disconnectStorageServerConnection since this command disconnects it on vdsm side, but does not remove its record from the db. It's more correct to call it "disconnect" according to what it actually does. It's also preparation for adding (in different patch) a remove command that actully both disconnects the storage and removes the storage connection from the db. Also, remove a big commented piece of code from AddStorageDomainRM because it's commented out anyway and just makes the class bigger because of dead code. Change-Id: I0b6043810a5c4200593befd668a279ea56ff4693 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 7 files changed, 13 insertions(+), 94 deletions(-) Approvals: Alissa Bonas: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b6043810a5c4200593befd668a279ea56ff4693 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0