January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-iso-uploader[master]: build: build rewrite using autotools
by kroberts＠redhat.com 07 Jan '13

07 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: build: build rewrite using autotools ...................................................................... build: build rewrite using autotools autotools provide simple method to integrate with standard tools such as rpm spec. It also provides easy gettext integration. git version magic was not added to ease maintenance. Package is now install at pythonlib with symbolic link to bindir. Change-Id: Ifdb10d76cdcfab61f6728a0f639d061c39f677c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A .gitignore M AUTHORS R COPYING D Makefile A Makefile.am A README.localization A autogen.sh A build/python.inc A configure.ac A m4/.gitignore A m4/ax_python_module.m4 M ovirt-iso-uploader.spec.in A po/.gitignore A po/LINGUAS A po/Makevars A po/POTFILES.in D src/Makefile A src/Makefile.am A src/__init__.py R src/__main__.py 20 files changed, 521 insertions(+), 155 deletions(-) Approvals: Alon Bar-Lev: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdb10d76cdcfab61f6728a0f639d061c39f677c4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: tools: adding gluster logs
by kroberts＠redhat.com 07 Jan '13

07 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: tools: adding gluster logs ...................................................................... tools: adding gluster logs Gluster logs support added to hypervisors, collects gluster logs only if gluster is enabled in respective cluster. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=856127 Change-Id: I756aea7457c2cd7c9c7b0b842149110f5f392abb Signed-off-by: Aravinda VK <avishwan(a)redhat.com> --- M src/rhev/helper/hypervisors.py M src/rhev/logcollector.py 2 files changed, 14 insertions(+), 5 deletions(-) Approvals: Shireesh Anjal: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I756aea7457c2cd7c9c7b0b842149110f5f392abb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove attach table form edit network dialog
by alkaplan＠redhat.com 07 Jan '13

07 Jan '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: remove attach table form edit network dialog ...................................................................... webadmin: remove attach table form edit network dialog The gui will always permit editing a network. If by any reason the network can't be edited, a canDo will be thrown. In this patch- - Removing the attach table from the edit network model-view-presneter. - Removing the apply action from the dialog (mvp). - Remove the functionality of enabling/disabling the update fileds according to if the network is attached to clusters. Change-Id: If23582ec3489c1aea6f3e1470d16f94be1c195ba bug-url: https://bugzilla.redhat.com/604646 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/EditNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/NewNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java 15 files changed, 194 insertions(+), 732 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If23582ec3489c1aea6f3e1470d16f94be1c195ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DB fix skipped insertions to schema_version
by mlipchuk＠redhat.com 07 Jan '13

07 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: DB fix skipped insertions to schema_version ...................................................................... core: DB fix skipped insertions to schema_version When running create_db.sh scripts 03_00_0420 and beyond are executed but not inserted to the schema_version table. This is caused to a race since execute_comamnd is running in a loop and creates a temporary file in each iteration. Solution is to gather all inserts in one file and execute them at once. Change-Id: I285434b566a17e1c1b051469b72d1470bca2109b Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I285434b566a17e1c1b051469b72d1470bca2109b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: remove queryLocalCachePackages
by Alon Bar-Lev 07 Jan '13

07 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: remove queryLocalCachePackages ...................................................................... packagers: yum: remove queryLocalCachePackages The queryLocalCachePackages is a legacy from engine-upgrade, which is actually not required as the interface of yum provides the showdups query parameter to achieve the same. Change-Id: Iaa1b0563aa45f44b157f65edc6237dbf4be940e8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/packager.py M src/plugins/otopi/packagers/miniyum.py M src/plugins/otopi/packagers/yumpackager.py 3 files changed, 9 insertions(+), 32 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa1b0563aa45f44b157f65edc6237dbf4be940e8 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: support disable/enable plugins
by Alon Bar-Lev 07 Jan '13

07 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: support disable/enable plugins ...................................................................... packagers: yum: support disable/enable plugins Change-Id: I3ee6caabddf6abbf42ad159d290126ae494b5678 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/miniyum.py 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ee6caabddf6abbf42ad159d290126ae494b5678 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: detect failures during installation
by Alon Bar-Lev 07 Jan '13

07 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: detect failures during installation ...................................................................... packagers: yum: detect failures during installation yum does not raises an exception during process transaction if one or more of packages return an error during installation. So detect the error condition based on error log. Change-Id: Icb6c927b6494f3d59ea30f8878c8cdbe21a7d8a4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/miniyum.py M src/plugins/otopi/packagers/miniyumlocal.py 2 files changed, 27 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb6c927b6494f3d59ea30f8878c8cdbe21a7d8a4 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: fix spelling
by Alon Bar-Lev 07 Jan '13

07 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: fix spelling ...................................................................... packagers: yum: fix spelling Change-Id: Iaec4a78bad9f901fdbf69a6ead6798c5de1513ca Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/miniyum.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaec4a78bad9f901fdbf69a6ead6798c5de1513ca Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packagers: yum: allow to acquire sink out of miniyum
by Alon Bar-Lev 07 Jan '13

07 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packagers: yum: allow to acquire sink out of miniyum ...................................................................... packagers: yum: allow to acquire sink out of miniyum Change-Id: I616b6ec9ce3fca6bbecdfa72816cd77578b34e34 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/miniyum.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I616b6ec9ce3fca6bbecdfa72816cd77578b34e34 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: return object locked message when storage domain is lo...
by derez＠redhat.com 07 Jan '13

07 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: return object locked message when storage domain is locked. ...................................................................... core: return object locked message when storage domain is locked. This patch changed the returned canDoAction in case of a locked storage domain to ACTION_TYPE_FAILED_OBJECT_LOCKED instead of ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL. Change-Id: I209b624cd68050ebfe7eeed49b1350e37832e4aa Bug-Url: https://bugzilla.redhat.com/879355 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I209b624cd68050ebfe7eeed49b1350e37832e4aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0