January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: removed obsolete classes vm_template_image_map_id and ...
by lhornyak＠redhat.com 01 Jan '13

01 Jan '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removed obsolete classes vm_template_image_map_id and vm_template_image_map. ...................................................................... core: removed obsolete classes vm_template_image_map_id and vm_template_image_map. These clasees are not used anymore. Change-Id: I82f0861644f155f7b6c27ba5acb3a069b6f1a8f6 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_template_image_map.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_template_image_map_id.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java 3 files changed, 0 insertions(+), 50 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82f0861644f155f7b6c27ba5acb3a069b6f1a8f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core Renamed vm_pool_map.java to VmPoolMap.java
by lhornyak＠redhat.com 01 Jan '13

01 Jan '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core Renamed vm_pool_map.java to VmPoolMap.java ...................................................................... core Renamed vm_pool_map.java to VmPoolMap.java Change-Id: I91de93b53e961c1a4003cfe36704ea0b79961f2d Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPoolMap.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAOHibernateImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/vmpools/VmPoolMapDAOHibernateImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmPoolDAOTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 13 files changed, 61 insertions(+), 61 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91de93b53e961c1a4003cfe36704ea0b79961f2d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change class name from action_version_map to ActionVer...
by lhornyak＠redhat.com 01 Jan '13

01 Jan '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Change class name from action_version_map to ActionVersionMap. ...................................................................... core: Change class name from action_version_map to ActionVersionMap. Change-Id: I453502472d431f3a4358a3f30c59467f590459bb Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQueryTest.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDAOWrapperImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/actiongroup/ActionVersionMapDAOHibernateImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ActionGroupDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java 10 files changed, 44 insertions(+), 44 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I453502472d431f3a4358a3f30c59467f590459bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Upgrade will update image statuses to OK.
by mlipchuk＠redhat.com 01 Jan '13

01 Jan '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Upgrade will update image statuses to OK. ...................................................................... core: Upgrade will update image statuses to OK. As part of the upgrade process, engine cancel the tasks and removes them. part of this behaviour we also want to change the status of the disk to OK, to avoid cases that the VM cannot be restarted. The proposed solution changes all the LOCKED statuses of images to OK. Change-Id: I2a6bd270ebd2125252a4b155f050db103969cb5e Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/dbscripts/delete_async_tasks_and_compensation_data.sql 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a6bd270ebd2125252a4b155f050db103969cb5e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add no-quota notification and quota buttons
by gchaplik＠redhat.com 01 Jan '13

01 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Add no-quota notification and quota buttons ...................................................................... webadmin: Add no-quota notification and quota buttons Sub-tab quota under the main-tab Data Center had no action buttons (to add, edit, copy or remove quota). When enabling quota in a Data Center, we'd like to notify the user he needs to define quotas. Otherwise system users may be blocked from running VMs or creating new disks. This patch will add such a notification when the data center has no quotas defined. DataCenterQuotaListModel was changed to inherit QuotaListModel in order to include all CRUD actions. Change-Id: Ie5d360af1329df9f274f9e9651e3c0d9a8053f1b Bug-Url: https://bugzilla.redhat.com/845022 Bug-Url: https://bugzilla.redhat.com/855630 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetQuotaByStoragePoolIdQueryParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterQuotaListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterQuotaView.java 6 files changed, 141 insertions(+), 51 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d360af1329df9f274f9e9651e3c0d9a8053f1b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine, webadmin: Networks sort should be done on engine side
by alkaplan＠redhat.com 01 Jan '13

01 Jan '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine,webadmin: Networks sort should be done on engine side ...................................................................... engine,webadmin: Networks sort should be done on engine side Networks main tab should be sorted in the following way- Primary sort- data center name Secondary sort- network name The sort was done on the webadmin side. It caused a bug, cause if the search string included "sort by" it was ignored (the webadmin sorted all the items ignoring the search string). Change-Id: Ic9735606231e1947e76bd5550cbcc6566ac8a968 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java 2 files changed, 1 insertion(+), 24 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9735606231e1947e76bd5550cbcc6566ac8a968 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network subtabs should be sorted
by alkaplan＠redhat.com 01 Jan '13

01 Jan '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network subtabs should be sorted ...................................................................... webadmin: Network subtabs should be sorted Network Cluster- by cluster name Network Host- primary- cluster name, secondary- host name. Change-Id: I5a83db1190657106ebb146c3b71a825c4feab98d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java 2 files changed, 37 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a83db1190657106ebb146c3b71a825c4feab98d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: unused import in VmCommand
by yzaslavs＠redhat.com 01 Jan '13

01 Jan '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: unused import in VmCommand ...................................................................... core: unused import in VmCommand unused import causes to checkstyle violation during engine build. Change-Id: I1e8685f0ceba368a567dfad1d428a2a8b88ef028 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Liron Aravot: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10536 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e8685f0ceba368a567dfad1d428a2a8b88ef028 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: improve notifier logging
by yzaslavs＠redhat.com 01 Jan '13

01 Jan '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: improve notifier logging ...................................................................... tools: improve notifier logging Improve logging of notifier by refining the log levels using introduction of new log4j categories Change-Id: Icaadd9eb23016b4866e5cfa99f919378f19ece1a Bug-Url: https://bugzilla.redhat.com/885444 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/log4j.xml 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaadd9eb23016b4866e5cfa99f919378f19ece1a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Changing max supported virtualized CPUs per VM
by yzaslavs＠redhat.com 01 Jan '13

01 Jan '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Changing max supported virtualized CPUs per VM ...................................................................... core: Changing max supported virtualized CPUs per VM Change-Id: Ideade9e523016b4866e5cfa99f919378f48dbd0a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ideade9e523016b4866e5cfa99f919378f48dbd0a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0