October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: 'remove' confirmation dialog message cleanup
by ecohen＠redhat.com 28 Oct '13

28 Oct '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: 'remove' confirmation dialog message cleanup ...................................................................... webadmin: 'remove' confirmation dialog message cleanup Before this patch, 'remove' confirmation dialog message contained a default message that could have been overridden only if the dialog's HashName didn't start with "remove_". In this patch: * 'remove' confirmation dialog still contains a default message, but now it can always be overridden, regardless of the dialog's hashName value. * Cleaned up (now unnecessary) HashName manipulation in RemoveNetworkQoSModel. * Cleaned up useless calls to set dialog's message (which were probably useful up until http://gerrit.ovirt.org/#/c/14621/ has been merged) in order to prevent regressions such as displaying "Virtual Machines" as the dialog's content instead of the default "Are you sure you want to remove the following items?" message. * Removed the related (now unused) UI constants. Change-Id: I7411dec0eaf8d60cefff563988618f7c548eecce Bug-Url: https://bugzilla.redhat.com/1021584 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/SystemPermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RolePermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/ClusterPolicyListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworkQoSModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/RemoveProvidersModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RemoveVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RemoveVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 32 files changed, 3 insertions(+), 114 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7411dec0eaf8d60cefff563988618f7c548eecce Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: /disconnect on exit only if not already disconnected
by mpastern＠redhat.com 28 Oct '13

28 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: /disconnect on exit only if not already disconnected ...................................................................... cli: /disconnect on exit only if not already disconnected Change-Id: I7fa77a1fdd4db73c84c398d8c4ab7499cd967250 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fa77a1fdd4db73c84c398d8c4ab7499cd967250 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: implement origin state in FiniteStateMachine
by mpastern＠redhat.com 28 Oct '13

28 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: implement origin state in FiniteStateMachine ...................................................................... cli: implement origin state in FiniteStateMachine Change-Id: If2234549d553db1fe52d681da99de67451e7a125 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/state/finitestatemachine.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2234549d553db1fe52d681da99de67451e7a125 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: cleanup
by mpastern＠redhat.com 28 Oct '13

28 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: cleanup ...................................................................... cli: cleanup Change-Id: Ia26a327492c4b45f6fba4ade55abb8bb821c21e5 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/messages.py M src/cli/settings.py M src/ovirtcli/command/help.py M src/ovirtcli/command/ping.py A src/ovirtcli/infrastructure/__init__.py R src/ovirtcli/infrastructure/context.py R src/ovirtcli/infrastructure/historymanager.py R src/ovirtcli/infrastructure/object.py R src/ovirtcli/infrastructure/options.py R src/ovirtcli/infrastructure/settings.py M src/ovirtcli/main.py M src/ovirtcli/shell/cmdshell.py M src/ovirtcli/shell/connectcmdshell.py M src/ovirtcli/shell/engineshell.py M src/ovirtcli/shell/promptmanager.py R src/ovirtcli/shell/promptmode.py 16 files changed, 21 insertions(+), 23 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia26a327492c4b45f6fba4ade55abb8bb821c21e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: do not recover prompt while still in error
by mpastern＠redhat.com 28 Oct '13

28 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: do not recover prompt while still in error ...................................................................... cli: do not recover prompt while still in error Change-Id: Idd3ec528be0c82c4f7b04f234554210329c10d3e Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd3ec528be0c82c4f7b04f234554210329c10d3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: implement prompt initialization
by mpastern＠redhat.com 28 Oct '13

28 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: implement prompt initialization ...................................................................... cli: implement prompt initialization Change-Id: Icabf65340463b31bb6457a6b3bef5fb1edf1e6bb Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icabf65340463b31bb6457a6b3bef5fb1edf1e6bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: deadlock and related changes in domain monitoring/Init...
by tnisan＠redhat.com 28 Oct '13

28 Oct '13

Tal Nisan has submitted this change and it was merged. Change subject: core: deadlock and related changes in domain monitoring/InitVdsOnUp ...................................................................... core: deadlock and related changes in domain monitoring/InitVdsOnUp The following patches fixes few issues related to the given bug: 1. Deadlock between domain failover process and InitVdsOnUp flows - Thread 1 (domain failover process) - runs within the event queue (a), attempts to call SetVdsStatus command that waits for lock on VdsManager.getLockObj() (b) Thread 2 - InitVdsOnUp - runs through the VdsManager.OnTimer with lock on VdsManager.getLockObj() (b) and waits for event submitted to the event queue to be executed (a) The implemented solution is to call SetVdsStatus executed from thread 1 on a new thread which will also reduce the wait time for the mutex. 2. Domain monitoring information should be processed from hosts that are "Up", if the host is not UP it means that something is wrong with that domain regardless (for example, if the host was moved to non-op status because of problematic report of domain, there's no reason to analyze each time its domain report). 3. Reduce calls to SetVdsStatus thus reducing acquired locks and wait time in case that the host isn't UP (if the host is already not up because of some other reason, there's no need to change it's status). Change-Id: I334b450fcf29ed57675ec1f2e4bf3bc43f31b4aa Bug-Url: https://bugzilla.redhat.com/965972 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 2 files changed, 31 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I334b450fcf29ed57675ec1f2e4bf3bc43f31b4aa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: New checkbox for volume delete permission under gl...
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: New checkbox for volume delete permission under gluster. ...................................................................... webadmin: New checkbox for volume delete permission under gluster. This patch adds a checkbox for delete volume permission under gluster which was missing before. Now permission to delete volume can be added to a role by using this. Change-Id: I576c940c628febf849442b7f52ecb498145ea1f9 Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1015478 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I576c940c628febf849442b7f52ecb498145ea1f9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: action to retain the bricks being removed
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: action to retain the bricks being removed ...................................................................... webadmin: action to retain the bricks being removed Added a new 'Retain' action to 'Remove' action group in the Bricks subtab. On clicking, a confirmation will be shown with the list of bricks which are being removed. Upon the confirmation, the bricks will be retained with the gluster volume. Change-Id: I6b2c51bcd09dca6f8201c8caf265334e893cb0cd Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/RemoveBrickStatusModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java 6 files changed, 139 insertions(+), 14 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/20096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b2c51bcd09dca6f8201c8caf265334e893cb0cd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: enabling StopRemoveBrick when data migration is comp...
by kmayilsa＠redhat.com 28 Oct '13

28 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: enabling StopRemoveBrick when data migration is completed ...................................................................... engine: enabling StopRemoveBrick when data migration is completed Changei canDoAction to allow Stop Remove brick to be called even when the task is finished( data migration complete). This helps to implement the Retain Bricks UI command. Also change the remove-brick step status to ABORTED. changing the step status from FINISHED to ABORTED is not allowed through Step.markStepEnded. Hence explicitly update the status and endtime in GlusterAsyncCommand.endStepJob. Change-Id: I88e53fa1772427ea1ae2b6943b76e9a71e772376 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommandTest.java 3 files changed, 16 insertions(+), 12 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/20110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e53fa1772427ea1ae2b6943b76e9a71e772376 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0