October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Hide profiles tab if network is non-VM
by iheim＠redhat.com 13 Oct '13

13 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Hide profiles tab if network is non-VM ...................................................................... webadmin: Hide profiles tab if network is non-VM A non-VM network cannot have profiles associated with it, so the profiles tab of the add/edit network dialog is now hidden whenever the VM network checkbox isn't marked. If the network is non-VM, then whatever's in the (hidden) profiles tab is ignored. Change-Id: I0cb1d77310a88c58d89b997e6fb7a974d06b009e Bug-Url: https://bugzilla.redhat.com/1007286 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 3 files changed, 22 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cb1d77310a88c58d89b997e6fb7a974d06b009e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Removed unused constructor
by iheim＠redhat.com 13 Oct '13

13 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Removed unused constructor ...................................................................... webadmin: Removed unused constructor Presumably added before there was a split between NewVnicProfileModel and EditVnicProfileModel, and was forgotten afterwards. Change-Id: I0a35ed37a445a1251fad427b01d133c857e8c316 Bug-Url: https://bugzilla.redhat.com/1007279 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a35ed37a445a1251fad427b01d133c857e8c316 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Utility class for managing external networks
by mkolesni＠redhat.com 13 Oct '13

13 Oct '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Utility class for managing external networks ...................................................................... engine: Utility class for managing external networks This utility class is useful for managing external networks, currently it provides an easy way to deallocate the vNIC from the external network. Change-Id: I1c93d7a74c66bbcae54cd4667744b0a88882622c Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ExternalNetworkManager.java 1 file changed, 61 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c93d7a74c66bbcae54cd4667744b0a88882622c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Lazily initialize VM interfaces list
by mkolesni＠redhat.com 13 Oct '13

13 Oct '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Lazily initialize VM interfaces list ...................................................................... engine: Lazily initialize VM interfaces list In order to deallocate vNICs from external networks, the interfaces list for the VM is necessary. Therefore, the interfaces list will be initialized lazily. Change-Id: Ib2c08ea82134b398344dfed41e5000de2fe98a74 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c08ea82134b398344dfed41e5000de2fe98a74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove vNIC from external network when necessary
by mkolesni＠redhat.com 13 Oct '13

13 Oct '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Remove vNIC from external network when necessary ...................................................................... engine: Remove vNIC from external network when necessary Removing the vNIC from the external network only when the vNIC is removed or the VM gets somehow removed. This will allow the user of the vNIC to manipulate it on the external network and not lose his changes when the VM stops. Change-Id: I027992f52c35add0afd1ffe207b1adbdb2c5c957 Bug-Url: https://bugzilla.redhat.com/1013491 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 8 files changed, 96 insertions(+), 52 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I027992f52c35add0afd1ffe207b1adbdb2c5c957 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: create osinfo windows product keys from db
by iheim＠redhat.com 11 Oct '13

11 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: create osinfo windows product keys from db ...................................................................... packaging: setup: create osinfo windows product keys from db This patch introduces a script that pulls ProductKey* values from db to osinfo repository on engine-setup (as the db values are no longer used). Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174 Bug-Url: https://bugzilla.redhat.com/1012330 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/config/productkey_upgrade.py 3 files changed, 101 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Kill the agent if three subsequent requests fail
by gpadgett＠redhat.com 11 Oct '13

11 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: Kill the agent if three subsequent requests fail ...................................................................... Kill the agent if three subsequent requests fail Change-Id: Ia5ec6935673133af2e60f339b035dba3438b617f Bug-Url: https://bugzilla.redhat.com/1008505 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py 2 files changed, 16 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5ec6935673133af2e60f339b035dba3438b617f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: CPU pinning disappearing
by iheim＠redhat.com 11 Oct '13

11 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: CPU pinning disappearing ...................................................................... webadmin: CPU pinning disappearing - Fixed issue where CPU pinning value would not be displayed properly due to the order in cpu pinning visibility was set. The visibility depends on the migration mode which was set after it is used to determine the visibility of the CPU pinning. This moves the setting of the CPU after the setting of the migration mode. Change-Id: I1c87f65b2fc2d7434e6785291bd73fee15539faa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1004014 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c87f65b2fc2d7434e6785291bd73fee15539faa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: create osinfo windows product keys from db
by sbonazzo＠redhat.com 11 Oct '13

11 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: create osinfo windows product keys from db ...................................................................... packaging: setup: create osinfo windows product keys from db This patch introduces a script that pulls ProductKey* values from db to osinfo repository on engine-setup (as the db values are no longer used). Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174 Bug-Url: https://bugzilla.redhat.com/1012330 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/config/productkey_upgrade.py 3 files changed, 101 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : gluster volume rebalance status and start time fo...
by kmayilsa＠redhat.com 10 Oct '13

10 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : gluster volume rebalance status and start time formatting ...................................................................... webadmin : gluster volume rebalance status and start time formatting Earlier the start and status time of volume rebalance was not shown in a correct format.Now,it is displayed in the appropriate format. Change-Id: I8897a9aa141120fe5e9011167e7a1d14a24c4852 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011878 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java 2 files changed, 25 insertions(+), 16 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8897a9aa141120fe5e9011167e7a1d14a24c4852 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0