October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: firewall: override iptables configuration
by sbonazzo＠redhat.com 09 Oct '13

09 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: firewall: override iptables configuration ...................................................................... packaging: firewall: override iptables configuration Previously iptables configuration was not overridden when the host was added to the engine. Now override_iptables is specified when adding the host. Requiring iptables also on systems with FirewallD because the engine still doesn't support FirewallD. Change-Id: I03b0bc75dcbdc92d6f430e3a11d0549a3f0172c0 Bug-Url: https://bugzilla.redhat.com/1014616 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/firewall_manager.py 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03b0bc75dcbdc92d6f430e3a11d0549a3f0172c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: firewall: override iptables configuration
by sbonazzo＠redhat.com 09 Oct '13

09 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: firewall: override iptables configuration ...................................................................... packaging: firewall: override iptables configuration Previously iptables configuration was not overridden when the host was added to the engine. Now override_iptables is specified when adding the host. Requiring iptables also on systems with FirewallD because the engine still doesn't support FirewallD. Change-Id: I03b0bc75dcbdc92d6f430e3a11d0549a3f0172c0 Bug-Url: https://bugzilla.redhat.com/1014616 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/firewall_manager.py 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03b0bc75dcbdc92d6f430e3a11d0549a3f0172c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: mark GetVirtioScsiControllers as user query
by derez＠redhat.com 09 Oct '13

09 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: core: mark GetVirtioScsiControllers as user query ...................................................................... core: mark GetVirtioScsiControllers as user query Marking GetVirtioScsiControllers query as VdcQueryAuthType.User since it's being used by the user portal. Change-Id: I268b39bc85525a270998c10b67c2463a45a08a26 Bug-Url: https://bugzilla.redhat.com/1016826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVirtioScsiControllersQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 8 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I268b39bc85525a270998c10b67c2463a45a08a26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi, engine: Support network name in update nic
by iheim＠redhat.com 09 Oct '13

09 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi,engine: Support network name in update nic ...................................................................... restapi,engine: Support network name in update nic The network name and the port mirroring flag provided by the restapi for updating a vnic name should be respected. In this case the vnic profile id will be ignored. In addition, the patch allows to set 'null' value for the vnic profile id, which is treated as unlinking the nic from the network: <nic> <vnic_profile/> </nic> This patch designed for backward compatibility only of the add/update vm nic. Change-Id: I1f5c96daf64f6e14cc76bfb12daf89618f656b3d Bug-Url: https://bugzilla.redhat.com/1011116 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmInterfaceParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateInterfaceParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java 8 files changed, 112 insertions(+), 14 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f5c96daf64f6e14cc76bfb12daf89618f656b3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: add missing disk.export() descriptors
by iheim＠redhat.com 09 Oct '13

09 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: add missing disk.export() descriptors ...................................................................... restapi: add missing disk.export() descriptors This patch is adding restapi rsdl metadata leftovers for the "import/export images from/to Glance" feature Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990962 Change-Id: I61136522a018d3633182a00f1a70e70ec00f6480 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 24 insertions(+), 12 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61136522a018d3633182a00f1a70e70ec00f6480 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Webadmin - Incorrect error message when selecting multiple H...
by yzaslavs＠redhat.com 09 Oct '13

09 Oct '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Webadmin - Incorrect error message when selecting multiple Hosts from different DCs and openging a report ...................................................................... Webadmin - Incorrect error message when selecting multiple Hosts from different DCs and openging a report when selecting multiple Hosts from different DCs and openging a report Via webadmin. An incorrect error message is displayed "Please select reports from the same data center" The message should be rephrased "Please select Hosts from the same data center" Change-Id: If65b6790383840bbebb08a147902dcc3b9f18d04 Bug-Url: https://bugzilla.redhat.com/885983 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/ReportPresenterWidget.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65b6790383840bbebb08a147902dcc3b9f18d04 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: broker: use direct I/O to read metadata
by gpadgett＠redhat.com 09 Oct '13

09 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: broker: use direct I/O to read metadata ...................................................................... broker: use direct I/O to read metadata In some cases a host's filesystem cache may hold stale data from parts of the shared metadata file not updated by that host. This can lead to the host falsely concluding that other hosts are down. Using direct I/O for the read operations avoids this problem by fetching the latest data directly from the NFS server. Change-Id: I296977000ffa3fff3f9391f93a8b4f3f519eae4e Bug-Url: https://bugzilla.redhat.com/1014241 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/constants.py.in M ovirt_hosted_engine_ha/broker/storage_broker.py 2 files changed, 25 insertions(+), 26 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I296977000ffa3fff3f9391f93a8b4f3f519eae4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: clear snapshot_id from floating disks script
by iheim＠redhat.com 09 Oct '13

09 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: clear snapshot_id from floating disks script ...................................................................... core: clear snapshot_id from floating disks script Clearing snapshot_id from floating disks upgrade script. Change-Id: Ifa0863a7338e22d7fbb96766937edfe28881ad57 Bug-Url: https://bugzilla.redhat.com/1015170 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- A packaging/dbscripts/upgrade/03_03_0940_clear_snapshot_id_of_floating_disks.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa0863a7338e22d7fbb96766937edfe28881ad57 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: RemoveVM - clear snapshot_id from detached disks
by iheim＠redhat.com 09 Oct '13

09 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: RemoveVM - clear snapshot_id from detached disks ...................................................................... core: RemoveVM - clear snapshot_id from detached disks Clearing snapshot_id from detached disk images when removing a VM. Change-Id: I03fe42fd16067ceda87027b96948e746d0045229 Bug-Url: https://bugzilla.redhat.com/1015170 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03fe42fd16067ceda87027b96948e746d0045229 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: clearing snapshot_id on disk detach
by iheim＠redhat.com 09 Oct '13

09 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: clearing snapshot_id on disk detach ...................................................................... core: clearing snapshot_id on disk detach When detaching a DiskImage, the snapshot [1] ID should be cleared. Otherwise, 'DiskImageDAO -> getAllSnapshotsForVmSnapshot' returns floating DiskImages (which shouldn't be taken into account in any flow since they're not relevant with regards to snapshots). Note: when attaching a DiskImage, the snapshot ID is already updated properly according to the VM. [1] only an active snapshot since detaching a disk with snapshots is blocked at canDo phase. Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3 Bug-Url: https://bugzilla.redhat.com/1015170 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad60d2a6500f4bd738095949c7e36a4ec34122c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0