October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: InitVdsOnUp - flow fixes
by amureini＠redhat.com 06 Oct '13

06 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: InitVdsOnUp - flow fixes ...................................................................... core: InitVdsOnUp - flow fixes 1. If the master domain is inactive/unknown - a host shouldn't fail this phase of the flow if it respondes to getVdsStats. 2. If the master domain is inactive/unknown - the host shouldn't fail the flow according to it's domain report. Examples for relevant scenarios: 1. When there are no active hosts, all the domains are marked as "unknown", if we will attempt to activate a host and it won't be able to connect to the pool because of VDS_NETWORK_ERROR, the host won't move to UP because of the check of it's domain report. 2. When there are no active hosts and a host is being activated, successfully connects to the pool and it can't see any of the domains it won't move to UP because of it's domain report. Change-Id: I61fcc58be133efdecf264c22015609f6ee3ed942 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 19 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61fcc58be133efdecf264c22015609f6ee3ed942 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi, engine: Support network name in update nic
by masayag＠redhat.com 06 Oct '13

06 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi,engine: Support network name in update nic ...................................................................... restapi,engine: Support network name in update nic The network name and the port mirroring flag provided by the restapi for updating a vnic name should be respected. In this case the vnic profile id will be ignored. In addition, the patch allows to set 'null' value for the vnic profile id, which is treated as unlinking the nic from the network: <nic> <vnic_profile/> </nic> This patch designed for backward compatibility only of the add/update vm nic. Change-Id: I1f5c96daf64f6e14cc76bfb12daf89618f656b3d Bug-Url: https://bugzilla.redhat.com/1011116 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmInterfaceParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateInterfaceParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java 8 files changed, 112 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f5c96daf64f6e14cc76bfb12daf89618f656b3d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add test for mac address format
by masayag＠redhat.com 06 Oct '13

06 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Add test for mac address format ...................................................................... core: Add test for mac address format The patch adds a unit test to cover the used patterns list for verifying the correct format of a mac address. Change-Id: I74c6c310be787a1bea81f9d344d91e80f48cdc2b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MacAddressPatternTest.java 2 files changed, 70 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74c6c310be787a1bea81f9d344d91e80f48cdc2b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: stop and warn if setup is not run as root ...
by ydary＠redhat.com 06 Oct '13

06 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: stop and warn if setup is not run as root user. ...................................................................... packaging: setup: stop and warn if setup is not run as root user. Change-Id: I4aeb4cc80d4ddab8bfdd0c3717ba3c3763ab3b41 Bug-Url: https://bugzilla.redhat.com/853957 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aeb4cc80d4ddab8bfdd0c3717ba3c3763ab3b41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fall-through in PolicyUnitImpl
by amureini＠redhat.com 06 Oct '13

06 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fall-through in PolicyUnitImpl ...................................................................... core: Fall-through in PolicyUnitImpl Fixed the faulty (unintended) fall-through in PolicyUnitImpl.getPolicyUnitImpl(PolicyUnit). Change-Id: I404f40a1ec2478ae2ef843ce5454cf717dfbb25c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/19894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I404f40a1ec2478ae2ef843ce5454cf717dfbb25c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: stop and notify if setup is not run as root
by ydary＠redhat.com 06 Oct '13

06 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: stop and notify if setup is not run as root ...................................................................... packaging: setup: stop and notify if setup is not run as root Change-Id: Id1a46f817cad72bd0de7752a2a90db3d3fe77512 Bug-Url: https://bugzilla.redhat.com/853955 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1a46f817cad72bd0de7752a2a90db3d3fe77512 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: make ctrl-c breaking the command rather than existing s...
by mpastern＠redhat.com 06 Oct '13

06 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: make ctrl-c breaking the command rather than existing shell #869269 ...................................................................... cli: make ctrl-c breaking the command rather than existing shell #869269 Change-Id: Ia6b9020bb8b8177d018dac08e1734c681603445e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=869269 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6b9020bb8b8177d018dac08e1734c681603445e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: fix cluster creating in guide
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: fix cluster creating in guide ...................................................................... webadmin: fix cluster creating in guide When creating a cluster in the datacenter guide, policy units configuretion was not saved. added missing policy unit mapping from ClusterModel to VDSGroup Change-Id: I7cc47558a06e4e0c000219ab2b8b34d9fac9f5a8 Bug-Url: https://bugzilla.redhat.com/1001182 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cc47558a06e4e0c000219ab2b8b34d9fac9f5a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Don't add VNICs to a VM by default
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Don't add VNICs to a VM by default ...................................................................... webadmin: Don't add VNICs to a VM by default VNICs used to be added to VMs created from VNIC-less templates by default, to accommodate assigning some sort of network connection to a VM when creating it. This is no longer needed, as VNICs can now be added and removed by the user in the same dialog. Change-Id: I2d00fd6a4fb280d9604bc1ae586fcc588d4a7196 Bug-Url: https://bugzilla.redhat.com/1003779 Bug-Url: https://bugzilla.redhat.com/1009298 Bug-Url: https://bugzilla.redhat.com/1010856 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 15 insertions(+), 36 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d00fd6a4fb280d9604bc1ae586fcc588d4a7196 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Add/Remove VNICs in Add/Edit VM dialog
by iheim＠redhat.com 06 Oct '13

06 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add/Remove VNICs in Add/Edit VM dialog ...................................................................... webadmin: Add/Remove VNICs in Add/Edit VM dialog Enabled adding/removing VNICs in the VM dialogs using AddRemoveRowWidget. Change-Id: Id7654d137541aec64ce19aa309021b307253171e Bug-Url: https://bugzilla.redhat.com/1003779 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 9 files changed, 197 insertions(+), 117 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7654d137541aec64ce19aa309021b307253171e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0