October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: build: ovirt-hosted-engine-ha-0.1.0-0.4.beta1
by gpadgett＠redhat.com 29 Oct '13

29 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-0.1.0-0.4.beta1 ...................................................................... build: ovirt-hosted-engine-ha-0.1.0-0.4.beta1 Change-Id: Iefa13d4e76c186f3aeea4ad3bb8ed41a0099a34d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M configure.ac M ovirt-hosted-engine-ha.spec.in 3 files changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefa13d4e76c186f3aeea4ad3bb8ed41a0099a34d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add no-arg constructor to AddInternalJobParameters
by vszocs＠redhat.com 29 Oct '13

29 Oct '13

Vojtech Szocs has submitted this change and it was merged. Change subject: core: Add no-arg constructor to AddInternalJobParameters ...................................................................... core: Add no-arg constructor to AddInternalJobParameters This is required in order to avoid potential serialization issues with GWT RPC. Change-Id: Ic6d6ac2db61e8336b419a036033248a8b4f380c6 Bug-Url: https://bugzilla.redhat.com/1015683 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddInternalJobParameters.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6d6ac2db61e8336b419a036033248a8b4f380c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Remove vNIC items changed listener before flush
by lvernia＠redhat.com 29 Oct '13

29 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove vNIC items changed listener before flush ...................................................................... webadmin: Remove vNIC items changed listener before flush Upon flushing the AddRemoveRowWidget, it sets the backing ListModel's items according to the entries in the widget. However, in the add/edit VM dialog, since it is listening on the items changed event, this re-initializes the widget just before it closes, thus adding a new vNIC row. This patch moves the listening logic into ProfilesInstanceTypeEditor and removes the listener prior to flushing the widget, in order to avoid that flicker. Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22 Bug-Url: https://bugzilla.redhat.com/1020755 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 2 files changed, 38 insertions(+), 17 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: add send ctrl-alt-delete to spice-html5 client
by tjelinek＠redhat.com 29 Oct '13

29 Oct '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: add send ctrl-alt-delete to spice-html5 client ...................................................................... frontend: add send ctrl-alt-delete to spice-html5 client Change-Id: I4b13044e742275b32fd9965ceaf9ba09c6976529 Bug-Url: https://bugzilla.redhat.com/1014069 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/ovirt-engine-spicehtml5-main.html 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b13044e742275b32fd9965ceaf9ba09c6976529 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: possible NPE in UpdateVmDisk
by amureini＠redhat.com 29 Oct '13

29 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: possible NPE in UpdateVmDisk ...................................................................... core: possible NPE in UpdateVmDisk During UpdateVmDisk command, if the disk doesn't exist anymore in the db the private commands lists won't be initialized causing to NPE on getSharedLocks() method. Change-Id: I787b4a9e723e3096b5d22a5a925cd976940497ff Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I787b4a9e723e3096b5d22a5a925cd976940497ff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: show remove brick status on stop remove birck
by kmayilsa＠redhat.com 29 Oct '13

29 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: show remove brick status on stop remove birck ...................................................................... webadmin: show remove brick status on stop remove birck Showing the status of data migartion after stoping the remove brick operation. Change-Id: Ic29a668ac56d3a5fbab0a3bb553dfe511d5902f4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024227 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/20634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic29a668ac56d3a5fbab0a3bb553dfe511d5902f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix for stop/status rebalance issue
by kmayilsa＠redhat.com 29 Oct '13

29 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Fix for stop/status rebalance issue ...................................................................... webadmin: Fix for stop/status rebalance issue This patch fixes following bugs. 1. Showing volume names on the stop rebalance confimation dialog 2. Cancel button not working stop rebalance confirmation Change-Id: Ia0c6a8fdc6a74134cf2fccec11e941d151355a92 Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=1021334 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/20632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0c6a8fdc6a74134cf2fccec11e941d151355a92 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: bin: add --set-maintenance to hosted-engine
by sbonazzo＠redhat.com 29 Oct '13

29 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: bin: add --set-maintenance to hosted-engine ...................................................................... bin: add --set-maintenance to hosted-engine Add support for --set-maintenance=local|global|none to hosted-engine command. Change-Id: If2e07a4ac57268a18523a3119d60b10021f36cfa Bug-Url: https://bugzilla.redhat.com/1020858 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/set_maintenance.py 4 files changed, 88 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2e07a4ac57268a18523a3119d60b10021f36cfa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: bin: add --set-maintenance to hosted-engine
by sbonazzo＠redhat.com 29 Oct '13

29 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: bin: add --set-maintenance to hosted-engine ...................................................................... bin: add --set-maintenance to hosted-engine Add support for --set-maintenance=local|global|none to hosted-engine command. Change-Id: If2e07a4ac57268a18523a3119d60b10021f36cfa Bug-Url: https://bugzilla.redhat.com/1020858 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/set_maintenance.py 4 files changed, 88 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2e07a4ac57268a18523a3119d60b10021f36cfa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: temporarily drop host score upon enexpected VM shutdown
by gpadgett＠redhat.com 29 Oct '13

29 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: agent: temporarily drop host score upon enexpected VM shutdown ...................................................................... agent: temporarily drop host score upon enexpected VM shutdown When the agent detects that the engine VM is shut down unexpectedly, it will lower the score to encourage the VM to start on a different host. This is an optimization to assist the user in putting a host into maintenance mode more quickly. If it is used in this manner, the user should remember to enable host maintenance mode, else the score will eventually revert to its usual number and the host may re-acquire the engine VM. Change-Id: If11d561a39cc9723ffdd55836db693fc2aad0575 Bug-Url: https://bugzilla.redhat.com/1015724 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/lib/util.py 3 files changed, 39 insertions(+), 7 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If11d561a39cc9723ffdd55836db693fc2aad0575 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0