November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Only check IPv4 addresses for FQDN
by sbonazzo＠redhat.com 27 Nov '13

27 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Only check IPv4 addresses for FQDN ...................................................................... packaging: setup: Only check IPv4 addresses for FQDN Bug-Url: https://bugzilla.redhat.com/1009990 Change-Id: I4f4bffdb083755c60704f436a24a960848fbd056 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/hostname.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f4bffdb083755c60704f436a24a960848fbd056 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.3]: build: post ovirt-image-uploader-3.3.2
by sbonazzo＠redhat.com 27 Nov '13

27 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-image-uploader-3.3.2 ...................................................................... build: post ovirt-image-uploader-3.3.2 Change-Id: If0459a8cdf11ec68fe6a30977ed596dff4f10938 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0459a8cdf11ec68fe6a30977ed596dff4f10938 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.3]: build: ovirt-image-uploader-3.3.2
by sbonazzo＠redhat.com 27 Nov '13

27 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-image-uploader-3.3.2 ...................................................................... build: ovirt-image-uploader-3.3.2 Change-Id: Ie58c4d84f89920d17b00af7900a7f70d249e5bb5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-image-uploader.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie58c4d84f89920d17b00af7900a7f70d249e5bb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.3]: build: post ovirt-iso-uploader-3.3.2
by sbonazzo＠redhat.com 27 Nov '13

27 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-iso-uploader-3.3.2 ...................................................................... build: post ovirt-iso-uploader-3.3.2 Change-Id: I98265389cf18552feda37ee2e394f1f2a0a69f44 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98265389cf18552feda37ee2e394f1f2a0a69f44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.3]: build: ovirt-iso-uploader-3.3.2
by sbonazzo＠redhat.com 27 Nov '13

27 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-iso-uploader-3.3.2 ...................................................................... build: ovirt-iso-uploader-3.3.2 Change-Id: Ia99c7e321a159f66c069ecb635b1d6d37c64fdfe Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia99c7e321a159f66c069ecb635b1d6d37c64fdfe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: NPE on new/edit pool
by tjelinek＠redhat.com 27 Nov '13

27 Nov '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: NPE on new/edit pool ...................................................................... webadmin: NPE on new/edit pool If no DC was up, the new/edit dialog pool failed on NPE. Similar issue was also on the new/edit VM - fixed the same way. Change-Id: Ia94ec0d89f3304597cce5187a1f449dc5fbfd6ed Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 2 files changed, 21 insertions(+), 15 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia94ec0d89f3304597cce5187a1f449dc5fbfd6ed Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Add no-argument constructor check
by iheim＠redhat.com 27 Nov '13

27 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Add no-argument constructor check ...................................................................... core: Add no-argument constructor check This patch adds NoArgConstructorCheck to ensure all classes in backend common module have no-argument constructor (with any access modifier), unless excluded via checkstyle-suppressions.xml file. Added public no-argument constructor to all Parameters classes. Added classes unrelated to GWT RPC mechanism (and therefore irrelevant for this check) into checkstyle-suppressions.xml file. Change-Id: Ia4f9a00d6289374b433ed4419552420a3337da50 Bug-Url: https://bugzilla.redhat.com/1029605 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DownloadImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVmDiskSizeVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FullListVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDevicesVisibilityVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskAlignmentVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskImageAlignmentVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDiskLunAlignmentVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmStatsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MomPolicyVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SnapshotVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmNicDeviceVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/AddGlusterServerVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateGlusterVolumeVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHookVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServiceVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActionVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeAdvancedDetailsVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksActionVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeOptionVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRebalanceVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeRemoveBricksVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumesListVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/RemoveGlusterServerVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ReplaceGlusterVolumeBrickActionVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/ResetGlusterVolumeOptionsVDSParameters.java A build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M build-tools-root/checkstyles/src/main/resources/checkstyle.xml A build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoArgConstructorCheck.java M pom.xml 37 files changed, 169 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit http://gerrit.ovirt.org/21733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4f9a00d6289374b433ed4419552420a3337da50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Add no-arg constructor to Parameters classes
by iheim＠redhat.com 27 Nov '13

27 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Add no-arg constructor to Parameters classes ...................................................................... core: Add no-arg constructor to Parameters classes This is required in order to avoid potential serialization issues with GWT RPC. Change-Id: I54a256a7a9c36485630740d82bc0393561f9516a Bug-Url: https://bugzilla.redhat.com/1029605 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalEventParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalJobParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalStepParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GetDiskAlignmentParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveExternalEventParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAuditLogByIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsForStorageOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsByJobIdQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDiskQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDisksQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmFromConfigurationQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SignStringParameters.java 23 files changed, 70 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit http://gerrit.ovirt.org/21732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a256a7a9c36485630740d82bc0393561f9516a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to lowercase in SchedulingManager
by gchaplik＠redhat.com 27 Nov '13

27 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: rename method to lowercase in SchedulingManager ...................................................................... core: rename method to lowercase in SchedulingManager Change-Id: I9ac3f31b6ffd2d291be6d48342827f47f7093df7 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ac3f31b6ffd2d291be6d48342827f47f7093df7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: CommonPoolWithVms.isVmPoolNameValidLength
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: CommonPoolWithVms.isVmPoolNameValidLength ...................................................................... core: CommonPoolWithVms.isVmPoolNameValidLength Patch 540a75e0f7bc4b9ed879471d3d830d575c6d6060 removed the last usage of CommonVmsPoolWithVmsCommand.isVmPoolNameValidLength(String), so now this method should be removed too. Instead, use VmCommand.isVmNameValidLength(VM). Change-Id: Ide5f59bf24cf2562a0cd69f97bc4224a4660e556 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 0 insertions(+), 33 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide5f59bf24cf2562a0cd69f97bc4224a4660e556 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0