November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: provider: IllegalStateException in getCowVirtualSize
by iheim＠redhat.com 07 Nov '13

07 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: provider: IllegalStateException in getCowVirtualSize ...................................................................... provider: IllegalStateException in getCowVirtualSize Since JBoss 7.3 (httpclient 4.2) closing an InputStream might also trigger IllegalStateException. As we were already catching IOException we should now catch IllegalStateException too. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1022569 Change-Id: I20b816c49e60763f4f5b930f309365c0c770e1cd Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/OpenStackImageProviderProxy.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Verified Itamar Heim: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21003 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20b816c49e60763f4f5b930f309365c0c770e1cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: improve dwhd service handling
by ydary＠redhat.com 07 Nov '13

07 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: improve dwhd service handling ...................................................................... packaging: setup: improve dwhd service handling The new implementation adds dwhd service to init levels using chkconfig call, also updates the stopping/starting it similar to engine and postgres services. Change-Id: I8c31f2cc75a5f4805bd53da1ffc23c71cf856bc6 Bug-Url: https://bugzilla.redhat.com/1022550 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c31f2cc75a5f4805bd53da1ffc23c71cf856bc6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: fix DB detection and owner from previous v...
by ydary＠redhat.com 07 Nov '13

07 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix DB detection and owner from previous versions ...................................................................... packaging: setup: fix DB detection and owner from previous versions Change-Id: Ic2fe256660b233bc682dc22e79cf58d34c546c3a Bug-Url: https://bugzilla.redhat.com/1015859 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 89 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Verified Yaniv Dary: Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2fe256660b233bc682dc22e79cf58d34c546c3a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename methods to lowercase in VdsManager
by tnisan＠redhat.com 07 Nov '13

07 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods to lowercase in VdsManager ...................................................................... core: rename methods to lowercase in VdsManager Change-Id: Ied6ca9cf5c785487c27f9dad2da16216c378dbf4 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/UpdateVmDynamicDataVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 6 files changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied6ca9cf5c785487c27f9dad2da16216c378dbf4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix coverity FORWARD_NULL reported error
by masayag＠redhat.com 07 Nov '13

07 Nov '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix coverity FORWARD_NULL reported error ...................................................................... engine: Fix coverity FORWARD_NULL reported error Change-Id: I75678478b93078d7d76d45798323e2d200c09540 Bug-Url: https://bugzilla.redhat.com/1024209 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75678478b93078d7d76d45798323e2d200c09540 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Clear few eclipse warnings
by masayag＠redhat.com 07 Nov '13

07 Nov '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Clear few eclipse warnings ...................................................................... engine: Clear few eclipse warnings Change-Id: Ic157218e286586a448013019b01912918b5ff606 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic157218e286586a448013019b01912918b5ff606 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Improve import vm message when profile not found
by masayag＠redhat.com 07 Nov '13

07 Nov '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Improve import vm message when profile not found ...................................................................... engine: Improve import vm message when profile not found If a vnic profile cannot be found while importing a vm to the system, the message should include that warning. In addition, the network name should be printed only once. Change-Id: I2099756b3ff9c07a6c121a3601b8c7d1d5811e38 Bug-Url: https://bugzilla.redhat.com/1004386 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2099756b3ff9c07a6c121a3601b8c7d1d5811e38 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename methods to lowercase in VdcEventNotificationUtils
by tnisan＠redhat.com 07 Nov '13

07 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods to lowercase in VdcEventNotificationUtils ...................................................................... core: rename methods to lowercase in VdcEventNotificationUtils Change-Id: I15a6ac6cca84e6498d8336bf8ea57e9f97b63dac Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15a6ac6cca84e6498d8336bf8ea57e9f97b63dac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Enable vNIC profile fields independently of version
by lvernia＠redhat.com 07 Nov '13

07 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Enable vNIC profile fields independently of version ...................................................................... webadmin: Enable vNIC profile fields independently of version Always enable the port mirroring and custom properties fields of the vNIC profile dialog, independently of the DC compatibility version. The vNIC profile is a DC-level entity and there could be clusters inside the DC that do have a high enough compatibility version, so the version compatibility should not be enforced here. Change-Id: Id3f942133f752f91a601b305191749832efcf6f6 Bug-Url: https://bugzilla.redhat.com/1023952 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 2 files changed, 23 insertions(+), 43 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3f942133f752f91a601b305191749832efcf6f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Small refactoring to simplify VnicProfileModel
by lvernia＠redhat.com 07 Nov '13

07 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Small refactoring to simplify VnicProfileModel ...................................................................... webadmin: Small refactoring to simplify VnicProfileModel It wasn't really clear what exactly dcId and dcCompatibilityVersion were affecting, whereas customPropertiesVisible was passed around as a parameter when it really should only be set when the VnicProfileModel is constructed. Also theoretically improved the behavior of selecting a QoS configuration from the list. Currently when editing a network the DC can't be changed, but if that is enabled in the future, then if the DC will be switched and then switched back, the original QoS selection will be salvaged. Change-Id: I8e98a1fc26ce6b32076e09a67e6a3d82f52964df Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 2 files changed, 29 insertions(+), 22 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e98a1fc26ce6b32076e09a67e6a3d82f52964df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0