November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: change while loop to foreach
by amureini＠redhat.com 07 Nov '13

07 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: change while loop to foreach ...................................................................... core: change while loop to foreach Change-Id: Id2d68bc5ae15226a5e1005d91f1218546990d225 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2d68bc5ae15226a5e1005d91f1218546990d225 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix vm checks in LiveMigrateVmDisksCommand
by amureini＠redhat.com 07 Nov '13

07 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix vm checks in LiveMigrateVmDisksCommand ...................................................................... core: fix vm checks in LiveMigrateVmDisksCommand Change-Id: I36dae8623c99fcb1f93b59eb7461bd06a1f429fe Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36dae8623c99fcb1f93b59eb7461bd06a1f429fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix upgrade from 3.3 to 3.4
by amureini＠redhat.com 07 Nov '13

07 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix upgrade from 3.3 to 3.4 ...................................................................... core: fix upgrade from 3.3 to 3.4 The script 03_03_0950_change_policy_names.sql was added in change http://gerrit.ovirt.org/#/c/18645/ , this upgrade script hasn't been backported to the 3.3 branch, thus when upgrading from 3.3 to 3.4 it won't be applied. Change-Id: Ie6b14486d615adadca6e5013c2be575b471edca9 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0110_change_policy_names.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6b14486d615adadca6e5013c2be575b471edca9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: MoveOrCopyDiskCommand - reduce query count
by amureini＠redhat.com 07 Nov '13

07 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: MoveOrCopyDiskCommand - reduce query count ...................................................................... core: MoveOrCopyDiskCommand - reduce query count When loading the vms for a disk, the vm device information is already loaded - therefore there's no need to filter it out and then reload it for each vm, we can use the values that were loaded during the first query execution. Change-Id: Ic4b15114bc72dc07de917692b60703008008ae13 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 2 files changed, 23 insertions(+), 29 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4b15114bc72dc07de917692b60703008008ae13 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Fix method names in AsyncDataProvider to lowercase
by tnisan＠redhat.com 07 Nov '13

07 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: Fix method names in AsyncDataProvider to lowercase ...................................................................... Fix method names in AsyncDataProvider to lowercase Change-Id: Ifc67f252e482fdba5395cb1dc9d481b0f96301fd Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/HostNetworkProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java 7 files changed, 11 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/20940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc67f252e482fdba5395cb1dc9d481b0f96301fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to lowercase in FenceVdsVDSComand
by tnisan＠redhat.com 07 Nov '13

07 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to lowercase in FenceVdsVDSComand ...................................................................... core: rename method to lowercase in FenceVdsVDSComand Change-Id: I03a0d9645dc4a794a5cd416234e42618bece06e8 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03a0d9645dc4a794a5cd416234e42618bece06e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to lowercase in GetVGListVDSCommand
by tnisan＠redhat.com 07 Nov '13

07 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to lowercase in GetVGListVDSCommand ...................................................................... core: rename method to lowercase in GetVGListVDSCommand Change-Id: Id431e7ce074b43a674bac8beabddb4c5a73525b8 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id431e7ce074b43a674bac8beabddb4c5a73525b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename method to lowercase in RemoveUserCommand
by tnisan＠redhat.com 07 Nov '13

07 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method to lowercase in RemoveUserCommand ...................................................................... core: rename method to lowercase in RemoveUserCommand Change-Id: I00b3132b60ae3be9b9f2e47db3698027bb95c2e5 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveUserCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00b3132b60ae3be9b9f2e47db3698027bb95c2e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename methods in GetDeviceListVDSCommand to lowercase
by tnisan＠redhat.com 07 Nov '13

07 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods in GetDeviceListVDSCommand to lowercase ...................................................................... core: rename methods in GetDeviceListVDSCommand to lowercase Change-Id: Icff34cd6a37ec92681547398839da8b8ce2e66b6 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java 3 files changed, 11 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icff34cd6a37ec92681547398839da8b8ce2e66b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add dash - before every item in the remove brick c...
by kmayilsa＠redhat.com 07 Nov '13

07 Nov '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: add dash - before every item in the remove brick confirmation pop up ...................................................................... webadmin: add dash - before every item in the remove brick confirmation pop up Adding a dash (-) before every item in the remove brick confirmation pop up Change-Id: I65d43615162ea1274207e49fefcbb270d707d79c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024734 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickPopupView.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/20742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65d43615162ea1274207e49fefcbb270d707d79c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0