November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: quota permissions isn't enforced in add VM
by gchaplik＠redhat.com 06 Nov '13

06 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: quota permissions isn't enforced in add VM ...................................................................... core: quota permissions isn't enforced in add VM When creating a VM or one of the command's derivatives (add VM from .., etc.), a consume quota check should be performed on the designated quota, Currently when creating a VM, there isn't any permission check on that quota, the check if performed only if the quota is consumed (i.e running a vm). Also when running a VM there shouldn't be any quota permission check. Change-Id: I421ac8019cf16cc6f2a18ce6b4bcbcbf83397225 Bug-Url: https://bugzilla.redhat.com/1020201 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I421ac8019cf16cc6f2a18ce6b4bcbcbf83397225 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove unused variable
by gchaplik＠redhat.com 06 Nov '13

06 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: remove unused variable ...................................................................... core: remove unused variable Change-Id: I9f50f2e1d8948abbde6353482ac685e570e92686 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDaoTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f50f2e1d8948abbde6353482ac685e570e92686 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Create DB Scripts - incompatible code...
by ofrenkel＠redhat.com 06 Nov '13

06 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Create DB Scripts - incompatible code... ...................................................................... core: Create DB Scripts - incompatible code... Create DB Scripts - incompatible code breaking dwh cross compatibility Moving update sequences code to a custom function that can overridden by the history module. Change-Id: Ic36b48458b6a924ad62d14666b8d31e53e9854e1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026097 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/dbcustomfunctions.sh M packaging/dbscripts/dbfunctions.sh 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic36b48458b6a924ad62d14666b8d31e53e9854e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change required permissions for removing VM from expor...
by ofrenkel＠redhat.com 06 Nov '13

06 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: change required permissions for removing VM from export domain ...................................................................... core: change required permissions for removing VM from export domain This patch changes the permissions which are required for removing a VM from export domain. Until now, the user had to have import-export permissions on the VM in order to be able to remove it from the export domain - It was problematic in case the VM which is going to be removed doesn't exist in the system. >From now on, we require 'delete vm' permissions on the export domain in order to be able to remove VMs from the export domain, which makes it possible for everyone who has 'delete vm' permissions on the export domain to remove those VMs, also in case they don't exist in the DB. Change-Id: I9f63cc6e53cd082d011bbef72c6a9435b6c1620b Bug-Url: https://bugzilla.redhat.com/1010963 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 10 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f63cc6e53cd082d011bbef72c6a9435b6c1620b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix ClassCastException while attempting to detach di...
by amureini＠redhat.com 06 Nov '13

06 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Fix ClassCastException while attempting to detach direct LUN ...................................................................... engine: Fix ClassCastException while attempting to detach direct LUN Engine mistakenly trying to update VM snapshot id on direct LUN and fails with ClassCastException. This patch restores code checking the type of the disk before updating snapshot id. Change-Id: I2b60d19f8832392d6f2df5cb05552560b7e10d1c Bug-Url: https://bugzilla.redhat.com/1026920 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b60d19f8832392d6f2df5cb05552560b7e10d1c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: wrong memory overcommit unit
by dfediuck＠redhat.com 06 Nov '13

06 Nov '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: wrong memory overcommit unit ...................................................................... webadmin: wrong memory overcommit unit in cluster general info sub tab, Max Memory Over Commitment unit is MB, and should be % Change-Id: Ie572092251bc5d5a87f9734f18194389cf1fbe29 Bug-Url: https://bugzilla.redhat.com/1021326 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie572092251bc5d5a87f9734f18194389cf1fbe29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget
by lvernia＠redhat.com 06 Nov '13

06 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget ...................................................................... webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget This to promote a uniform look between these similar widgets, as well as code reuse. Change-Id: If66c23bddada57fbfd95292dc2cc1f6c8d9df19e Bug-Url: https://bugzilla.redhat.com/1025288 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml 9 files changed, 178 insertions(+), 176 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If66c23bddada57fbfd95292dc2cc1f6c8d9df19e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added Linq method containsByIdentity
by lvernia＠redhat.com 06 Nov '13

06 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added Linq method containsByIdentity ...................................................................... webadmin: Added Linq method containsByIdentity To be used for checking whether a specific item exists in a collection by reference (==) rather than by value (equals()). Change-Id: I68361e35955879efe4185c5a47d6cbcb48fd1987 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68361e35955879efe4185c5a47d6cbcb48fd1987 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix visual regression in Setup Networks
by lvernia＠redhat.com 06 Nov '13

06 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix visual regression in Setup Networks ...................................................................... webadmin: Fix visual regression in Setup Networks When refactoring I caused the required/non-required labels to disappear, this fixes it. Change-Id: If6ca63f1140c5519425fac7910a35127f367da4b Bug-Url: https://bugzilla.redhat.com/1026225 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java 1 file changed, 15 insertions(+), 9 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6ca63f1140c5519425fac7910a35127f367da4b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disks tab - add listeners on presenter
by derez＠redhat.com 05 Nov '13

05 Nov '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disks tab - add listeners on presenter ...................................................................... webadmin: disks tab - add listeners on presenter Adding disk type (All/Image/LUN) change event lister on 'MainTabDiskPresenter -> onReveal' in order to ensure listener subscription (currently, since the listeners are added in the view, it might get cleared upon staling the list model). Change-Id: I0a0e76d5c21c1420232b12a6cbf2d65ff2851c09 Bug-Url: https://bugzilla.redhat.com/1019659 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 2 files changed, 29 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a0e76d5c21c1420232b12a6cbf2d65ff2851c09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0