November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: root: cleanup: remove tabs from web.xml
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: root: cleanup: remove tabs from web.xml ...................................................................... root: cleanup: remove tabs from web.xml Change-Id: Ie3308ca928c077c12f15361e3ba2f50bb6baa2b1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3308ca928c077c12f15361e3ba2f50bb6baa2b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: EngineEncryptionUtils: java7 cleanup
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: utils: EngineEncryptionUtils: java7 cleanup ...................................................................... utils: EngineEncryptionUtils: java7 cleanup Change-Id: Idb5b83c9e11f206738b063e4b25f7c307922314e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java 1 file changed, 1 insertion(+), 12 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb5b83c9e11f206738b063e4b25f7c307922314e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: add Closeable interface to our objects
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: host-deploy: add Closeable interface to our objects ...................................................................... host-deploy: add Closeable interface to our objects Change-Id: Iae58c623eb1f3acabe2404022b9bdbae32095bbb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/CommandTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/PropertiesTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TimeoutTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java 16 files changed, 251 insertions(+), 218 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae58c623eb1f3acabe2404022b9bdbae32095bbb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: pki: fixed subject usage
by sbonazzo＠redhat.com 04 Nov '13

04 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: pki: fixed subject usage ...................................................................... pki: fixed subject usage Fixed the env variable to be used while generating the spice pki certificate. Change-Id: I3e48c691ca59df430dea64785c6f5ac62531a9ad Bug-Url: https://bugzilla.redhat.com/1025259 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/pki/vdsmpki.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e48c691ca59df430dea64785c6f5ac62531a9ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: use try-with-resources
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: host-deploy: use try-with-resources ...................................................................... host-deploy: use try-with-resources Change-Id: I1e7530f1c4f19f450527aaecc4b73608b5c81683 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java 4 files changed, 144 insertions(+), 220 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e7530f1c4f19f450527aaecc4b73608b5c81683 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: handle bridge on additional hosts
by sbonazzo＠redhat.com 04 Nov '13

04 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: handle bridge on additional hosts ...................................................................... packaging: setup: handle bridge on additional hosts Previously on an additional host hosted-engine-setup checked for ip addr of the bridge instead of the ip addr of any existing device. But on additional host the bridge creation is done by the manager when adding the host. Enabled the NIC selection for bridge creation also on additional hosts if the bridge is not found and use its ip Bug-Url: https://bugzilla.redhat.com/1025253 Change-Id: I81a5edada72d397c3ce30410d903840b1392034e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 2 files changed, 28 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81a5edada72d397c3ce30410d903840b1392034e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: fix ssh test suite for stderr
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: host-deploy: fix ssh test suite for stderr ...................................................................... host-deploy: fix ssh test suite for stderr Change-Id: I1057b16d63ed66bb889f6d985cf24539236c7237 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1057b16d63ed66bb889f6d985cf24539236c7237 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: LocalConfig: reduce message severity if file is missing
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: utils: LocalConfig: reduce message severity if file is missing ...................................................................... utils: LocalConfig: reduce message severity if file is missing it is valid to have purely default without any configuration. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020675 Change-Id: If597acaf41049392a24d59549034af9e09c7616e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If597acaf41049392a24d59549034af9e09c7616e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: build: optionally use pep8 and pyflakes
by sbonazzo＠redhat.com 04 Nov '13

04 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: optionally use pep8 and pyflakes ...................................................................... packaging: build: optionally use pep8 and pyflakes Change-Id: I4d8f6b009f6c5bf1ccd7b1cde48d8474e5e47340 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer M build/python-check.sh.in 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d8f6b009f6c5bf1ccd7b1cde48d8474e5e47340 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: devenv: remove dbscripts before installing
by emesika＠redhat.com 04 Nov '13

04 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: packaging: build: devenv: remove dbscripts before installing ...................................................................... packaging: build: devenv: remove dbscripts before installing this will avoid sql dups when installed multiple times Change-Id: I49775301283a2900b51fed42563c92b2d1923a2a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49775301283a2900b51fed42563c92b2d1923a2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0