December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove pending VMs counting
by ofrenkel＠redhat.com 02 Dec '13

02 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove pending VMs counting ...................................................................... core: remove pending VMs counting The number of pending VMs is not in use anywhere, but it is still computed. In order to compute the pending VMs we increment and decrement the counter while running VMs in synchronized blocks and it is not good in terms of performance. So since this code is redundant, it is better to remove it. Change-Id: I3bd7a757be2979b86227ce56064e6165080035eb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 0 insertions(+), 24 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bd7a757be2979b86227ce56064e6165080035eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Reinitialize VDSManager on change cluster
by iheim＠redhat.com 02 Dec '13

02 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Reinitialize VDSManager on change cluster ...................................................................... engine: Reinitialize VDSManager on change cluster When changing cluster, the VDSManager dictionary has to be updated. This is needed because the target cluster may support different services from the source cluster, and the monitoring strategies need to be updated. Change-Id: Icb25c12d35113af09c67d5fe6e275c6901725e54 Bug-Url: https://bugzilla.redhat.com/968178 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sahina Bose: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb25c12d35113af09c67d5fe6e275c6901725e54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Reinitialize VDSManager on change cluster
by kmayilsa＠redhat.com 02 Dec '13

02 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Reinitialize VDSManager on change cluster ...................................................................... engine: Reinitialize VDSManager on change cluster When changing cluster, the VDSManager dictionary has to be updated. This is needed because the target cluster may support different services from the source cluster, and the monitoring strategies need to be updated. Change-Id: Icb25c12d35113af09c67d5fe6e275c6901725e54 Bug-Url: https://bugzilla.redhat.com/968178 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/21855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb25c12d35113af09c67d5fe6e275c6901725e54 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: event message for rebalance and remove brick complete
by kmayilsa＠redhat.com 02 Dec '13

02 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: event message for rebalance and remove brick complete ...................................................................... gluster: event message for rebalance and remove brick complete A suitable event message will be displayed when rebalance is completed in a volume and when data migration for brick removal is complete. Change-Id: If4da9730cd8c251bc5707df981204b092948fb6f bug url: https://bugzilla.redhat.com/show_bug.cgi?id=1015016 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties A packaging/dbscripts/upgrade/03_04_0150_gluster_async_tasks_finished_event_map.sql 9 files changed, 49 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Darshan N: Verified -- To view, visit http://gerrit.ovirt.org/21080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4da9730cd8c251bc5707df981204b092948fb6f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Hide commands when specific provider is chosen
by iheim＠redhat.com 01 Dec '13

01 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Hide commands when specific provider is chosen ...................................................................... webadmin: Hide commands when specific provider is chosen When a specific provider is chosen in the system tree, the add/remove commands will now be hidden. Change-Id: I27246a01e72fb70735888e38fcf5db3442cfba0d Bug-Url: https://bugzilla.redhat.com/987999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27246a01e72fb70735888e38fcf5db3442cfba0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by derez＠redhat.com 01 Dec '13

01 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors ...................................................................... frontend: ignore in findbugs EventArgs unconfirmed cast errors Ignore in findbugs errors related to casting EventArgs. The casting is safe in this case, and a future refactoring will make findbug warning resolved in any case.(RFE #1034844) This is the fourth patch following http://gerrit.ovirt.org/#/c/21847/ Change-Id: I011253855bddbc34a1c306f6084bd8fc12c154d2 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml 1 file changed, 85 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I011253855bddbc34a1c306f6084bd8fc12c154d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disk dialog - VirtIO-SCSI availability hint
by derez＠redhat.com 01 Dec '13

01 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disk dialog - VirtIO-SCSI availability hint ...................................................................... webadmin: disk dialog - VirtIO-SCSI availability hint Add/Edit disk dialog: When VirtIO-SCSI is supported by the cluster but disabled for the VM, display an info icon next to Interface dialog (with hinting that VirtIO-SCSI can be enabled from Resource Allocation tab on VM dialog). Change-Id: I9a2bd43de2adb0e85d3848042622fdce69e07ac0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 4 files changed, 57 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a2bd43de2adb0e85d3848042622fdce69e07ac0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing restore.sh help syntax.
by emesika＠redhat.com 01 Dec '13

01 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing restore.sh help syntax. ...................................................................... core: fixing restore.sh help syntax. Change-Id: Ic19dae61d01fdf679aaee9b869caef2eef7e92cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1030806 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/restore.sh 1 file changed, 17 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic19dae61d01fdf679aaee9b869caef2eef7e92cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: wabadmin: snapshots sub-tab - sort info tabs
by derez＠redhat.com 01 Dec '13

01 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: wabadmin: snapshots sub-tab - sort info tabs ...................................................................... wabadmin: snapshots sub-tab - sort info tabs VMs -> Snapshots sub-tab: sort disks/nics info tabs. Change-Id: I5d917a721915e5243790a37eefc0d00594b993f4 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java 2 files changed, 18 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d917a721915e5243790a37eefc0d00594b993f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: snapshots sub-tab - info on active vm
by derez＠redhat.com 01 Dec '13

01 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: snapshots sub-tab - info on active vm ...................................................................... webadmin: snapshots sub-tab - info on active vm VMs -> Snapshots sub-tab: As GetVmConfigurationBySnapshot query already supports retrieving information for active snapshot, update snapshot info tab when selecting 'Active VM' snapshot. Change-Id: I1327b8787cc1f07227247ded8b6d3a32baf8ef7a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 4 files changed, 57 insertions(+), 117 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1327b8787cc1f07227247ded8b6d3a32baf8ef7a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0