May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add validations to provider commands
by mkolesni＠redhat.com 20 May '13

20 May '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add validations to provider commands ...................................................................... engine: Add validations to provider commands Added validations to the Add/Update/Remove commands for providers. Change-Id: I09d2b74718f8d04e5f28fd622658ff11636ee74e Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/ProviderValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProviderParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Provider.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 272 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d2b74718f8d04e5f28fd622658ff11636ee74e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added ability to query provider by name
by mkolesni＠redhat.com 20 May '13

20 May '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added ability to query provider by name ...................................................................... engine: Added ability to query provider by name Provider should be nameable and query-able by it's name. Change-Id: If6188c6f0cc2c0e9f4dbb3eb366dbefefd50ec76 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/dbscripts/providers_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Provider.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/provider/ProviderDaoTest.java 6 files changed, 57 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12364 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6188c6f0cc2c0e9f4dbb3eb366dbefefd50ec76 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added provider CRUD operations
by mkolesni＠redhat.com 20 May '13

20 May '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added provider CRUD operations ...................................................................... engine: Added provider CRUD operations Added all CRUD operations on providers. Currently implementation is naive, but it will be improved in the future. Change-Id: Ifa74c2adb7d755f5b916629cec415d56461bbb13 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/GetAllProvidersQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ProviderParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 8 files changed, 160 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa74c2adb7d755f5b916629cec415d56461bbb13 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added provider table & DAO
by mkolesni＠redhat.com 20 May '13

20 May '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added provider table & DAO ...................................................................... engine: Added provider table & DAO Added table to hold external providers and also DAO that will allow to manipulate them. Change-Id: Iaa461cb6721b866c0a6f6531365c8af4d46eb1bb Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/dbscripts/providers_sp.sql A backend/manager/dbscripts/upgrade/03_03_0150_add_providers_table.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/provider/ProviderDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 8 files changed, 278 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa461cb6721b866c0a6f6531365c8af4d46eb1bb Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added Provider class
by mkolesni＠redhat.com 20 May '13

20 May '13

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Added Provider class ...................................................................... core: Added Provider class This class will contain the information of an external provider. Change-Id: I67e42286f513cf47dd057a6078ea365d6dff24e9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Provider.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 211 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e42286f513cf47dd057a6078ea365d6dff24e9 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: introduce VM status PrepareForHibernate
by ofrenkel＠redhat.com 20 May '13

20 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: introduce VM status PrepareForHibernate ...................................................................... core: introduce VM status PrepareForHibernate This patch adds status for VM that reflects the state in which the VM is going to be hibernated but vdsm didn't start to save the memory state yet. When starting the hibernate command, this is the first status to be set fot the vm, then the images which are going to be used are created, and only when the 'hibernate' verb in the vdsm is called and vdsm reports back that it starts to do the migration to the file, the VM status will be changed to SavingState. Change-Id: Iebc8e0a7cd4b21e751393304ceee65d668d84ca4 Bug-Url: https://bugzilla.redhat.com/949281 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 8 files changed, 60 insertions(+), 46 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebc8e0a7cd4b21e751393304ceee65d668d84ca4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: change wording of hover message for Ct...
by tjelinek＠redhat.com 20 May '13

20 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal, webadmin: change wording of hover message for Ctrl-Alt-Del passing ...................................................................... userportal, webadmin: change wording of hover message for Ctrl-Alt-Del passing Change-Id: I4d1f59dcebe331d256f2c6d9d5c5bc1b4aaf8e93 Bug-Url: https://bugzilla.redhat.com/964249 Signed-off-by: Michal Skrivanek <michal.skrivanek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d1f59dcebe331d256f2c6d9d5c5bc1b4aaf8e93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unused Disk and LunDisk c'tors
by amureini＠redhat.com 20 May '13

20 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed unused Disk and LunDisk c'tors ...................................................................... core: Removed unused Disk and LunDisk c'tors Non-default Disk c'tor is only used by LunDisk non-default c'tor, which is not used at all. Hence both are now removed, as are the now-useless default c'tors. Change-Id: Ie1740ea1f198b75ef4cceed2ecd3fb8dc53c44c2 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java 2 files changed, 0 insertions(+), 60 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1740ea1f198b75ef4cceed2ecd3fb8dc53c44c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing template with disks ends with unused data in ...
by amureini＠redhat.com 20 May '13

20 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removing template with disks ends with unused data in the db ...................................................................... core: Removing template with disks ends with unused data in the db When removing a template, the records of its disks weren't deleted from base_disks table because the call to the delete stored procedure was done with the id of the image rather then the id of the disk - which caused to unused records to be left in the table and possible errors when trying to import the template again (not as a clone). Change-Id: I86573e91885085bcdfc30ee4e966590901a62067 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/14877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86573e91885085bcdfc30ee4e966590901a62067 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: reduce compensation scope from hibernate command
by ofrenkel＠redhat.com 20 May '13

20 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: reduce compensation scope from hibernate command ...................................................................... core: reduce compensation scope from hibernate command This patch reduce the scope in which the compensation that is defined to switch the VM status back to UP is set in the execute stage of the hibernate vm command. The compensation context is cleared when the first task is created (in transaction) - there's no need to keep the compensation anymore since we don't want the status of the VM to switch to UP while tasks that were created as part of the hibernate command exist. Note: this is only part of the solution for the bug mentioned below. Change-Id: Iec46798fc6ea01ef6b0b4701e1af5ba616edf910 Bug-Url: https://bugzilla.redhat.com/949281 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 2 files changed, 59 insertions(+), 32 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec46798fc6ea01ef6b0b4701e1af5ba616edf910 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0