May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: ignore: Method might ignore exception
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Method might ignore exception ...................................................................... findbugs: ignore: Method might ignore exception Change-Id: Id1b56c036f2899d8ac53b7dd8e863e16e63429ae Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml A backend/manager/tools/exclude-filters.xml M backend/manager/tools/pom.xml 4 files changed, 36 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1b56c036f2899d8ac53b7dd8e863e16e63429ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Validating DB encoding during setup
by juan.hernandez＠redhat.com 13 May '13

13 May '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Validating DB encoding during setup ...................................................................... packaging: Validating DB encoding during setup This patch adds a DB encoding validation during setup on remote DBs. There's no need to validate the default encoding on local installation because on local installation we perform initdb, which creates template1 (and, as result other DBs created within) with a default desired encoding utf8. Change-Id: I583b115cf60142cafc5ba66b0dc22e92b4807c84 Bug-Url: https://bugzilla.redhat.com/920565 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py M packaging/setup/plugins/ovirt-engine-setup/db/connection.py 4 files changed, 76 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I583b115cf60142cafc5ba66b0dc22e92b4807c84 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: added space between protocol and edit button
by tjelinek＠redhat.com 13 May '13

13 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: added space between protocol and edit button ...................................................................... userportal: added space between protocol and edit button Details of the basic view, there was no space between the protocol type and the edit button. Added 5px. Change-Id: I81832b613edd85af8605aea74c71cf8f2ccb1729 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.ui.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81832b613edd85af8605aea74c71cf8f2ccb1729 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Use Set instead of List for serviceNames
by sanjal＠redhat.com 13 May '13

13 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Use Set instead of List for serviceNames ...................................................................... gluster: Use Set instead of List for serviceNames Use Set instead of List for serviceNames in GlusterServicesListVDSParameters Change-Id: I26109a71448968fea0055c3d2df3c843e23d70f3 Signed-off-by: Shireesh Anjal <anjalshireesh(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26109a71448968fea0055c3d2df3c843e23d70f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Unwritten field
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Unwritten field ...................................................................... findbugs: Unwritten field Change-Id: I4095a8157c06070cb3fdc40d0f6749faf1e7b737 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4095a8157c06070cb3fdc40d0f6749faf1e7b737 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Possible double check of field
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Possible double check of field ...................................................................... findbugs: ignore: Possible double check of field Change-Id: I7e9956f27af23191ce6e5e6869d8120af9e12b91 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/pom.xml A backend/manager/modules/utils/exclude-filters.xml M backend/manager/modules/utils/pom.xml 4 files changed, 25 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e9956f27af23191ce6e5e6869d8120af9e12b91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: usertportal: Console buttons are still active after VM is la...
by tjelinek＠redhat.com 13 May '13

13 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: usertportal: Console buttons are still active after VM is launched. ...................................................................... usertportal: Console buttons are still active after VM is launched. After spice console connecting/disconnecting in extended usertportar view, the ui state of the console buttons was not updated. This behavior is reproducible since patch 09f1acafa2a508f90ea9a7a77f79693d8e8224d6 in upstream. The problem was in not comparing console state in the logic that was responsible for deciding whether to refresh the view. Fixed by adding check for console state change (console username). Change-Id: I6b260c338dbc2f1156f00732842caf59d7fd1bb2 Bug-Url: https://bugzilla.redhat.com/951666 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/14641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b260c338dbc2f1156f00732842caf59d7fd1bb2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Call to static DateFormat
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Call to static DateFormat ...................................................................... findbugs: ignore: Call to static DateFormat Change-Id: Ia5b73279230455d7b4ddeb57f97e36cf420abe38 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A backend/manager/modules/dal/exclude-filters.xml M backend/manager/modules/dal/pom.xml 2 files changed, 30 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b73279230455d7b4ddeb57f97e36cf420abe38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Possible null pointer dereference
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Possible null pointer dereference ...................................................................... findbugs: ignore: Possible null pointer dereference Change-Id: I310aed3ed02ff3683506b07f1a2155e9830f7893 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I310aed3ed02ff3683506b07f1a2155e9830f7893 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: Boolean return value should not return nul...
by shavivi＠redhat.com 13 May '13

13 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: Boolean return value should not return null ...................................................................... findbugs: ignore: Boolean return value should not return null Change-Id: I90f16b1b5941aadcb2c7488500ce63eb2bf57436 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A frontend/webadmin/modules/webadmin/exclude-filters.xml M frontend/webadmin/modules/webadmin/pom.xml 2 files changed, 41 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90f16b1b5941aadcb2c7488500ce63eb2bf57436 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0