May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: pki: move configuration from vdc_options to configuration fi...
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: move configuration from vdc_options to configuration files ...................................................................... pki: move configuration from vdc_options to configuration files root application serves pki resources, in order to support variable location we need to be able to access these without accessing the database. in addition, there is no point in storing file locations within database, as if we use cluster we have no grantee to have these at the other node. handling the root application is not included in this patch. Change-Id: I1764d9ca7a8c677401f721b3d89f45deff9c1f26 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/config_devel.sql M backend/manager/dbscripts/encryptionvalidator.sh M backend/manager/dbscripts/upgrade/03_01_1440_encrypt_chap_password.sh M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCACertificateQueryTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdsDeployTest.java D backend/manager/modules/bll/src/test/resources/ca/certs/ca.pem M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java M packaging/conf/engine-config-install.properties M packaging/conf/engine.conf.defaults.in M packaging/etc/engine-config/engine-config.properties M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 29 files changed, 182 insertions(+), 330 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1764d9ca7a8c677401f721b3d89f45deff9c1f26 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: root: serve root customizable location resources
by yzaslavs＠redhat.com 06 May '13

06 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: root: serve root customizable location resources ...................................................................... root: serve root customizable location resources resources are hard coded within root's web.xml, while in development mode and in different distributions locations may be altered. this change resolves resource name contained variables at ${xxx} notation using LocalConfig. Change-Id: I94f845d36bb075c238e50606187bc22316713cdd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/FileServlet.java M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M ovirt-engine.spec.in M packaging/conf/engine.conf.defaults.in 6 files changed, 23 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f845d36bb075c238e50606187bc22316713cdd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: entity snapshot valiadation
by lhornyak＠redhat.com 06 May '13

06 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: entity snapshot valiadation ...................................................................... engine: entity snapshot valiadation This patch adds a validation to the snapshot mechanism. If there is no DAO for the entity's class, then the rollback mechanism will not be able to roll it back, therefore it is be better to fail the transaction before the compensating transaction tryes and fails to handle the snapshot. Change-Id: Ibf28a6d3dd389ab303d2d482e25b94dab4dbafdd Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf28a6d3dd389ab303d2d482e25b94dab4dbafdd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: runVmCommandParams: remove get/setInternalExecution
by gchaplik＠redhat.com 06 May '13

06 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: runVmCommandParams: remove get/setInternalExecution ...................................................................... core: runVmCommandParams: remove get/setInternalExecution AuditLogableBase.isInternalExecution() can be used instead (implemented TODO in code). Change-Id: I225cd8808f5b780f5e79a41b29143eca3d8b711e Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java 2 files changed, 5 insertions(+), 22 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I225cd8808f5b780f5e79a41b29143eca3d8b711e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: unify validations for pools and run VM
by gchaplik＠redhat.com 06 May '13

06 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: unify validations for pools and run VM ...................................................................... core: unify validations for pools and run VM And adjust run vm tests. Using shared code for pre-started pools and run vm command validations Change-Id: Ia5063a8ae840ee27736722015480748ece048337 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 3 files changed, 36 insertions(+), 52 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5063a8ae840ee27736722015480748ece048337 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: runVmCommand.canDoAction clean up (13)
by gchaplik＠redhat.com 06 May '13

06 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: runVmCommand.canDoAction clean up (13) ...................................................................... core: runVmCommand.canDoAction clean up (13) - Vm status validtion - Removal of RunVmHandler Change-Id: I6e2ca6ca3d1410f857591956a6e2b50dde3153dc Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 6 files changed, 19 insertions(+), 125 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e2ca6ca3d1410f857591956a6e2b50dde3153dc Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: runVmCommand.canDoAction clean-up (12)
by gchaplik＠redhat.com 06 May '13

06 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: runVmCommand.canDoAction clean-up (12) ...................................................................... core: runVmCommand.canDoAction clean-up (12) move vdsSelector validation to the command itself Change-Id: Ia048045389c5388022b5023233192a503cb3902a Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 5 files changed, 12 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia048045389c5388022b5023233192a503cb3902a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RunVmCommand.canDoAction clean-up (11)
by gchaplik＠redhat.com 06 May '13

06 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: RunVmCommand.canDoAction clean-up (11) ...................................................................... core: RunVmCommand.canDoAction clean-up (11) Handle stateless vm. Change-Id: Ie887a05e17dd6a59b4e5d2df83a9aa7e357526dc Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 6 files changed, 181 insertions(+), 151 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie887a05e17dd6a59b4e5d2df83a9aa7e357526dc Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RunVmCommand.canDoAction clean-up (10)
by gchaplik＠redhat.com 06 May '13

06 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: RunVmCommand.canDoAction clean-up (10) ...................................................................... core: RunVmCommand.canDoAction clean-up (10) validate host status (vm.status = paused + vds.status != up) Change-Id: I7b3273a88e9d5da2aad4aeafb99a6f414560085e Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 4 files changed, 26 insertions(+), 15 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b3273a88e9d5da2aad4aeafb99a6f414560085e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RunVmCommand.canDoAction clean-up (9)
by gchaplik＠redhat.com 06 May '13

06 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: RunVmCommand.canDoAction clean-up (9) ...................................................................... core: RunVmCommand.canDoAction clean-up (9) extract vmDuringInitialization and add tests Change-Id: I2b595b419ac6f4c6b42eecef9f8f8f62b11d0eaf Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java 5 files changed, 83 insertions(+), 37 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b595b419ac6f4c6b42eecef9f8f8f62b11d0eaf Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0