June 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Fixing a bug preventing daemons from regaining DB connectivi...
by yzaslavs＠redhat.com 16 Jun '13

16 Jun '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Fixing a bug preventing daemons from regaining DB connectivity ...................................................................... Fixing a bug preventing daemons from regaining DB connectivity If db connectivity is down, closeConnection in checkConnection will set connection null. From that point on, on each call to checkConnectivity a NPE will be thrown. Fix: If connection is null attempt to open it, this way: 1.) if db goes back up we will regain connectivity. 2.) if db does not come back up we will have a proper sqlException in the log thrown from openConnection, and not a NPE. Change-Id: Ia8dc7eb95e055e793f51155cd4024ebf5ce1914a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=973534 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8dc7eb95e055e793f51155cd4024ebf5ce1914a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: reuse code in StorageListModel
by derez＠redhat.com 16 Jun '13

16 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: reuse code in StorageListModel ...................................................................... webadmin: reuse code in StorageListModel Reuse handling of existing storage domains in StorageListModel by extracting the code to a separate method. Change-Id: I6f7d66790659150abd358a2cf00410c7fa3bd6a0 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 13 insertions(+), 24 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f7d66790659150abd358a2cf00410c7fa3bd6a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: move image group command
by mlipchuk＠redhat.com 16 Jun '13

16 Jun '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: move image group command ...................................................................... core: move image group command Added MoveImageGroupCommand - making MoveOrCopyImageGroup command to be used for copy only (CopyImageGroup). Reasons for that change: 1. When moving an image and attempting to delete with wipe - the operation will be faster rather then waiting for the wipe to complete. 2. Moving towards lowering the SPM involvement in the copy/move process. 3. The engine will be able to tell on which part of the "move" operation an error has occured. 4. Move operation on vdsm should be deprecated. Known issues and reasoning: * The whole operation might be slower for moving image groups without wipe as the delete part is quick (and now we will have two vdsm calls rather then one) - this issue is known and accepted as part of this RFE. Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706 Bug-Url: https://bugzilla.redhat.com/753549 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageDbOperationScope.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 20 files changed, 157 insertions(+), 48 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/13042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: reorder super constructor invocation in ordereddict
by mpastern＠redhat.com 16 Jun '13

16 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: reorder super constructor invocation in ordereddict ...................................................................... sdk: reorder super constructor invocation in ordereddict this way lock objects will be available for any type of the dict initialization Change-Id: I0e63d81f2de810de334e4944f9004f9d14aa9877 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/utils/ordereddict.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e63d81f2de810de334e4944f9004f9d14aa9877 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: reuse updateStorageDomain in StorageListModel
by derez＠redhat.com 16 Jun '13

16 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: reuse updateStorageDomain in StorageListModel ...................................................................... webadmin: reuse updateStorageDomain in StorageListModel Reuse updateStorageDomain code in StorageListModel by extracting it to a separate method instead of duplicating it as it is today. Change-Id: Ie9c28c751237876f85df360cf29dc8e1d16e4a77 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 14 insertions(+), 35 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c28c751237876f85df360cf29dc8e1d16e4a77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: reuse command creation in StorageListModel
by derez＠redhat.com 16 Jun '13

16 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: reuse command creation in StorageListModel ...................................................................... webadmin: reuse command creation in StorageListModel Reuse UICommand creation (OK, Cancel, etc) in StorageListModel by extracting it to separate methods. Change-Id: Ib3dc143c78ddb7371b7e2ec77f3b6600391b470d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 31 insertions(+), 46 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3dc143c78ddb7371b7e2ec77f3b6600391b470d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Correcting nfs service (nfs-server) name for Fedo...
by juan.hernandez＠redhat.com 16 Jun '13

16 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Correcting nfs service (nfs-server) name for Fedora ...................................................................... packaging: Correcting nfs service (nfs-server) name for Fedora The current service name "nfs-service" is wrong. The consequence is nfs service not being started by engine-setup. This patch fixes the nfs servie name to "nfs-server", the correct name for Fedora. Change-Id: Idb273004e6123b2ed771eec19c986eb0f84de957 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=974633 Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb273004e6123b2ed771eec19c986eb0f84de957 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in otopi[master]: packaging: setup: handle a yum error when no groups
by Alon Bar-Lev 15 Jun '13

15 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: setup: handle a yum error when no groups ...................................................................... packaging: setup: handle a yum error when no groups apparently, when querying yum for group, if no groups at all it raises an exception instead of return empty set. this is unexpected behavior of an api. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=973383 Change-Id: Ifb1f196006662d6571c7ca80554e0a9a17aaec2a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15746 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb1f196006662d6571c7ca80554e0a9a17aaec2a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: gwt draft build support
by derez＠redhat.com 14 Jun '13

14 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: packaging: build: gwt draft build support ...................................................................... packaging: build: gwt draft build support Change-Id: I90e52c7880a5b403937c3b179db6ea39e35fd2e7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M README.developer 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90e52c7880a5b403937c3b179db6ea39e35fd2e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: enhance gwt-debug target
by derez＠redhat.com 14 Jun '13

14 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: build: enhance gwt-debug target ...................................................................... build: enhance gwt-debug target 1. add dev build flags to maven execution. 2. set default application port to 8080. Change-Id: I3b2d466b0bef36483f4a688f98eb603d67b2dc8e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Reported-By: Daniel Erez <derez(a)redhat.com> --- M Makefile M frontend/webadmin/modules/pom.xml 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b2d466b0bef36483f4a688f98eb603d67b2dc8e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0