July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: move Trusted Service to ClusterModel
by gchaplik＠redhat.com 18 Jul '13

18 Jul '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: move Trusted Service to ClusterModel ...................................................................... webadmin: move Trusted Service to ClusterModel ClusterPolicyModel is being removed, hence moving the logic behind 'Enable Trusted Service' into the parent model. Change-Id: If8c85d6321cc9f60eecfcdf4b7ae719581c5e90a Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 4 files changed, 32 insertions(+), 30 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8c85d6321cc9f60eecfcdf4b7ae719581c5e90a Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove permission check for released quota
by gchaplik＠redhat.com 18 Jul '13

18 Jul '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: remove permission check for released quota ...................................................................... core: remove permission check for released quota Removed the permission check for released quota. A user should be able to release a quota even he is not a consumer of that quota. Change-Id: Iec530af23b1e6d41aa9b97ff6337fd4eb48d947a Bug-Url: https://bugzilla.redhat.com/965622 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec530af23b1e6d41aa9b97ff6337fd4eb48d947a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixes RTE while reorder LDAP servers list
by yzaslavs＠redhat.com 18 Jul '13

18 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixes RTE while reorder LDAP servers list ...................................................................... core: Fixes RTE while reorder LDAP servers list Fixes RuntimeException appearing on LDAP servers list reordering. The exception prevents user from login if the first LDAP server on list wasn't been available. Change-Id: Idc52415ca123790e967e0f1b940fdedb4987097a Bug-Url: https://bugzilla.redhat.com/973566 Bug-Url: https://bugzilla.redhat.com/974148 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/serverordering/LdapServersOrderingAlgorithm.java 2 files changed, 16 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc52415ca123790e967e0f1b940fdedb4987097a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent removing vm from export domain while it is bei...
by ofrenkel＠redhat.com 18 Jul '13

18 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: prevent removing vm from export domain while it is being imported ...................................................................... core: prevent removing vm from export domain while it is being imported While VM is being imported from export domain, there was no kind of lock that prevented other commands from modifing the VM. So while the import operation was on progress, the user could remove the VM which is obviously something we need to prevent. This patch prevents the scenario above from happening by modify the ImportVmCommand to take shared lock on the VM at the export domain for the whole execution of the command, and modify the RemoveVmFromImportExportCommand to take exclusive lock on the VM which is about to be removed. Change-Id: I5c34612f754375a9d15816e9972671e1b13023ad Bug-Url: https://bugzilla.redhat.com/733917 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 50 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c34612f754375a9d15816e9972671e1b13023ad Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Block setup of mgmt net for older clusters
by mkolesni＠redhat.com 18 Jul '13

18 Jul '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Block setup of mgmt net for older clusters ...................................................................... engine: Block setup of mgmt net for older clusters The old VDSMs don't work well when running setup networks right after install (3.1) or they don't have setup networks verb (3.0) so added FeatureSupported for this. Old cluster versions will have hosts installed the old way (using the ovirt-host-deploy method). Change-Id: I690063e7d3ae72b4791894dabc59a7b3a6cd6a44 Bug-Url: https://bugzilla.redhat.com/985027 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 5 files changed, 19 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I690063e7d3ae72b4791894dabc59a7b3a6cd6a44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Flush Neutron agent configuration when adding host
by alkaplan＠redhat.com 18 Jul '13

18 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Flush Neutron agent configuration when adding host ...................................................................... webadmin: Flush Neutron agent configuration when adding host Plugged-in the backend code for the Network Provider section in Add Host dialog. Also found out that QPID parameters aren't sent to the backend on host installation, so disabled the UI fields. Change-Id: I1b8d480a0913a0349298509f1a7770ddb0f03bc7 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java 3 files changed, 24 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/17068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b8d480a0913a0349298509f1a7770ddb0f03bc7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixed buggy validation of NeutronAgentModel
by alkaplan＠redhat.com 18 Jul '13

18 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fixed buggy validation of NeutronAgentModel ...................................................................... webadmin: Fixed buggy validation of NeutronAgentModel Half the fields were disregarded even if they weren't valid, and the host validation was actually too harsh (but since its result wasn't regarded, it didn't block creation of providers). Change-Id: Ia6f258fb7a95a9de4b5bd2d4b71c2f8327bb1dcc Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/HostAddressValidation.java 2 files changed, 10 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6f258fb7a95a9de4b5bd2d4b71c2f8327bb1dcc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Plugged Neutron agent backend code to frontend
by alkaplan＠redhat.com 18 Jul '13

18 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Plugged Neutron agent backend code to frontend ...................................................................... webadmin: Plugged Neutron agent backend code to frontend Flush NeutronAgentBehavior fields when adding or editing provider, init the fields from backend entity when editing existing provider. Change-Id: I4ae42d320a761567e49aade7f6e104366e7e19c9 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/EditProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 4 files changed, 41 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ae42d320a761567e49aade7f6e104366e7e19c9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added question mark to Import Networks dialog
by alkaplan＠redhat.com 18 Jul '13

18 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Added question mark to Import Networks dialog ...................................................................... webadmin: Added question mark to Import Networks dialog It explains the meaning of "Allow All" when importing a network. Change-Id: Ib5180f62ecbab5b9bad44559bf0a24950628c95a Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 2 files changed, 15 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5180f62ecbab5b9bad44559bf0a24950628c95a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed Provider main tab from System node
by alkaplan＠redhat.com 18 Jul '13

18 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Removed Provider main tab from System node ...................................................................... webadmin: Removed Provider main tab from System node The tab is only displayed under Providers/Provider nodes. Change-Id: I3076949d5a2e9dcc101a410090eee9cf1960a053 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3076949d5a2e9dcc101a410090eee9cf1960a053 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0