July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Added explanation to mappings format
by alkaplan＠redhat.com 18 Jul '13

18 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Added explanation to mappings format ...................................................................... webadmin: Added explanation to mappings format The explanation is shown as an InfoIcon tooltip. Change-Id: I8a8f45188a9d21a700c6c1caaa54196389caa005 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/InfoIcon.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/provider/NeutronAgentWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/provider/NeutronAgentWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java 7 files changed, 87 insertions(+), 41 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a8f45188a9d21a700c6c1caaa54196389caa005 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed Add/Edit Network logic
by alkaplan＠redhat.com 18 Jul '13

18 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fixed Add/Edit Network logic ...................................................................... webadmin: Fixed Add/Edit Network logic The implemented logic was only right when adding a new network, fixed it a little. Also, some small aesthetic changes. Change-Id: I192b0213a8b9207b69364677ddb6e59874240b60 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java 6 files changed, 46 insertions(+), 28 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I192b0213a8b9207b69364677ddb6e59874240b60 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixing NPE in case of endCommand failure
by yzaslavs＠redhat.com 18 Jul '13

18 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing NPE in case of endCommand failure ...................................................................... core: Fixing NPE in case of endCommand failure This is a suggestion on how to fix an NPE in CreateAllSnapshotFromVmCommand that is caused by network error at CreateSnapshotCommand (the child command). The network error causes transaction rollback and removal of the new snapshot entity (and making the old one non active). I had to create this patch in order to verify previous patches in this patchset. Bug-Url: https://bugzilla.redhat.com/982003 Change-Id: I78a617f43bd297db13b7dc9ad6649b67c773c144 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78a617f43bd297db13b7dc9ad6649b67c773c144 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Creating SPM task in failed state ...
by yzaslavs＠redhat.com 18 Jul '13

18 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Creating SPM task in failed state ... ...................................................................... core: Creating SPM task in failed state ... Creating SPM task in failed state in case of network error in create snapshot command Bug-Url: https://bugzilla.redhat.com/982003 Change-Id: I037f65b13eabffec39dbdc620a75c515e6ce796a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I037f65b13eabffec39dbdc620a75c515e6ce796a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add the ability to create a dummy task in case of VDSM...
by yzaslavs＠redhat.com 18 Jul '13

18 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Add the ability to create a dummy task in case of VDSM failure ...................................................................... core: Add the ability to create a dummy task in case of VDSM failure The following patch provides a helper method to create a dummy task in case there is VDSM failure when running asynchronous command. The dummy SPM task will be at ended stage, and the root command that causes all the tasks will fail (endWithFailure will be executed). Change-Id: I6e977596af52c81a1aed1b8748a30b9425c62fa3 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandMultiAsyncTasks.java 3 files changed, 22 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e977596af52c81a1aed1b8748a30b9425c62fa3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Install Openstack agents on the host
by mkolesni＠redhat.com 18 Jul '13

18 Jul '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Install Openstack agents on the host ...................................................................... engine: Install Openstack agents on the host The patch allows the user to provide an Openstack network provider, which according to its specific will install the agent on the host. Change-Id: Ib365bc5e7db9b0c1d070eb9182b554cd830e797d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/InstallVdsParameters.java M pom.xml 6 files changed, 169 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib365bc5e7db9b0c1d070eb9182b554cd830e797d Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.12-1
by mpastern＠redhat.com 18 Jul '13

18 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.12-1 ...................................................................... sdk: release 1.0.0.12-1 Change-Id: Ieae10e67771eb369e89f9f52705e7373631447c6 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieae10e67771eb369e89f9f52705e7373631447c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: build: update javadoc version
by mpastern＠redhat.com 18 Jul '13

18 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: build: update javadoc version ...................................................................... build: update javadoc version Change-Id: I8abb57d60fc85368a8a9210bbe7de47f5cccb0bd Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8abb57d60fc85368a8a9210bbe7de47f5cccb0bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: build: auto-generate and deploy javadoc
by mpastern＠redhat.com 18 Jul '13

18 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: build: auto-generate and deploy javadoc ...................................................................... build: auto-generate and deploy javadoc Change-Id: I70a896e71471ed7b3be3d7fb71d9b759070243e0 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70a896e71471ed7b3be3d7fb71d9b759070243e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add MemoryUtils#createMemoryStateString method
by ofrenkel＠redhat.com 18 Jul '13

18 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add MemoryUtils#createMemoryStateString method ...................................................................... core: add MemoryUtils#createMemoryStateString method The implementation of "RAM Snapshots" feature introduced new places where we need to create the string representation of memory state, besides HibernateVmCommand. This patch reduce the duplication of code that creates memory state string (the comma-separated string of IDs) by introducing a new utility method which is responsible for the String creation, and is now being called from all the relevant places. In addition, the changeStorageDomainAndPoolInMemoryVolume method in MemoryUtils class is renamed to changeStorageDomainAndPoolInMemoryState. Change-Id: Id1fe579cba2e86d95dc4689c38f195db1ea70eab Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java 5 files changed, 21 insertions(+), 10 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1fe579cba2e86d95dc4689c38f195db1ea70eab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0