July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: improve post zero check
by ofrenkel＠redhat.com 18 Jul '13

18 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: improve post zero check ...................................................................... core: improve post zero check This patch improves the check whether to use post zero or not when removing memory state images using MemoryImageRemover class: instead of filtering the list of disks to get all the disks which are marked with "wipe after delete" and then check if the list is not empty, we check whether one of the disks in the list is marked with "wipe after delete". This change has several benefits: 1. we don't have to go over all the items in the list everytime (only in the worst case, if no such disk exists in the list) 2. we don't need to create new list 3. the code is shorter and is more intuitive Change-Id: Id78a5b74748f5c174fd0fba70c95c40b66ff247f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id78a5b74748f5c174fd0fba70c95c40b66ff247f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: deploy: change spec summary
by mpastern＠redhat.com 18 Jul '13

18 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: deploy: change spec summary ...................................................................... deploy: change spec summary Change-Id: I9eabeb6a80cf212b684af22865c5e2d26a58b8b4 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9eabeb6a80cf212b684af22865c5e2d26a58b8b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: add comment field to Storage [5]
by lhornyak＠redhat.com 18 Jul '13

18 Jul '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: add comment field to Storage [5] ...................................................................... engine: add comment field to Storage [5] As part of the Free Text RFE Added to the entities flow in the system DB <-> DAO <-> Entity <-> Model <-> UI DB <-> DAO <-> Entity <-> REST Change-Id: I0fd8a1b83ed330c945025f13abf565fd899563e7 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDAODbFacadeImpl.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/storages_sp.sql A packaging/dbscripts/upgrade/03_03_0570_add_comment_storage_domain_static.sql 17 files changed, 86 insertions(+), 12 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fd8a1b83ed330c945025f13abf565fd899563e7 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: deploy: change spec summary
by mpastern＠redhat.com 18 Jul '13

18 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: deploy: change spec summary ...................................................................... deploy: change spec summary Change-Id: Iab484ef0139019572cea9a23a2ddeea02d255c47 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-python.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab484ef0139019572cea9a23a2ddeea02d255c47 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-dwh[master]: database: failed to create engine dwh db because of locale
by emesika＠redhat.com 18 Jul '13

18 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: database: failed to create engine dwh db because of locale ...................................................................... database: failed to create engine dwh db because of locale failed to create engine dwh db because of locale issue Patch follows the engine db creation http://gerrit.ovirt.org/#/c/12004/ Change-Id: Ifc86b1a8017b4bb481becb40a4341f749df55808 Signed-off-by: Humble Chirammal <hchiramm(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_db.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc86b1a8017b4bb481becb40a4341f749df55808 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: humble devassy <hchiramm(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com>

1 0

Change in otopi[master]: network: firewalld: allow disabling services
by Alon Bar-Lev 18 Jul '13

18 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: network: firewalld: allow disabling services ...................................................................... network: firewalld: allow disabling services Allows disabling services at closeup stage. Change-Id: I75418f4c7d90f8119c8259d0a33ed9fdfa69c91d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/otopi/constants.py M src/plugins/otopi/network/firewalld.py 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75418f4c7d90f8119c8259d0a33ed9fdfa69c91d Gerrit-PatchSet: 4 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: providers: add lost changes for glance support
by amureini＠redhat.com 18 Jul '13

18 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: providers: add lost changes for glance support ...................................................................... providers: add lost changes for glance support During rebase of I424998 the check to display the tenant field has been lost. This patch reintroduces the required code. Change-Id: I380664bab852707576a276e306c211bbbead4d5c Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Federico Simoncelli: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I380664bab852707576a276e306c211bbbead4d5c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: backward compatibility for cluster's scheduling pol...
by gchaplik＠redhat.com 18 Jul '13

18 Jul '13

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: backward compatibility for cluster's scheduling policy ...................................................................... restapi: backward compatibility for cluster's scheduling policy The engine implementation for cluster policy has changed, thus changing the cluster mapper to handle it, without breaking compatibility. * scheduling_policy_type will be mapped to cluster_policy_name and vice-versa. * thresholds will be mapped to properties map and vice-versa. * also, currently in case of 'none' policy, user will see: <scheduling_policy/> altered the mapper to show 'none' instead of empty entity. Change-Id: I4edd7313401670ca225b32d19dd7ad961ccd1b6a Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java 2 files changed, 40 insertions(+), 49 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4edd7313401670ca225b32d19dd7ad961ccd1b6a Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: spec: fixup httpcomponents dependencies
by mpastern＠redhat.com 18 Jul '13

18 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: spec: fixup httpcomponents dependencies ...................................................................... spec: fixup httpcomponents dependencies Change-Id: I0055d31341808c2d9c54fdde57448358878db6ca Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0055d31341808c2d9c54fdde57448358878db6ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: spec: re-add maven build
by mpastern＠redhat.com 18 Jul '13

18 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: spec: re-add maven build ...................................................................... spec: re-add maven build Change-Id: I02b6020b5bcf92137d20d10fa393147150e11595 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02b6020b5bcf92137d20d10fa393147150e11595 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0