July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: Fix engine-config description processing
by yzaslavs＠redhat.com 09 Jul '13

09 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fix engine-config description processing ...................................................................... tools: Fix engine-config description processing The "description" field was being processed by calling "getString" which would split the string by the delimiter character behind the scenes, causing only the first string to return. Now, the string will be rejoined using that delimiter character (padding is added because the split string is trimmed). Change-Id: Ieb6bf225b06d0ed8491e3c725daef7bd500b1ae1 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb6bf225b06d0ed8491e3c725daef7bd500b1ae1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Changed editor prohibition reason mechanism
by alkaplan＠redhat.com 09 Jul '13

09 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Changed editor prohibition reason mechanism ...................................................................... webadmin: Changed editor prohibition reason mechanism The tooltip displayed over disabled editor widgets (change prohibition reason) is now updated upon call to setChangeProhibitionReason() as well as to setIsChangeable(). This means that the correct tooltip will be shown even if setChangeProhibitionReason() is called after setIsChangeable(false), which hasn't been the case up 'til now. Change-Id: Ifb76b2348922bfebf62c54da4ee2a8ca45ebef31 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb76b2348922bfebf62c54da4ee2a8ca45ebef31 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Minor changes in noVNC
by tjelinek＠redhat.com 09 Jul '13

09 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Minor changes in noVNC ...................................................................... engine: Minor changes in noVNC This patch changes two things: - fixes the description of WebSocketProxy in the db upgrade script - derive protocol type of noVNC page from the currently served page. Change-Id: Id9fdc22097aefee0ac13c0ff939269b66c526b86 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9fdc22097aefee0ac13c0ff939269b66c526b86 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Disabled assign/unassign fields for external netwo...
by alkaplan＠redhat.com 09 Jul '13

09 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Disabled assign/unassign fields for external networks ...................................................................... webadmin: Disabled assign/unassign fields for external networks An external network now can't be picked from the webadmin console to be required, display or migration. Change-Id: I01f1f17e7cd21b7dde3451517254d18e418498db Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkCluster.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 4 files changed, 33 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01f1f17e7cd21b7dde3451517254d18e418498db Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Warning when editing Network Provider URL
by alkaplan＠redhat.com 09 Jul '13

09 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Warning when editing Network Provider URL ...................................................................... webadmin: Warning when editing Network Provider URL User is warned in case of changing Provider URL when it had already provided networks. Also added infrastructure for easy addition in the future of similar checks for other Provider types. Change-Id: Id71b5f916258f0250c2d5f1c6d77e9c1a9a9516e Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/EditProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 4 files changed, 121 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id71b5f916258f0250c2d5f1c6d77e9c1a9a9516e Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added plugin to Provider popup
by alkaplan＠redhat.com 09 Jul '13

09 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Added plugin to Provider popup ...................................................................... webadmin: Added plugin to Provider popup Added a plugin field which appears when the selected provider type is OpenStack Network. Change-Id: Ic3c64a2e5f21f86ca4658c2792a1a9b8c9bd35e8 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml 4 files changed, 57 insertions(+), 8 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c64a2e5f21f86ca4658c2792a1a9b8c9bd35e8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added tenant name field to Provider popup
by alkaplan＠redhat.com 09 Jul '13

09 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Added tenant name field to Provider popup ...................................................................... webadmin: Added tenant name field to Provider popup Added tenant name widget that appears when the Provider type is OpenStack Network. Also redesigned the dialog with the help of Eldan. Change-Id: If5f1e855c0036aa35f4ab891f2481cc74281f3c5 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml 4 files changed, 95 insertions(+), 35 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5f1e855c0036aa35f4ab891f2481cc74281f3c5 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Refactoring in ProviderModel
by alkaplan＠redhat.com 09 Jul '13

09 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Refactoring in ProviderModel ...................................................................... webadmin: Refactoring in ProviderModel Removed unnecessary private prefix from variable names to shorten them, and moved construction of models to the variable declaration to avoid cluttering in the constructor. This also made redundant their setters. Change-Id: Iac82299c44058327eaefc870ec1916d5189bb9e2 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 1 file changed, 36 insertions(+), 72 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac82299c44058327eaefc870ec1916d5189bb9e2 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Changed URL behaviour in Provider popup
by alkaplan＠redhat.com 09 Jul '13

09 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Changed URL behaviour in Provider popup ...................................................................... webadmin: Changed URL behaviour in Provider popup Removed the confusing auto-addition of the "http://" prefix when the scheme was missing, instead added the prefix as default when adding a new provider. Change-Id: I54c660b32dd307a4a70272c2ad8cea63087103b9 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/AddProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 3 files changed, 9 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54c660b32dd307a4a70272c2ad8cea63087103b9 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Improved UrlValidation
by alkaplan＠redhat.com 09 Jul '13

09 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Improved UrlValidation ...................................................................... webadmin: Improved UrlValidation Changed parameters from String[] to String... for convenience, and changed the error message so that it accommodates any allowed scheme. Change-Id: I1dcf6c4d6eb1e79c1086e39a7885c1ef061e3ca4 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/UrlValidationTest.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 5 files changed, 31 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dcf6c4d6eb1e79c1086e39a7885c1ef061e3ca4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0