July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: build: add missing quote to legacy setup
by oschreib＠redhat.com 08 Jul '13

08 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: build: add missing quote to legacy setup ...................................................................... packaging: build: add missing quote to legacy setup Change-Id: Ic23697f644c58416a03576989eb97d44be889f25 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic23697f644c58416a03576989eb97d44be889f25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: spec: stop sysv services when package remove
by oschreib＠redhat.com 08 Jul '13

08 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: spec: stop sysv services when package remove ...................................................................... packaging: spec: stop sysv services when package remove Change-Id: I909dc0b5062bf76bf19ab535bac548473184a21b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I909dc0b5062bf76bf19ab535bac548473184a21b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: add websocket proxy configuration
by oschreib＠redhat.com 08 Jul '13

08 Jul '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: add websocket proxy configuration ...................................................................... packaging: setup: add websocket proxy configuration configuration of websocket proxy on engine machine using setup. 1. enroll certificate. 2. enforce ssl. 3. enforce ticket validation. Change-Id: I5d5fad4dc61d9c89c4165a74e9922eded483beac Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py A packaging/firewalld/base/ovirt-websocket-proxy.xml.in M packaging/setup/ovirt_engine_setup/config.py.in M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/core/websocket_proxy.py M packaging/setup/plugins/ovirt-engine-setup/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py 14 files changed, 514 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d5fad4dc61d9c89c4165a74e9922eded483beac Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: in some cases the display options are not taken fr...
by tjelinek＠redhat.com 08 Jul '13

08 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: in some cases the display options are not taken from template ...................................................................... frontend: in some cases the display options are not taken from template The problem was that first the options depending on the display protocol has been copied from template to VM and then the display type. It could happen, that you had a display protocol e.g. VLC and than you have selected something which makes sense only for SPICE, than this options have been ignored. Fixed by moving the relevant options under the display protocol setting. Change-Id: I77a995eff3e800ba000cc3049eb1929d30ee91e8 Bug-Url: https://bugzilla.redhat.com/952712 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 3 files changed, 10 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77a995eff3e800ba000cc3049eb1929d30ee91e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added removeFromMap to MultiValueMapUtils
by yzaslavs＠redhat.com 08 Jul '13

08 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Added removeFromMap to MultiValueMapUtils ...................................................................... core: Added removeFromMap to MultiValueMapUtils Change-Id: I06222dc730330d407050c6cb7326522feaa1ddf4 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/MultiValueMapUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/collections/MultiValueMapUtilsTest.java 2 files changed, 52 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06222dc730330d407050c6cb7326522feaa1ddf4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introducing batch to async task mgr
by yzaslavs＠redhat.com 08 Jul '13

08 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Introducing batch to async task mgr ...................................................................... core: Introducing batch to async task mgr This patch is first step towards inserting batch updates/inserts to the async tasks manager system. The patch intoduces elimination of usage of INSERT SELECT and fnsplitter in order to insert associations of entities and async tasks to the database. Instead, AsyncTaskUtils is changed to insert/update an AsyncTask object, and a collection of objects the newly introduced AsyncTaskEntity class - a class that represents the association between async tasks and entities. Change-Id: Ia6d8dc6095430c99fdb6c8cd8289c23e270fff9e Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTaskEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M packaging/dbscripts/async_tasks_sp.sql 7 files changed, 187 insertions(+), 101 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6d8dc6095430c99fdb6c8cd8289c23e270fff9e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix NPEx when adding new vm pool
by ofrenkel＠redhat.com 08 Jul '13

08 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix NPEx when adding new vm pool ...................................................................... core: fix NPEx when adding new vm pool This patch adds handling of null value of the soundcard attribute when creating a new VM pool. Without it the creation of the VM pool was throwing NPEx when the attribute wasn't specified (tried with restapi). Change-Id: I51262b8ceec47ab4e36b0180ec8d3fd9af6033b3 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51262b8ceec47ab4e36b0180ec8d3fd9af6033b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Add required VM networks config value
by mkolesni＠redhat.com 08 Jul '13

08 Jul '13

Mike Kolesnik has submitted this change and it was merged. Change subject: tools: Add required VM networks config value ...................................................................... tools: Add required VM networks config value The OnlyRequiredNetworksMandatoryForVdsSelection value has to be user-configurable in order to be able to run external networks which are dynamically provisioned. Change-Id: I257aaef3c6aacc65fe0b217f6ef6c2d866f095d9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I257aaef3c6aacc65fe0b217f6ef6c2d866f095d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix of diskless vm import
by amureini＠redhat.com 08 Jul '13

08 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix of diskless vm import ...................................................................... core: fix of diskless vm import When importing diskless vm, the devices/snapshots should be added as well. Change-Id: If2d53edfb828de11d6106001a4f9ab7020da4bdd Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2d53edfb828de11d6106001a4f9ab7020da4bdd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[master]: conf: examples in usage message
by sbonazzo＠redhat.com 08 Jul '13

08 Jul '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: conf: examples in usage message ...................................................................... conf: examples in usage message Added examples of command invocation in description help message, aligned with man page. Change-Id: I61932a0bb9cf2f14537e91470b1222cac13fe77c Bug-Url: https://bugzilla.redhat.com/887566 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 50 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61932a0bb9cf2f14537e91470b1222cac13fe77c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0