July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix postMessage listener for IE9
by vszocs＠redhat.com 04 Jul '13

04 Jul '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix postMessage listener for IE9 ...................................................................... webadmin: Fix postMessage listener for IE9 Simplified postMessage listener registration and verified that it works for IE9 too. Change-Id: I4298d84d0f8fcfb8ac7315a881aaba6fa2c22654 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/PostMessageDispatcher.java 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4298d84d0f8fcfb8ac7315a881aaba6fa2c22654 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorriss(a)netapp.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Ricky Hopper <ricky.hopper(a)gmail.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: network: firewalld: avoid error if not available
by Alon Bar-Lev 04 Jul '13

04 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: network: firewalld: avoid error if not available ...................................................................... network: firewalld: avoid error if not available check if the service is available before checking firewall-cmd version. Change-Id: I6a2617b7b2313e267096ba0b6e878530c97a058e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/otopi/network/firewalld.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a2617b7b2313e267096ba0b6e878530c97a058e Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Don't clone Guids in VDS.clone()
by amureini＠redhat.com 04 Jul '13

04 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't clone Guids in VDS.clone() ...................................................................... core: Don't clone Guids in VDS.clone() Since Guids are immutable, there is no need for VDS.clone() to create new Guid instances, especially not by the expensive string-parsing method. This patch changes the new instance created by VDS.clone() to simply hold references to the old one's Guid, thus improving performance. As a nice side bonus, this will allow cloning of VDS instances that have null VDS group or storage pool IDs. This patch also contains a test to assert this functionality. Change-Id: I0f7130f76525dda601ac0bc7322fbf96c961c5a6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/VDSTest.java 2 files changed, 39 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f7130f76525dda601ac0bc7322fbf96c961c5a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix VDS.hashCode()
by amureini＠redhat.com 04 Jul '13

04 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix VDS.hashCode() ...................................................................... core: Fix VDS.hashCode() VDS.hashCode() includes the hashCode() of vdsDynamic and vdsStatistics, which are not present in VDS.eqauls(Object). This behavior violates Java's contract that clearly states that if a.equals(b) then it is required that a.hashCode() == b.hashCode(). This patch fixes the aforementioned bug by removing these two members for the hashCode() calculation. Change-Id: Ie006b12f59762bc92663007a37bf46325f8f9378 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie006b12f59762bc92663007a37bf46325f8f9378 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GuidUtils - remove TODO
by amureini＠redhat.com 04 Jul '13

04 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: GuidUtils - remove TODO ...................................................................... core: GuidUtils - remove TODO Removed a useless TODO comment. Change-Id: I41a9b5f63c80da62ed0317b128f572cade363721 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41a9b5f63c80da62ed0317b128f572cade363721 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GuidUtils initial StringBuilder capacity
by amureini＠redhat.com 04 Jul '13

04 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: GuidUtils initial StringBuilder capacity ...................................................................... core: GuidUtils initial StringBuilder capacity The StringBuilder used in writeGUIDPartToStream is known to contain 2 characters. This patch initializes it in the correct size instead of wasting the additional 14 bytes done by the default initialization. Change-Id: I301b6ebce95a069968af99fed0b65ab189d4b1a2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I301b6ebce95a069968af99fed0b65ab189d4b1a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GuidUtils code formatter
by amureini＠redhat.com 04 Jul '13

04 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: GuidUtils code formatter ...................................................................... core: GuidUtils code formatter Apply code formatter on GuidUtils to shorten long javadoc lines. Change-Id: I2dc1d6c5bb330c08bb4a3357c19e683f3d439f82 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dc1d6c5bb330c08bb4a3357c19e683f3d439f82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Guid.ToByteArray -> Guid.toByteArray
by amureini＠redhat.com 04 Jul '13

04 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Guid.ToByteArray -> Guid.toByteArray ...................................................................... core: Guid.ToByteArray -> Guid.toByteArray As per Java coding conventions. Change-Id: I2457ba75fbe8c427b143b8b9d1bb9dac3c3c3053 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADLdapGuidEncoder.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2457ba75fbe8c427b143b8b9d1bb9dac3c3c3053 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: Remove DLS in VmStaticDAO
by amureini＠redhat.com 04 Jul '13

04 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: findbugs: Remove DLS in VmStaticDAO ...................................................................... findbugs: Remove DLS in VmStaticDAO Removed a DLS param mapper left by a careless refactoring. Change-Id: I16c566a53dd9d0399d588cc17c98e5903a6e6d8a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16c566a53dd9d0399d588cc17c98e5903a6e6d8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: refactor "connect" command help
by mpastern＠redhat.com 04 Jul '13

04 Jul '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: refactor "connect" command help ...................................................................... cli: refactor "connect" command help Change-Id: I313fa63ca6c7df851ad715a2978d1c0351109645 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I313fa63ca6c7df851ad715a2978d1c0351109645 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0