July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: host-deploy: registration: allow compatiblity with rhev-h
by yzaslavs＠redhat.com 14 Jul '13

14 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: registration: allow compatiblity with rhev-h ...................................................................... host-deploy: registration: allow compatiblity with rhev-h Change-Id: Ib03de86917d60c8d6ac1a666eb8ce7136c173ffe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib03de86917d60c8d6ac1a666eb8ce7136c173ffe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove snapshot's memory on remove vm from export doma...
by ofrenkel＠redhat.com 14 Jul '13

14 Jul '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: remove snapshot's memory on remove vm from export domain ...................................................................... core: remove snapshot's memory on remove vm from export domain When a VM in export domain is being removed, the volumes of the memory of its snapshots should be removed from the export domain as well. Change-Id: I0bf0f29aade5cb7c93949a27067d7c4270e86032 Bug-Url: https://bugzilla.redhat.com/960931 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java 5 files changed, 198 insertions(+), 51 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bf0f29aade5cb7c93949a27067d7c4270e86032 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add actual free memory to vds statistics
by dfediuck＠redhat.com 14 Jul '13

14 Jul '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Add actual free memory to vds statistics ...................................................................... core: Add actual free memory to vds statistics currently, only memAvailable is exposed by vdsm to engine. But this api is a calculated value and so it may return negative value in case ksm is up and pages are shared among VMs. This causes wrong 'memory under defined threshold' logs. The new "memFree" returns the true free memory on the host. i.e. 'MemFree' + 'Cached' + 'Buffers' (from meminfo) Change-Id: I68bbee6cc3c43636c2059443d980a2ae4c639854 Bug-Url: https://bugzilla.redhat.com/977758 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_03_0440_add_free_mem_to_vds_statistics.sql M packaging/dbscripts/vds_sp.sql 10 files changed, 54 insertions(+), 11 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68bbee6cc3c43636c2059443d980a2ae4c639854 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [db] renaming wrongly named upgrade scripts.
by yzaslavs＠redhat.com 14 Jul '13

14 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: [db] renaming wrongly named upgrade scripts. ...................................................................... core: [db] renaming wrongly named upgrade scripts. Those scripts represents two features available only to 3.3 The upgrade scripts were renamed with the 03_02 prefix making upgrade from 3.2 to 3.3 to fail. Scripts were renamed to have 03_03 prefix and since the former scripts have no dependency in the result of those scripts , they were simply added to the end. Change-Id: Icb0ea14865b4f33261289bc1e600bb843d2fed2c Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- R packaging/dbscripts/upgrade/03_02_0390_align_lun_volume_group_id.sql R packaging/dbscripts/upgrade/03_02_0400_add_login_permission_to_network_user_role.sql R packaging/dbscripts/upgrade/03_02_0410_remove_user_session.sql R packaging/dbscripts/upgrade/03_02_0420_materialized_views_extensions.sql R packaging/dbscripts/upgrade/03_02_0430_add_vm_vnc_keyboard_layout.sql R packaging/dbscripts/upgrade/03_02_0440_add_async_task_task_parameters.sql R packaging/dbscripts/upgrade/03_02_0450_lsm_version_support.sql R packaging/dbscripts/upgrade/03_02_0460_fix_stateless_snapshot.sql R packaging/dbscripts/upgrade/03_02_0470_add_update_column_to_statistics_tables.sql R packaging/dbscripts/upgrade/03_02_0480_add_gluster_hooks_table.sql R packaging/dbscripts/upgrade/03_03_0420_add_storage_static_description_column.sql R packaging/dbscripts/upgrade/03_03_0430_add_tunnel_migration.sql 12 files changed, 0 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb0ea14865b4f33261289bc1e600bb843d2fed2c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Face lift for Discovery popup
by alkaplan＠redhat.com 14 Jul '13

14 Jul '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Face lift for Discovery popup ...................................................................... webadmin: Face lift for Discovery popup Mostly improvements to HorizontalSplitTable widget; improved behaviour upon items change, changed button styling, added table borders, added customizable table headers. Also changed a couple of network-specific text labels. Change-Id: I247df809b2cf21488f0b6c3109294c24cb3db914 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HorizontalSplitTable.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.ui.xml 6 files changed, 137 insertions(+), 43 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I247df809b2cf21488f0b6c3109294c24cb3db914 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add alignment scan lost changes
by amureini＠redhat.com 14 Jul '13

14 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add alignment scan lost changes ...................................................................... core: add alignment scan lost changes During the rebase of I4858b7bb few changes has been lost. This patch reintroduces them. Change-Id: Ie30552eb8967c5f9e4473fcbf15edd983f25da34 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskAlignment.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDiskAlignmentVDSCommand.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_03_0410_alignment_not_null.sql 10 files changed, 39 insertions(+), 26 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie30552eb8967c5f9e4473fcbf15edd983f25da34 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: watchdog - restapi support
by dfediuck＠redhat.com 14 Jul '13

14 Jul '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: watchdog - restapi support ...................................................................... engine: watchdog - restapi support - added watchdog mapping to the vm and template - watchdog models and actions in capabilities gerrit-cntr: 2 Change-Id: Ief5b20ecf2221faf900cadfeafe4c71607a9eca3 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/WatchdogResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/WatchdogsResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/WatchdogValidator.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendWatchdogsResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendWatchdogsResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/validation/WatchdogValidatorTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogAction.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/WatchdogModel.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/WatchdogMapperTest.java 25 files changed, 969 insertions(+), 7 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief5b20ecf2221faf900cadfeafe4c71607a9eca3 Gerrit-PatchSet: 43 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: transaction: remove committed transactions
by Alon Bar-Lev 12 Jul '13

12 Jul '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: transaction: remove committed transactions ...................................................................... core: transaction: remove committed transactions required to avoid aborting already committed transaction in case of commit failure of one of the elements. Change-Id: I70b16025e87ee855ae030ab54dd0035d0cd39c37 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/transaction.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70b16025e87ee855ae030ab54dd0035d0cd39c37 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in mom[master]: Teach min and max to MoM policy parser
by agl＠us.ibm.com 12 Jul '13

12 Jul '13

Adam Litke has submitted this change and it was merged. Change subject: Teach min and max to MoM policy parser ...................................................................... Teach min and max to MoM policy parser Change-Id: I6fef9f562dd04ed8d9aab3fbac62d18e2d9885b9 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/15800 Reviewed-by: Adam Litke <agl(a)us.ibm.com> --- M mom/Policy/Parser.py M tests/ParserTests.py 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/15800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fef9f562dd04ed8d9aab3fbac62d18e2d9885b9 Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in mom[master]: Fix the lexical priority of operators
by agl＠us.ibm.com 12 Jul '13

12 Jul '13

Adam Litke has submitted this change and it was merged. Change subject: Fix the lexical priority of operators ...................................................................... Fix the lexical priority of operators As python dictionary has no defined key ordering the GenericEvaluator.get_operators could return the operators in bad order. (for example "<" before "<<") This caused << to be parsed as two < elements and resulted in parse errors. This patch fixes it by ordering the returned value by string size - longer names first. Change-Id: I7dcb7b110b994b351534ccca4da6dc4b79e20895 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/16097 Reviewed-by: Adam Litke <agl(a)us.ibm.com> --- M mom/Policy/Parser.py 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/16097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dcb7b110b994b351534ccca4da6dc4b79e20895 Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0