August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: packaging: ovirt-engine-3.3_rc2
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.3_rc2 ...................................................................... packaging: ovirt-engine-3.3_rc2 Updated version to be 3.3.0-0.7.rc2 Change-Id: I35386d5feffc86d394db30ca47989cc078585956 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35386d5feffc86d394db30ca47989cc078585956 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: Webadmin: set default single Qxl device to true
by ofrenkel＠redhat.com 28 Aug '13

28 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: Webadmin: set default single Qxl device to true ...................................................................... Webadmin: set default single Qxl device to true Change-Id: I285855f3a6975c97b1350d3de18b7395b2322aef Bug-Url: https://bugzilla.redhat.com/1000039 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I285855f3a6975c97b1350d3de18b7395b2322aef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: findbugs: Fix XML comments in findbugs filters
by juan.hernandez＠redhat.com 28 Aug '13

28 Aug '13

Juan Hernandez has submitted this change and it was merged. Change subject: findbugs: Fix XML comments in findbugs filters ...................................................................... findbugs: Fix XML comments in findbugs filters Some findbugs configuration files have syntax errors. This patch fixes them. Change-Id: I45b77157084c312d5dc57daf28161c93a1f87d0f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M exclude-filters-general.xml M frontend/webadmin/modules/gwt-common/exclude-filters.xml 2 files changed, 25 insertions(+), 22 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45b77157084c312d5dc57daf28161c93a1f87d0f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fix Filters text syntax
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Fix Filters text syntax ...................................................................... webadmin: Fix Filters text syntax Minor text fix for the Filters tool tip text. Change-Id: I5e8f07936ebef407d80774f73094a48ca3ce63bc Bug-Url: https://bugzilla.redhat.com/1000871 Signed-off-by: Doron Fediuck <dfediuck(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e8f07936ebef407d80774f73094a48ca3ce63bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engien: test for ClusterPolicyCRUDCommandTest
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: engien: test for ClusterPolicyCRUDCommandTest ...................................................................... engien: test for ClusterPolicyCRUDCommandTest test for ClusterPolicyCRUDCommandTest Change-Id: I9b370e4cc0a43645961b7693310695110f7f8281 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommandTest.java 1 file changed, 55 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b370e4cc0a43645961b7693310695110f7f8281 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: EditClusterPolicyCommand simplification
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: EditClusterPolicyCommand simplification ...................................................................... engine: EditClusterPolicyCommand simplification EditClusterPolicyCommand canDoAction simplification Change-Id: If04225e711bffefe87f3f2496bb0a17e8c48f95d Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/EditClusterPolicyCommand.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If04225e711bffefe87f3f2496bb0a17e8c48f95d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: AddClusterPolicyCommand canDoAction simplification
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: AddClusterPolicyCommand canDoAction simplification ...................................................................... engine: AddClusterPolicyCommand canDoAction simplification AddClusterPolicyCommand canDoAction simplification Change-Id: I31d7db46e6f0c086f2a48f8217bda4d175448803 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddClusterPolicyCommand.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31d7db46e6f0c086f2a48f8217bda4d175448803 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: sort cluster policy list
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: sort cluster policy list ...................................................................... webadmin: sort cluster policy list first order cluster policies by pre-defined then lexicographically. Change-Id: I46c5de299ea7d4d0cd53dc6538d25b8f7337d0e6 Bug-Url: https://bugzilla.redhat.com/994719 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/ClusterPolicyListModel.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46c5de299ea7d4d0cd53dc6538d25b8f7337d0e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: scheduler: handle external scheduler parameters
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduler: handle external scheduler parameters ...................................................................... core: scheduler: handle external scheduler parameters For loaded external scheduling plugin fixing saving description and custom properties. Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> Change-Id: Ibaa3e1396ba0ec61ebce33d08a1174b93b97c56d --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryThread.java 2 files changed, 30 insertions(+), 21 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified Noam Slomianko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/18570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaa3e1396ba0ec61ebce33d08a1174b93b97c56d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix for scheduling cluster custom properties
by dfediuck＠redhat.com 28 Aug '13

28 Aug '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: fix for scheduling cluster custom properties ...................................................................... core: fix for scheduling cluster custom properties problem: when adding scheduling custom property to a cluster and the cluster policy doesn't have this custom policy set, it will not be save. fix: should compare the cluster's custom properties with avialable custom properties and not with cluster policy custom properties. Change-Id: I8d1a79b3406b577cd94e9f2e46defe7e3554d5a9 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/18569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d1a79b3406b577cd94e9f2e46defe7e3554d5a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0