August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: version in welcome page
by derez＠redhat.com 04 Aug '13

04 Aug '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal,webadmin: version in welcome page ...................................................................... userportal,webadmin: version in welcome page - Fixed issue that caused myVersion to be displayed instead of the actual version. - Removed unused engineVersion.js file. Change-Id: I4a0e28386e00b15e3f222e353965104be50d3938 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M Makefile M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp D backend/manager/modules/root/src/main/webapp/engineVersion.js M backend/manager/modules/root/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java 5 files changed, 2 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a0e28386e00b15e3f222e353965104be50d3938 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: db: Updated psql usage never to ask passwords
by oschreib＠redhat.com 04 Aug '13

04 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: db: Updated psql usage never to ask passwords ...................................................................... packaging: db: Updated psql usage never to ask passwords Change-Id: Id44f803bafdcc0c5bc059b59842cff54e2e8e584 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/dbscripts/create_schema.sh M packaging/dbscripts/dbfunctions.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id44f803bafdcc0c5bc059b59842cff54e2e8e584 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: call psql with correct env
by ydary＠redhat.com 04 Aug '13

04 Aug '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: call psql with correct env ...................................................................... packaging: setup: call psql with correct env Change-Id: I5464894fca921a7d3fdd41fd554dcb6b9805a785 Bug-Url: https://bugzilla.redhat.com/991760 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5464894fca921a7d3fdd41fd554dcb6b9805a785 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add log for error on run-vm failure
by rgolan＠redhat.com 04 Aug '13

04 Aug '13

Roy Golan has submitted this change and it was merged. Change subject: core: Add log for error on run-vm failure ...................................................................... core: Add log for error on run-vm failure In most cases, when running vm fails there is re-run. when there is an error in the create process (for example before createVmVdsCommand is called), the error is not logged anywhere. This patch adds a log to this error, also remove the word "VDSM" from the exception message, unfortunately its not always vdsm fault. Change-Id: Ia936fee01fa781eff5d5b3959ae6478129c2a136 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBLLException.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia936fee01fa781eff5d5b3959ae6478129c2a136 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: vms_sp.sql argument error in InsertVm function
by ofrenkel＠redhat.com 04 Aug '13

04 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: vms_sp.sql argument error in InsertVm function ...................................................................... engine: vms_sp.sql argument error in InsertVm function Change-Id: I6adae39e819424ae53368a61fbe7b10500ad2dbb Bug-Url: https://bugzilla.redhat.com/989221 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M packaging/dbscripts/vms_sp.sql 3 files changed, 0 insertions(+), 123 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6adae39e819424ae53368a61fbe7b10500ad2dbb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pki: Add a script to extract parts from a PKCS#12
by oschreib＠redhat.com 04 Aug '13

04 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: Add a script to extract parts from a PKCS#12 ...................................................................... pki: Add a script to extract parts from a PKCS#12 Add a script pki-pkcs12-extract.sh to extract the key and/or cert from a PKCS#12 file, with or without encryption (for the key). Change the setup code to use it. Change-Id: Ica596fe3ef4e5f0a60ae99b0934b10433b9d5023 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in A packaging/bin/pki-pkcs12-extract.sh M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/pki/ssh.py 6 files changed, 138 insertions(+), 28 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica596fe3ef4e5f0a60ae99b0934b10433b9d5023 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: updated read-only user permissions
by ydary＠redhat.com 04 Aug '13

04 Aug '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: updated read-only user permissions ...................................................................... packaging: setup: updated read-only user permissions This new implementation updates creating a read only user with correct permissions. Change-Id: I6044b4561606427ac32686fcd46e02032ce4347b Bug-Url: https://bugzilla.redhat.com/990095 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 111 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6044b4561606427ac32686fcd46e02032ce4347b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Making sshPort field to be editable always
by yzaslavs＠redhat.com 04 Aug '13

04 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Making sshPort field to be editable always ...................................................................... core: Making sshPort field to be editable always sshPort field was set to be editable only when vds is UP, but should be editable in any state. When perform 'edit host' we can change the port number, this can be done from any state. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=989493 Change-Id: I2c5b6a74450f8766fb13d21eea2402f41d431ffa Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c5b6a74450f8766fb13d21eea2402f41d431ffa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: packaging: spec: support fedora-19 new maven directives
by Alon Bar-Lev 04 Aug '13

04 Aug '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: support fedora-19 new maven directives ...................................................................... packaging: spec: support fedora-19 new maven directives Change-Id: Idd40e33a6950e5bf97ec2d8f78519fda468a652a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 49 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd40e33a6950e5bf97ec2d8f78519fda468a652a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: spec: support fedora-19 new maven directives
by Alon Bar-Lev 04 Aug '13

04 Aug '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: support fedora-19 new maven directives ...................................................................... packaging: spec: support fedora-19 new maven directives Change-Id: I9b26dc2176f0767049ed704ad8014548d518bee3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 55 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b26dc2176f0767049ed704ad8014548d518bee3 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0