August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: [ExternalTasks] Cannot end existing job
by emesika＠redhat.com 01 Aug '13

01 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: [ExternalTasks] Cannot end existing job ...................................................................... core: [ExternalTasks] Cannot end existing job Enable to set the JobId or Step Id as parameters to commands that are not monitored but handle the External Job/Tasks : EndExternalJobCommand ClearExternalJobCommand EndExternalStepCommand Change-Id: I78f72cd619e32e5763f46391932ec70730a2b4b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988094 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78f72cd619e32e5763f46391932ec70730a2b4b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix race between AsyncTaskManager and VdsManager
by yzaslavs＠redhat.com 01 Aug '13

01 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix race between AsyncTaskManager and VdsManager ...................................................................... core: Fix race between AsyncTaskManager and VdsManager This patch fixes a race between AsyncTaskManager and VdsManager IrsBrokerCommand.Init fetches store pool, and initializes IrsProxyData, which in turn calls StoragePoolUpEvent which accesses TaskManager. But, At the same time AsyncTaskManager did not complete its initialization, so ClassDefNotFoundException may be thrown. The following patch fixes this by: 1. Call AsyncTaskManager initialization code before Initialization of VdsBroker (which in turn initializes IrsProxyData) 2. Use countdown latch to wait for all asyncrhonous code inside the async task manager initialization. After the countdown latch is being used, the state of AsyncTaskManager is valid to be used by Irs Proxy data. Bug-Url: https://bugzilla.redhat.com/983443 Change-Id: Ibbbacef1109741ef005e33d1e4c7f4f7cc741338 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java 2 files changed, 28 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbbacef1109741ef005e33d1e4c7f4f7cc741338 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: unite locale cookie
by ecohen＠redhat.com 01 Aug '13

01 Aug '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal,webadmin: unite locale cookie ...................................................................... userportal,webadmin: unite locale cookie - Set the locale cookie path to '/' so we can share the cookie between all the applications. Change-Id: Id20dda2985226a9a525e9c0f0b2d8c20cb0a6210 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/LocaleFilter.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id20dda2985226a9a525e9c0f0b2d8c20cb0a6210 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adds task description for SshSoftFencingCommand
by yzaslavs＠redhat.com 01 Aug '13

01 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adds task description for SshSoftFencingCommand ...................................................................... core: Adds task description for SshSoftFencingCommand Adds task description for SshSoftFencingCommand. Change-Id: I7a217f52f9558fc781a326fb8b34a040fdd44563 Bug-Url: https://bugzilla.redhat.com/988305 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a217f52f9558fc781a326fb8b34a040fdd44563 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Support for multiple heads for Qxl display device
by ofrenkel＠redhat.com 01 Aug '13

01 Aug '13

Omer Frenkel has submitted this change and it was merged. Change subject: Support for multiple heads for Qxl display device ...................................................................... Support for multiple heads for Qxl display device When a user select Qxl as a video device he can channel multiple monitors via a single PCI device instead of one PCI for each video device. This will save memory and PCI slots in the user guest OS. Bug-Url: https://bugzilla.redhat.com/787578 Change-Id: If18b8ceba3d641f3e2e79947b34b549902f00b55 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_03_0650_add_signle_qxl_pci_column.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 53 files changed, 338 insertions(+), 61 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If18b8ceba3d641f3e2e79947b34b549902f00b55 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix UpdateNetworkQoSCommand canDoAction
by gchaplik＠redhat.com 01 Aug '13

01 Aug '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix UpdateNetworkQoSCommand canDoAction ...................................................................... core: Fix UpdateNetworkQoSCommand canDoAction the canDoAction was changed to verify 'Peak' value is not set lower than 'Average' value. Change-Id: Iecd333f8287108373b6bd5e72ac86c3164e85227 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecd333f8287108373b6bd5e72ac86c3164e85227 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: bump to 0.1.1
by mburns＠redhat.com 01 Aug '13

01 Aug '13

Michael Burns has submitted this change and it was merged. Change subject: bump to 0.1.1 ...................................................................... bump to 0.1.1 Change-Id: Iac6580d785417acc2137c3f1f61d2467f56023ce Signed-off-by: Mike Burns <mburns(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Burns: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac6580d785417acc2137c3f1f61d2467f56023ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: set root passwd on oVirt Engine tab
by mburns＠redhat.com 01 Aug '13

01 Aug '13

Michael Burns has submitted this change and it was merged. Change subject: engine_page: set root passwd on oVirt Engine tab ...................................................................... engine_page: set root passwd on oVirt Engine tab Users must have option to set root password correctly. Rebase on top of a ConfirmedEntry change. Change-Id: I56795d2595689c67d078960b3f6e676cd92d9e1f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=989003 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Michael Burns: Verified; Looks good to me, approved Joey Boggs: Verified; Looks good to me, but someone else must approve Ryan Barry: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56795d2595689c67d078960b3f6e676cd92d9e1f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: Make VDSM plugin use the new ConfirmedEntry widget
by mburns＠redhat.com 01 Aug '13

01 Aug '13

Michael Burns has submitted this change and it was merged. Change subject: Make VDSM plugin use the new ConfirmedEntry widget ...................................................................... Make VDSM plugin use the new ConfirmedEntry widget Entry fields which should be identical/confirmed use a different widget now to handle edge-case mismatches. Update the engine page to use this. Change-Id: I7c4be693342c22f60dc591993f4802672dde4ccc Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M src/engine_page.py 1 file changed, 3 insertions(+), 15 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Michael Burns: Verified; Looks good to me, approved Joey Boggs: Verified; Looks good to me, but someone else must approve Ryan Barry: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c4be693342c22f60dc591993f4802672dde4ccc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Joey Boggs <jboggs(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0