September 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core : DAO Tests fail because of fk_vm_static_quota
by iheim＠redhat.com 30 Sep '13

30 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: core : DAO Tests fail because of fk_vm_static_quota ...................................................................... core : DAO Tests fail because of fk_vm_static_quota A new foreign key constraint added to vm_static table fk_vm_static_quota requires tests to have a existing quota id and also requires that the quota table be populated before inserting data into vm_static table Change-Id: Ia15cd17950c7b5aa082452a9014ec67ffa0da0da Bug-Url: https://bugzilla.redhat.com/1003839 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 77 insertions(+), 75 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia15cd17950c7b5aa082452a9014ec67ffa0da0da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent disabling VirtIO-SCSI on edit VM
by derez＠redhat.com 30 Sep '13

30 Sep '13

Daniel Erez has submitted this change and it was merged. Change subject: core: prevent disabling VirtIO-SCSI on edit VM ...................................................................... core: prevent disabling VirtIO-SCSI on edit VM When a disk with VirtIO-SCSI interface is plugged to a VM, disabling VirtIO-SCSI should be prevented. Change-Id: Ic2e6c85a2df434de3180f19a32079f276458d372 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 44 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2e6c85a2df434de3180f19a32079f276458d372 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: cleanup in RemoveSnapshotSingleDiskCommand
by amureini＠redhat.com 30 Sep '13

30 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: cleanup in RemoveSnapshotSingleDiskCommand ...................................................................... engine: cleanup in RemoveSnapshotSingleDiskCommand Change-Id: Ibe60ca192123553a2c5a2bac2f34b3e4d9a64f3b Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java 1 file changed, 24 insertions(+), 25 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe60ca192123553a2c5a2bac2f34b3e4d9a64f3b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : DAO Tests fail because of fk_vm_static_quota
by dfediuck＠redhat.com 30 Sep '13

30 Sep '13

Doron Fediuck has submitted this change and it was merged. Change subject: core : DAO Tests fail because of fk_vm_static_quota ...................................................................... core : DAO Tests fail because of fk_vm_static_quota A new foreign key constraint added to vm_static table fk_vm_static_quota requires tests to have a existing quota id and also requires that the quota table be populated before inserting data into vm_static table Change-Id: Ia15cd17950c7b5aa082452a9014ec67ffa0da0da Bug-Url: https://bugzilla.redhat.com/1003839 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 77 insertions(+), 75 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/19696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia15cd17950c7b5aa082452a9014ec67ffa0da0da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix typo
by mlipchuk＠redhat.com 30 Sep '13

30 Sep '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix typo ...................................................................... core: Fix typo replace domainWhicWereSeen with domainWhichWereSeen Change-Id: I590e166455752e6a64784d114c1d69a61eeff58b Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I590e166455752e6a64784d114c1d69a61eeff58b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use private access modifier and rename method.
by mlipchuk＠redhat.com 30 Sep '13

30 Sep '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: use private access modifier and rename method. ...................................................................... core: use private access modifier and rename method. 1. Use private access modifier instead of a public one. 2. Change the method name to indicate it returns list instead of boolean. Change-Id: I8fb4aff4a6ad6f4f83f21b148d2f1df3ce6efaf2 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb4aff4a6ad6f4f83f21b148d2f1df3ce6efaf2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: overlapping event notification text
by ecohen＠redhat.com 30 Sep '13

30 Sep '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: overlapping event notification text ...................................................................... webadmin: overlapping event notification text - Fixed issue where the height of a row was fixed and it would overflow onto the next line if the text was too long. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=987943 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=911071 Change-Id: Ib6ec7edbbf6d0cd391a2e8d5a28c0b1fa978b832 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/NotificationsTree.css 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6ec7edbbf6d0cd391a2e8d5a28c0b1fa978b832 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: build: ovirt-hosted-engine-ha-0.1.0-0.2.beta1
by gpadgett＠redhat.com 30 Sep '13

30 Sep '13

Greg Padgett has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-0.1.0-0.2.beta1 ...................................................................... build: ovirt-hosted-engine-ha-0.1.0-0.2.beta1 Change-Id: Ie9c35f162cc795d4ddfa7d525d88cd829ea8e036 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c35f162cc795d4ddfa7d525d88cd829ea8e036 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: etl: fixed issue with os info enum updates
by ydary＠redhat.com 30 Sep '13

30 Sep '13

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed issue with os info enum updates ...................................................................... etl: fixed issue with os info enum updates Change-Id: I0fc626f27feb9667f91c42ec11de23bab700008a Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/osenumupdate_3_3/OsEnumUpdate.java M data-warehouse/history_etl/tos_project/process/OsEnumUpdate_3.3.item M data-warehouse/history_etl/tos_project/process/OsEnumUpdate_3.3.properties M data-warehouse/history_etl/tos_project/talend.project 4 files changed, 62 insertions(+), 535 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fc626f27feb9667f91c42ec11de23bab700008a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: fix defaults initializations on additional...
by sbonazzo＠redhat.com 30 Sep '13

30 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: fix defaults initializations on additional host ...................................................................... packaging: setup: fix defaults initializations on additional host Fixed initialization of ohostedcons.VDSMEnv.VDSM_CPU using setdefault instead of direct assignment. Fixed initializatoin of variables set by remote answer file Change-Id: I959ad89b10c4cf34902d353bc6778a598eed670a Bug-Url: https://bugzilla.redhat.com/1013557 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I959ad89b10c4cf34902d353bc6778a598eed670a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0