January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Fix findbug error - wrong key type
by masayag＠redhat.com 22 Jan '14

22 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Fix findbug error - wrong key type ...................................................................... restapi: Fix findbug error - wrong key type The key type should be a Guid instead of the String which is passed to query map of type Map<Guid, VdsNetworkInterface>. Change-Id: If29de8662dfcdf58f063e09083d241f91e4a8ebf Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, approved Moti Asayag: Verified Objections: oVirt Jenkins CI Server: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/23525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If29de8662dfcdf58f063e09083d241f91e4a8ebf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: oVirt Node Upgrade: Support N configuration
by yzaslavs＠redhat.com 22 Jan '14

22 Jan '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: oVirt Node Upgrade: Support N configuration ...................................................................... oVirt Node Upgrade: Support N configuration To have multiple configurations supported for node upgrade and same code for upstream/downstream, this patch will include the delimiter ":" to the below elements in vdc_options. - OvirtInitialSupportedIsoVersion - oVirtISOsRepositoryPath - OvirtIsoPrefix Additionally: - OvirtIsoPrefix now includes prefix and regex to list ISOs. - Includes OvirtNodeOS to regex node OS - New class OVirtNodeInfo to hold informations about upgrade. Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=979231 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeInfo.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetoVirtISOsTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/InstallVdsCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 8 files changed, 236 insertions(+), 198 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: set local storage domain format
by amureini＠redhat.com 21 Jan '14

21 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: set local storage domain format ...................................................................... core: set local storage domain format During the local storage domain creation we should use the preferred domain format in order to avoid useless pool upgrades and possible incompatibilities. Change-Id: Iec0ea5afe3e611dd72082791c497173b037d40a4 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec0ea5afe3e611dd72082791c497173b037d40a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Preserve labels when setup networks is sent
by masayag＠redhat.com 21 Jan '14

21 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Preserve labels when setup networks is sent ...................................................................... restapi: Preserve labels when setup networks is sent The setup networks api doesn't use the patch mechanism to preserve any interface's properties that wasn't sent by the user. Instead, it creates a new interface entity and set only the provided nic attributes. Since labels are maintained as a sub-collection on the nic entity, it should not be deleted for each setup networks request. This logic cannot reside on the engine side, since there will be no distinction between setup networks sent by the UI, in which the labels can be provided or removed, to the rest in which labels cannot be provided and should be preserved. Change-Id: Ic2b728a4797d03d6718e6c9b0b6adec6dcf3bbff Bug-Url: https://bugzilla.redhat.com/1055441 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/23507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2b728a4797d03d6718e6c9b0b6adec6dcf3bbff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Integrate VM icon into Add/Edit Network dialog
by iheim＠redhat.com 21 Jan '14

21 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Integrate VM icon into Add/Edit Network dialog ...................................................................... webadmin: Integrate VM icon into Add/Edit Network dialog Reuse the VM icon next to the VM network checkbox, to strengthen the visual affinity between the checkbox and its consequences in other views. Change-Id: I40f7c7e3088af2b1da174b6896bdfce27435b423 Bug-Url: https://bugzilla.redhat.com/1028523 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40f7c7e3088af2b1da174b6896bdfce27435b423 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Add per-VM migration_downtime to REST API
by iheim＠redhat.com 21 Jan '14

21 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Add per-VM migration_downtime to REST API ...................................................................... restapi: Add per-VM migration_downtime to REST API Added migration_downtime field to VM representing maximum number of milliseconds for downtime during live migration. Due to problems representing the Integer value of 'null' which has semantic meaning on the backend, in the API we represent this "use default" option using integer "-1" which is outside the range of valid timeouts. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1055434 Change-Id: I53eaecc790d8805f55417f7eb74095001a325140 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/IntegerMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 7 files changed, 61 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/23434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53eaecc790d8805f55417f7eb74095001a325140 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Sync gluster bricks - use server uuid
by iheim＠redhat.com 21 Jan '14

21 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Sync gluster bricks - use server uuid ...................................................................... engine: Sync gluster bricks - use server uuid If server uuid is returned in getVolumesList vdsm verb, then this is used to identify the server, rather than the hostname/ip present in brick name. Also, not adding brick to volume if the brick's server cannot be resolved. Change-Id: I2076e77b5415ead7faf6641ce31588333222e70f Bug-Url: https://bugzilla.redhat.com/1038988 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java 1 file changed, 56 insertions(+), 11 deletions(-) Approvals: Sahina Bose: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2076e77b5415ead7faf6641ce31588333222e70f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Replaced "Profiles" by "vNIC Profiles"
by iheim＠redhat.com 21 Jan '14

21 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Replaced "Profiles" by "vNIC Profiles" ...................................................................... webadmin: Replaced "Profiles" by "vNIC Profiles" This to reduce ambiguity between networks and profiles. Change-Id: Ib640c51db9528855c20ea6c0e2dedcb12b83c89a Bug-Url: https://bugzilla.redhat.com/1028515 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/network/SubTabNetworkProfilePresenter.java 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib640c51db9528855c20ea6c0e2dedcb12b83c89a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: del storage conn if domain creation fails
by derez＠redhat.com 21 Jan '14

21 Jan '14

Daniel Erez has submitted this change and it was merged. Change subject: restapi: del storage conn if domain creation fails ...................................................................... restapi: del storage conn if domain creation fails Delete storage connection if storage domain creation fails in order not to leave leftovers in db from a failed operation. Note - the connection will be deleted only if it was created as part of the domain creation call. If it was created in the past and just reused with its connection id in the domain creation call, then it will not be deleted. Change-Id: I71c689ccdbcd038d1b92629b3e46691be0885321 Bug-Url: https://bugzilla.redhat.com/991470 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java 2 files changed, 26 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c689ccdbcd038d1b92629b3e46691be0885321 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in mom[master]: packaging: build: rewrite
by alitke＠redhat.com 21 Jan '14

21 Jan '14

Adam Litke has submitted this change and it was merged. Change subject: packaging: build: rewrite ...................................................................... packaging: build: rewrite * Added autogen.sh * Changed the versions style to be same as other oVirt packages * Removed unused scipts * Switched from distutils to autotools * autoconf cleanups * automake cleanups * spec cleanups * add optional syntax check Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/22874 Reviewed-by: Adam Litke <alitke(a)redhat.com> Tested-by: Adam Litke <alitke(a)redhat.com> --- M .gitignore M AUTHORS M Makefile.am D autobuild.sh A autogen.sh D build-aux/gitlog-to-changelog D build-aux/pkg-version A build/python.inc M configure.ac C contrib/Makefile.am M contrib/momd.init A doc/Makefile.am A m4/.keep A m4/ax_python_module.m4 M mom.spec.in A mom/Collectors/Makefile.am C mom/Controllers/Makefile.am C mom/HypervisorInterfaces/Makefile.am A mom/Makefile.am C mom/Policy/Makefile.am R mom/debug/Makefile.am D setup.py.in A tests/Makefile.am D tests/run_tests_local.sh A tests/run_tests_local.sh.in 25 files changed, 550 insertions(+), 466 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved Kiril Nesenko: Verified -- To view, visit http://gerrit.ovirt.org/22874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22 Gerrit-PatchSet: 15 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0