January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: wait for vdsmd initialization
by sbonazzo＠redhat.com 17 Jan '14

17 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: wait for vdsmd initialization ...................................................................... packaging: setup: wait for vdsmd initialization waiting for vdsmd full initialization, avoiding to accept has hardware info received a result as {'status': {'message': 'Recovering from crash or Initializing', 'code': 99}} Change-Id: I53eeff8b2a533bbb067a8016d941d74acab9794b Bug-Url: https://bugzilla.redhat.com/1053420 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Greg Padgett: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53eeff8b2a533bbb067a8016d941d74acab9794b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: contrib: Add systemd unit file
by alitke＠redhat.com 17 Jan '14

17 Jan '14

Adam Litke has submitted this change and it was merged. Change subject: contrib: Add systemd unit file ...................................................................... contrib: Add systemd unit file Change-Id: Ia9f6b9cb3212f7e1c05e3cf4408558859a92c963 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/22931 Reviewed-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A contrib/momd.service 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Adam Litke: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9f6b9cb3212f7e1c05e3cf4408558859a92c963 Gerrit-PatchSet: 3 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Allow enabling/disabling SSO
by juan.hernandez＠redhat.com 17 Jan '14

17 Jan '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Allow enabling/disabling SSO ...................................................................... restapi: Allow enabling/disabling SSO This small feature allows controlling SSO per VM via REST API. Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c Bug-Url: https://bugzilla.redhat.com/1035279 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SsoMethod.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/SsoMethod.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/SsoMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/SsoMapperTest.java 8 files changed, 208 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix GetWatchdogQueryTest's logic
by amureini＠redhat.com 16 Jan '14

16 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix GetWatchdogQueryTest's logic ...................................................................... core: Fix GetWatchdogQueryTest's logic The getReturnValue() method for queries always returns null, so it's pointless to check it - what's needed is to check that no watchdogs are returned for a non-existent ID. Change-Id: I349a55d5a13e06a7c2e2c0ddbd8de4e0bc46f2f1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I349a55d5a13e06a7c2e2c0ddbd8de4e0bc46f2f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixed mocking in GetWatchdogQueryTest
by amureini＠redhat.com 16 Jan '14

16 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fixed mocking in GetWatchdogQueryTest ...................................................................... core: Fixed mocking in GetWatchdogQueryTest Fixed the use of Mockito and AbstractQueryTest's methods. Change-Id: I452a91d64fa139fbd532f0fee65a25344673f52d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 7 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I452a91d64fa139fbd532f0fee65a25344673f52d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetWatchdogQueryTest: use Collections
by amureini＠redhat.com 16 Jan '14

16 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetWatchdogQueryTest: use Collections ...................................................................... core: GetWatchdogQueryTest: use Collections Replaced the usage of Arrays.asList(vmDevice) with Collections.singletonList(vmDevice), which is slightly less memory consuming. Change-Id: I51ebd9cbeefdcfdf120c23ac657f93cfd16af32a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51ebd9cbeefdcfdf120c23ac657f93cfd16af32a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetWatchdogQueryTest: assertEquals params
by amureini＠redhat.com 16 Jan '14

16 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetWatchdogQueryTest: assertEquals params ...................................................................... core: GetWatchdogQueryTest: assertEquals params Fixed the argument order for the assertEquals(expected, actual) calls so that a useful message could be printed in case of a test failure. Change-Id: Ie1413cac1597c22ecf98c3c7f3cbee6adfb1d237 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1413cac1597c22ecf98c3c7f3cbee6adfb1d237 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix and enable GetWatchdogQuery ignored test
by amureini＠redhat.com 16 Jan '14

16 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix and enable GetWatchdogQuery ignored test ...................................................................... core: Fix and enable GetWatchdogQuery ignored test Fixed GetWatchdofQueryTest.executeQueryCommandWithWatchdog() and removed the @Ignore annotation from it now that it's functioning. This patch includes: 1. Using the infrastructure provided by AbstractQueryTest. 2. Moving general initializations (e.g., the DAO) to the setUp() method, where they belong. 3. Removing unneeded Mockito calls. 4. Asserting the result from getQueryReturnValue() as queries are supposed to instead of getReturnValue() which will always return null for queries. Change-Id: I0aefd1d95cfefc4ab8391b318844dfb815f33ea5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 16 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0aefd1d95cfefc4ab8391b318844dfb815f33ea5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetWatchdogQueryTest: common set up
by amureini＠redhat.com 16 Jan '14

16 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetWatchdogQueryTest: common set up ...................................................................... core: GetWatchdogQueryTest: common set up Extracted the common set up that all the tests perform to setUp() instead of duplicating it. Change-Id: Icaae22a21f1f3e1fa1c17356e2fc26a0e9b2dc58 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaae22a21f1f3e1fa1c17356e2fc26a0e9b2dc58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetWatchdogQueryTest spec params declaration
by amureini＠redhat.com 16 Jan '14

16 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetWatchdogQueryTest spec params declaration ...................................................................... core: GetWatchdogQueryTest spec params declaration Fixed the spec params declaration to conform to Java 7's coding standard. Change-Id: I39a0ad84e827ef1676c6a7300fb73553138f21cb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39a0ad84e827ef1676c6a7300fb73553138f21cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0