January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Relax parameter checking for move disk
by amureini＠redhat.com 12 Jan '14

12 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Relax parameter checking for move disk ...................................................................... restapi: Relax parameter checking for move disk Relax the restapi tests to remove the false assumption that VdcActionParameter classes override the equals(Object) method. Change-Id: If982d07ce83a225063c2ba3b8771e0f8384b1ea6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java 2 files changed, 6 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If982d07ce83a225063c2ba3b8771e0f8384b1ea6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: findbugs: Organize equals(Object) overrides
by amureini＠redhat.com 12 Jan '14

12 Jan '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: findbugs: Organize equals(Object) overrides ...................................................................... core: findbugs: Organize equals(Object) overrides exclude-filters-general.xml excludes all warnings about not overriding equals(Object), which is a dangerous and bug-prone practice. This patch tries to reconcile this approach, and make sense of the exclusions. This patch includes: 1. Removed the equals(Object) and hashCode() from VdcActionParametersBase, as it is never used and (almost) none of the parameter classes override it, meaning that any equality check between parameter classes would be bogus. 2. Removed equals(Object) and hashCode() from RemoveNetworkParameters, as they are useless (see (1) for details), and depend on the VdcActionParametersBase's implementation which was removed anyway. 3. Implement equals(Object) and hashCode() that were missing from ExtendedVmDynamic. This mistake of omission goes to prove how this suppression was a bad idea. 4. Explicitly exclude the missing equals(Object) implementation for PolicyUnitImpl and NetworkPolicyUnit as they are not trivial to implement, and the current code base is proven to work without them. 5. Remove the all-out exclusion of unimplemented equals(Object) methods from exclude-filters-general.xml to avoid bugs like the one described in (3). Change-Id: I3384d0c85f3c8ba91e25b584659e5e5f4617acb4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ExtendedVmDynamic.java M exclude-filters-general.xml 5 files changed, 46 insertions(+), 142 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3384d0c85f3c8ba91e25b584659e5e5f4617acb4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Move NetworkLabel entity to pseudo package
by masayag＠redhat.com 12 Jan '14

12 Jan '14

Moti Asayag has submitted this change and it was merged. Change subject: core: Move NetworkLabel entity to pseudo package ...................................................................... core: Move NetworkLabel entity to pseudo package According to the suggeted in http://gerrit.ovirt.org/#/c/22802/5/backend/manager/modules/common/src/main… and since the NetworkLabel isn't a real business entity, it is moved to a /businessentities/pseudo/ package. Change-Id: I74b897dce328a2ee2869096ec9bc53e3a8ec5a9f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetNetworkLabelsByHostNicIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetNetworkLabelsByNetworkIdQuery.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/pseudo/NetworkLabel.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74b897dce328a2ee2869096ec9bc53e3a8ec5a9f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add dao_unit_test to DeleteCompletedJobsOlderThanDate
by emesika＠redhat.com 12 Jan '14

12 Jan '14

Eli Mesika has submitted this change and it was merged. Change subject: engine: Add dao_unit_test to DeleteCompletedJobsOlderThanDate ...................................................................... engine: Add dao_unit_test to DeleteCompletedJobsOlderThanDate Added a unit test to check that DeleteCompletedJobsOlderThanDate deletes jobs and steps that have no async-tasks Change-Id: Iba883b90fc8fc89096a98beec796d4600714eb15 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 34 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba883b90fc8fc89096a98beec796d4600714eb15 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[node-3.0]: Replace centos macro for rhel
by dougsland＠redhat.com 11 Jan '14

11 Jan '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Replace centos macro for rhel ...................................................................... Replace centos macro for rhel Koji system doesn't understand centos macro and to generate EL6 rpm compatible on it we should replace the macro (there is no vhostmd build for el6 upstream). On the other hand, in downstream there is vhostmd package and we should keep that compatible with downstream only patch. Change-Id: I3a6a6086afec7d06df464f843e86679cb8b7b80e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a6a6086afec7d06df464f843e86679cb8b7b80e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: node-3.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>

1 0

Change in ovirt-node-plugin-vdsm[master]: Replace centos macro for rhel
by dougsland＠redhat.com 11 Jan '14

11 Jan '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Replace centos macro for rhel ...................................................................... Replace centos macro for rhel Koji system doesn't understand centos macro and to generate EL6 rpm compatible on it we should replace the macro (there is no vhostmd build for el6 upstream). On the other hand, in downstream there is vhostmd package and we should keep that compatible with downstream only patch. Change-Id: I3a6a6086afec7d06df464f843e86679cb8b7b80e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a6a6086afec7d06df464f843e86679cb8b7b80e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[node-3.0]: engine_page: management info for autoinstall
by dougsland＠redhat.com 11 Jan '14

11 Jan '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: management info for autoinstall ...................................................................... engine_page: management info for autoinstall We should provide management info also for autoinstall, not only for tradicional TUI registration. Change-Id: I58250e31b60ba863b851a3b6b0cfa1a59165c44b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1048929 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 26 insertions(+), 14 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58250e31b60ba863b851a3b6b0cfa1a59165c44b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: node-3.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: management info for autoinstall
by dougsland＠redhat.com 11 Jan '14

11 Jan '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: management info for autoinstall ...................................................................... engine_page: management info for autoinstall We should provide management info also for autoinstall, not only for tradicional TUI registration. Change-Id: I58250e31b60ba863b851a3b6b0cfa1a59165c44b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1048929 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 26 insertions(+), 13 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Ryan Barry: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58250e31b60ba863b851a3b6b0cfa1a59165c44b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Revert "Sync spec file with official fedora spec file"
by alitke＠redhat.com 10 Jan '14

10 Jan '14

Adam Litke has submitted this change and it was merged. Change subject: Revert "Sync spec file with official fedora spec file" ...................................................................... Revert "Sync spec file with official fedora spec file" This reverts commit 290456c8b168069480d705d08af667ec60bbf4c5. Patch causing build failures... need to investigate further. Change-Id: Id5ab568c9060bed05a4a1252a9468e71533a4904 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/23149 --- M mom.spec.in 1 file changed, 10 insertions(+), 44 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5ab568c9060bed05a4a1252a9468e71533a4904 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>

1 0

Change in mom[master]: Revert "build: Fix %install on < F20"
by alitke＠redhat.com 10 Jan '14

10 Jan '14

Adam Litke has submitted this change and it was merged. Change subject: Revert "build: Fix %install on < F20" ...................................................................... Revert "build: Fix %install on < F20" This reverts commit 1e7d809fc54f90130a3ff57c9d0ca28c95e2b7e5. Patch causing build failures... need to investigate further. Change-Id: Iec0a01b59ae4fa74fd6a4e26cec1aaaedcc04cb5 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/23148 --- M mom.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adam Litke: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec0a01b59ae4fa74fd6a4e26cec1aaaedcc04cb5 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>

1 0