January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Return Additional Info For 400 Messages (#867794)
by oliel＠redhat.com 08 Jan '14

08 Jan '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: Return Additional Info For 400 Messages (#867794) ...................................................................... restapi: Return Additional Info For 400 Messages (#867794) When user issues a POST or PUT request, and the body is malformed, the application will identify, according to the context, what the user was trying to do, and return the correct usage from RSDL. This patch includes work to make RsdlBuilder a stand-alone tool which does not require the application server. The solution does not require this direcly, but it is better structured this way. Right now the solution does not apply for YAML format, because of other issues we have with Yaml format, but it can very easily be used also for Yaml in the future. Example of output: POST .../api/tags asdfas dlkh (some malformed request body) <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <usage_message> <message>Request syntactically incorrect. See the link description below for the correct usage:</message> <detailedLink href="/ovirt-engine/api/tags" rel="add"> <description>add a new tag to the system</description> <request> <http_method>POST</http_method> <headers> <header required="true"> <name>Content-Type</name> <value>application/xml|json</value> </header> <header required="false"> <name>Correlation-Id</name> <value>any string</value> </header> </headers> <body> <type>Tag</type> <parameters_set> <parameter required="true" type="xs:string"> <name>tag.name</name> </parameter> <parameter required="false" type="xs:string"> <name>tag.description</name> </parameter> <parameter required="false" type="xs:string"> <name>tag.parent.tag.id|name</name> </parameter> </parameters_set> </body> </request> <response> <type>Tag</type> </response> </detailedLink> </usage_message> Bug-Url: http://bugzilla.redhat.com/867794 Change-Id: Ic7a6da4fbb00ea5f1e6919ddfe21dd7b3dd126fd Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbExceptionMapper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JsonExceptionMapper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/UsageFinder.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ApiRootLinksCreator.java 8 files changed, 301 insertions(+), 101 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7a6da4fbb00ea5f1e6919ddfe21dd7b3dd126fd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: cleanup: remove unused variable
by sbonazzo＠redhat.com 08 Jan '14

08 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: cleanup: remove unused variable ...................................................................... packaging: setup: cleanup: remove unused variable Change-Id: I24246cabe00c5f99df812a6f6daf42caba69f312 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24246cabe00c5f99df812a6f6daf42caba69f312 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: console native execution in iframes
by tjelinek＠redhat.com 08 Jan '14

08 Jan '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: console native execution in iframes ...................................................................... frontend: console native execution in iframes currently when user runs a console using 'native' invocation, the request is made in a new tab. this patch changes the behavior and opens requests in iframes instead. this is more convenient as the execution doesn't open a new tab for every vm involved. Change-Id: I042213dd16fdab94b431ea0564a3780b79234e69 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1026842 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java 1 file changed, 14 insertions(+), 19 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I042213dd16fdab94b431ea0564a3780b79234e69 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: setup: fix NULL user passwords on import
by ydary＠redhat.com 08 Jan '14

08 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix NULL user passwords on import ...................................................................... packaging: setup: fix NULL user passwords on import Bug-Url: https://bugzilla.redhat.com/1049349 Change-Id: Ibc7202233439c9e632fe38b56fedabe841bf1223 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc7202233439c9e632fe38b56fedabe841bf1223 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: fix NULL user passwords on import
by ydary＠redhat.com 08 Jan '14

08 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix NULL user passwords on import ...................................................................... packaging: setup: fix NULL user passwords on import Bug-Url: https://bugzilla.redhat.com/1049349 Change-Id: Ibc7202233439c9e632fe38b56fedabe841bf1223 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc7202233439c9e632fe38b56fedabe841bf1223 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: setup: preserveReportsJobs -> preserveReports
by ydary＠redhat.com 08 Jan '14

08 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: preserveReportsJobs -> preserveReports ...................................................................... packaging: setup: preserveReportsJobs -> preserveReports Change-Id: Ib66f2c0b2aef91845e746aad470aac8e651dc247 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib66f2c0b2aef91845e746aad470aac8e651dc247 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: preserveReportsJobs -> preserveReports
by ydary＠redhat.com 08 Jan '14

08 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: preserveReportsJobs -> preserveReports ...................................................................... packaging: setup: preserveReportsJobs -> preserveReports Change-Id: Ib66f2c0b2aef91845e746aad470aac8e651dc247 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib66f2c0b2aef91845e746aad470aac8e651dc247 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [Fix] Disabled Balloon in Add Vm
by rgolan＠redhat.com 08 Jan '14

08 Jan '14

Roy Golan has submitted this change and it was merged. Change subject: core: [Fix] Disabled Balloon in Add Vm ...................................................................... core: [Fix] Disabled Balloon in Add Vm Currently, it is impossible to add a VM with balloon disabled (REST/UI), this change fixes this bug. Change-Id: I508ff77c1e309be0b492f46c31311e03f33fc728 Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1049343 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 4 files changed, 15 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I508ff77c1e309be0b492f46c31311e03f33fc728 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Disk interface validation
by tjelinek＠redhat.com 08 Jan '14

08 Jan '14

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Disk interface validation ...................................................................... engine: Disk interface validation * This change displays an error if the disk interface is not compatible with the selected operating system. * It also includes a modification to the GetAllAttachableDisks query so it only returns disks that have interfaces compatible with the VM passed as a parameter. Change-Id: Ibe095557089aa5670c50eaa120eac9f60e13aea0 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DiskInterface.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 19 files changed, 285 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe095557089aa5670c50eaa120eac9f60e13aea0 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: database: backup reuse
by sbonazzo＠redhat.com 08 Jan '14

08 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: database: backup reuse ...................................................................... packaging: setup: database: backup reuse Change-Id: I524565f07266aae831b90a7ee874e31662807bc7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/database.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py 4 files changed, 12 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I524565f07266aae831b90a7ee874e31662807bc7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0